diff options
author | Andrew Morton <akpm@osdl.org> | 2005-10-28 18:12:02 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@mandriva.com> | 2005-10-31 13:41:45 -0500 |
commit | a3d7a9d77533d7516a8cfb8e2b612cd5ead4fa59 (patch) | |
tree | 62ea3dce8a8d7c6b984c0815347de9ca187e8335 | |
parent | 6b7d31fcdda5938e5d3f1f8b0922cc25aa200dfc (diff) |
[ROSE]: rose_heartbeat_expiry() locking fix
Missing unlock, as noted by Ted Unangst <tedu@coverity.com>.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
-rw-r--r-- | net/rose/rose_timer.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/rose/rose_timer.c b/net/rose/rose_timer.c index 50ae0371dab8..b6c8f38cc26c 100644 --- a/net/rose/rose_timer.c +++ b/net/rose/rose_timer.c | |||
@@ -138,6 +138,7 @@ static void rose_heartbeat_expiry(unsigned long param) | |||
138 | is accepted() it isn't 'dead' so doesn't get removed. */ | 138 | is accepted() it isn't 'dead' so doesn't get removed. */ |
139 | if (sock_flag(sk, SOCK_DESTROY) || | 139 | if (sock_flag(sk, SOCK_DESTROY) || |
140 | (sk->sk_state == TCP_LISTEN && sock_flag(sk, SOCK_DEAD))) { | 140 | (sk->sk_state == TCP_LISTEN && sock_flag(sk, SOCK_DEAD))) { |
141 | bh_unlock_sock(sk); | ||
141 | rose_destroy_socket(sk); | 142 | rose_destroy_socket(sk); |
142 | return; | 143 | return; |
143 | } | 144 | } |