diff options
author | Kevin Dankwardt <k@kcomputing.com> | 2010-02-10 09:43:40 -0500 |
---|---|---|
committer | OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> | 2010-02-10 09:49:08 -0500 |
commit | eeb5b4ae81f4a750355fa0c15f4fea22fdf83be1 (patch) | |
tree | d71cdc178b8643a5ddced54dc540403d11af9fa1 | |
parent | 8045e2985012bdb95d832dfbcceae1815880a6ed (diff) |
fat: Fix stat->f_namelen
I found that the length of a file name when created cannot exceed 255
characters, yet, pathconf(), via statfs(), returns the maximum as 260.
Signed-off-by: Kevin Dankwardt <k@kcomputing.com>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-rw-r--r-- | fs/fat/inode.c | 2 | ||||
-rw-r--r-- | fs/fat/namei_vfat.c | 6 | ||||
-rw-r--r-- | include/linux/msdos_fs.h | 3 |
3 files changed, 6 insertions, 5 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 14da530b05ca..d0a504c8feef 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -558,7 +558,7 @@ static int fat_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
558 | buf->f_bavail = sbi->free_clusters; | 558 | buf->f_bavail = sbi->free_clusters; |
559 | buf->f_fsid.val[0] = (u32)id; | 559 | buf->f_fsid.val[0] = (u32)id; |
560 | buf->f_fsid.val[1] = (u32)(id >> 32); | 560 | buf->f_fsid.val[1] = (u32)(id >> 32); |
561 | buf->f_namelen = sbi->options.isvfat ? 260 : 12; | 561 | buf->f_namelen = sbi->options.isvfat ? FAT_LFN_LEN : 12; |
562 | 562 | ||
563 | return 0; | 563 | return 0; |
564 | } | 564 | } |
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c index 411c192a05fa..c1ef50154868 100644 --- a/fs/fat/namei_vfat.c +++ b/fs/fat/namei_vfat.c | |||
@@ -502,14 +502,14 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname, | |||
502 | *outlen = utf8s_to_utf16s(name, len, (wchar_t *)outname); | 502 | *outlen = utf8s_to_utf16s(name, len, (wchar_t *)outname); |
503 | if (*outlen < 0) | 503 | if (*outlen < 0) |
504 | return *outlen; | 504 | return *outlen; |
505 | else if (*outlen > 255) | 505 | else if (*outlen > FAT_LFN_LEN) |
506 | return -ENAMETOOLONG; | 506 | return -ENAMETOOLONG; |
507 | 507 | ||
508 | op = &outname[*outlen * sizeof(wchar_t)]; | 508 | op = &outname[*outlen * sizeof(wchar_t)]; |
509 | } else { | 509 | } else { |
510 | if (nls) { | 510 | if (nls) { |
511 | for (i = 0, ip = name, op = outname, *outlen = 0; | 511 | for (i = 0, ip = name, op = outname, *outlen = 0; |
512 | i < len && *outlen <= 255; | 512 | i < len && *outlen <= FAT_LFN_LEN; |
513 | *outlen += 1) | 513 | *outlen += 1) |
514 | { | 514 | { |
515 | if (escape && (*ip == ':')) { | 515 | if (escape && (*ip == ':')) { |
@@ -549,7 +549,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname, | |||
549 | return -ENAMETOOLONG; | 549 | return -ENAMETOOLONG; |
550 | } else { | 550 | } else { |
551 | for (i = 0, ip = name, op = outname, *outlen = 0; | 551 | for (i = 0, ip = name, op = outname, *outlen = 0; |
552 | i < len && *outlen <= 255; | 552 | i < len && *outlen <= FAT_LFN_LEN; |
553 | i++, *outlen += 1) | 553 | i++, *outlen += 1) |
554 | { | 554 | { |
555 | *op++ = *ip++; | 555 | *op++ = *ip++; |
diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h index ce38f1caa5e1..34066e65fdeb 100644 --- a/include/linux/msdos_fs.h +++ b/include/linux/msdos_fs.h | |||
@@ -15,6 +15,7 @@ | |||
15 | #define MSDOS_DPB_BITS 4 /* log2(MSDOS_DPB) */ | 15 | #define MSDOS_DPB_BITS 4 /* log2(MSDOS_DPB) */ |
16 | #define MSDOS_DPS (SECTOR_SIZE / sizeof(struct msdos_dir_entry)) | 16 | #define MSDOS_DPS (SECTOR_SIZE / sizeof(struct msdos_dir_entry)) |
17 | #define MSDOS_DPS_BITS 4 /* log2(MSDOS_DPS) */ | 17 | #define MSDOS_DPS_BITS 4 /* log2(MSDOS_DPS) */ |
18 | #define MSDOS_LONGNAME 256 /* maximum name length */ | ||
18 | #define CF_LE_W(v) le16_to_cpu(v) | 19 | #define CF_LE_W(v) le16_to_cpu(v) |
19 | #define CF_LE_L(v) le32_to_cpu(v) | 20 | #define CF_LE_L(v) le32_to_cpu(v) |
20 | #define CT_LE_W(v) cpu_to_le16(v) | 21 | #define CT_LE_W(v) cpu_to_le16(v) |
@@ -47,8 +48,8 @@ | |||
47 | #define DELETED_FLAG 0xe5 /* marks file as deleted when in name[0] */ | 48 | #define DELETED_FLAG 0xe5 /* marks file as deleted when in name[0] */ |
48 | #define IS_FREE(n) (!*(n) || *(n) == DELETED_FLAG) | 49 | #define IS_FREE(n) (!*(n) || *(n) == DELETED_FLAG) |
49 | 50 | ||
51 | #define FAT_LFN_LEN 255 /* maximum long name length */ | ||
50 | #define MSDOS_NAME 11 /* maximum name length */ | 52 | #define MSDOS_NAME 11 /* maximum name length */ |
51 | #define MSDOS_LONGNAME 256 /* maximum name length */ | ||
52 | #define MSDOS_SLOTS 21 /* max # of slots for short and long names */ | 53 | #define MSDOS_SLOTS 21 /* max # of slots for short and long names */ |
53 | #define MSDOS_DOT ". " /* ".", padded to MSDOS_NAME chars */ | 54 | #define MSDOS_DOT ". " /* ".", padded to MSDOS_NAME chars */ |
54 | #define MSDOS_DOTDOT ".. " /* "..", padded to MSDOS_NAME chars */ | 55 | #define MSDOS_DOTDOT ".. " /* "..", padded to MSDOS_NAME chars */ |