diff options
author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2011-03-21 10:26:42 -0400 |
---|---|---|
committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2011-05-13 12:23:53 -0400 |
commit | 1bbfc848a915081237660d898bbcf50e4a8fc59f (patch) | |
tree | 50016a57e5f1e2e8f0521a49a66e5cb0ad637ff9 | |
parent | 693d92a1bbc9e42681c42ed190bd42b636ca876f (diff) |
UBIFS: make debugfs files non-seekable
Turn the debufs files UBIFS maintains into non-seekable. Indeed, none
of them is supposed to be seek'ed.
Do this by making the '.lseek()' handler to be 'no_llseek()' and by
using 'nonseekable_open()' in the '.open()' operation.
This does mean an API break but this debugging API is only used by a couple
of test scripts which do not rely in the 'llseek()' operation.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
-rw-r--r-- | fs/ubifs/debug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 004d3745dc45..da9ecddf028a 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c | |||
@@ -2784,7 +2784,7 @@ void dbg_debugfs_exit(void) | |||
2784 | static int open_debugfs_file(struct inode *inode, struct file *file) | 2784 | static int open_debugfs_file(struct inode *inode, struct file *file) |
2785 | { | 2785 | { |
2786 | file->private_data = inode->i_private; | 2786 | file->private_data = inode->i_private; |
2787 | return 0; | 2787 | return nonseekable_open(inode, file); |
2788 | } | 2788 | } |
2789 | 2789 | ||
2790 | static ssize_t write_debugfs_file(struct file *file, const char __user *buf, | 2790 | static ssize_t write_debugfs_file(struct file *file, const char __user *buf, |
@@ -2814,7 +2814,7 @@ static const struct file_operations dfs_fops = { | |||
2814 | .open = open_debugfs_file, | 2814 | .open = open_debugfs_file, |
2815 | .write = write_debugfs_file, | 2815 | .write = write_debugfs_file, |
2816 | .owner = THIS_MODULE, | 2816 | .owner = THIS_MODULE, |
2817 | .llseek = default_llseek, | 2817 | .llseek = no_llseek, |
2818 | }; | 2818 | }; |
2819 | 2819 | ||
2820 | /** | 2820 | /** |