diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-30 22:50:03 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-30 23:07:22 -0400 |
| commit | 6d98ca736441029e4e87ad3b6dc4a8645dc4c6d3 (patch) | |
| tree | 5aab64f86dc6697bba085884c28f32ea031a1e99 | |
| parent | 958a2f29a6520a1d2973077ce7854ea9a44f48a2 (diff) | |
x86: Mark OPTIMIZE_INLINING broken
So Ingo finally did figure out why UML broke with this option: UML
passes gcc the -fno-unit-at-a-time flag, and apparently that wreaks
havoc with gcc's inlining.
We could turn off -fno-unit-at-a-time for UML for gcc4+ (which is what
x86 does), but there's bad blood about this whole option, and it does
show that the thing is just fragile as heck.
So let tempers cool, and disable the thing, and we can revisit the
decision later.
Cc: Adrian Bunk <bunk@kernel.org>
Cc: David Miller <davem@davemloft.net>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | arch/x86/Kconfig.debug | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 5fc8d0b3191d..ac1e31ba4795 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug | |||
| @@ -257,6 +257,7 @@ config CPA_DEBUG | |||
| 257 | 257 | ||
| 258 | config OPTIMIZE_INLINING | 258 | config OPTIMIZE_INLINING |
| 259 | bool "Allow gcc to uninline functions marked 'inline'" | 259 | bool "Allow gcc to uninline functions marked 'inline'" |
| 260 | depends on BROKEN | ||
| 260 | help | 261 | help |
| 261 | This option determines if the kernel forces gcc to inline the functions | 262 | This option determines if the kernel forces gcc to inline the functions |
| 262 | developers have marked 'inline'. Doing so takes away freedom from gcc to | 263 | developers have marked 'inline'. Doing so takes away freedom from gcc to |