aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGlauber de Oliveira Costa <gcosta@redhat.com>2008-03-19 13:25:16 -0400
committerIngo Molnar <mingo@elte.hu>2008-04-17 11:41:00 -0400
commitf3ce4466abd6f5173db98b5cc2269c139cd1790a (patch)
tree15df6f7dad31bfaace208856b0222fb45111f7af
parentf915d7f46b84192a19647c8e6b111a7e518875cb (diff)
x86: make __smp_prepare_cpu void
We have already removed the only condition that could fail here. so just don't test for any return value Signed-off-by: Glauber Costa <gcosta@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/kernel/smpboot_32.c13
1 files changed, 3 insertions, 10 deletions
diff --git a/arch/x86/kernel/smpboot_32.c b/arch/x86/kernel/smpboot_32.c
index 147af81f70ea..ee6f3bd70390 100644
--- a/arch/x86/kernel/smpboot_32.c
+++ b/arch/x86/kernel/smpboot_32.c
@@ -704,11 +704,11 @@ static void __cpuinit do_warm_boot_cpu(struct work_struct *work)
704 complete(info->complete); 704 complete(info->complete);
705} 705}
706 706
707static int __cpuinit __smp_prepare_cpu(int cpu) 707static void __cpuinit __smp_prepare_cpu(int cpu)
708{ 708{
709 DECLARE_COMPLETION_ONSTACK(done); 709 DECLARE_COMPLETION_ONSTACK(done);
710 struct warm_boot_cpu_info info; 710 struct warm_boot_cpu_info info;
711 int apicid, ret; 711 int apicid;
712 712
713 apicid = per_cpu(x86_cpu_to_apicid, cpu); 713 apicid = per_cpu(x86_cpu_to_apicid, cpu);
714 714
@@ -725,9 +725,6 @@ static int __cpuinit __smp_prepare_cpu(int cpu)
725 wait_for_completion(&done); 725 wait_for_completion(&done);
726 726
727 zap_low_mappings(); 727 zap_low_mappings();
728 ret = 0;
729exit:
730 return ret;
731} 728}
732#endif 729#endif
733 730
@@ -950,7 +947,6 @@ int __cpuinit native_cpu_up(unsigned int cpu)
950{ 947{
951 int apicid = cpu_present_to_apicid(cpu); 948 int apicid = cpu_present_to_apicid(cpu);
952 unsigned long flags; 949 unsigned long flags;
953 int ret = 0;
954 950
955 WARN_ON(irqs_disabled()); 951 WARN_ON(irqs_disabled());
956 952
@@ -971,10 +967,7 @@ int __cpuinit native_cpu_up(unsigned int cpu)
971 * when a cpu is taken offline from cpu_exit_clear(). 967 * when a cpu is taken offline from cpu_exit_clear().
972 */ 968 */
973 if (!cpu_isset(cpu, cpu_callin_map)) 969 if (!cpu_isset(cpu, cpu_callin_map))
974 ret = __smp_prepare_cpu(cpu); 970 __smp_prepare_cpu(cpu);
975
976 if (ret)
977 return -EIO;
978#endif 971#endif
979 972
980 /* In case one didn't come up */ 973 /* In case one didn't come up */