aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2010-03-18 16:43:09 -0400
committerSage Weil <sage@newdream.net>2010-03-23 10:46:58 -0400
commite4cb4cb8a03adde1aa4b874623c50b9a5b56e635 (patch)
tree52d7ab8b4f589a1cf9b5e3662e952a1ec33903d5
parentefd7576b2392cc5a0934352936d793e8884c46bf (diff)
ceph: prevent dup stale messages to console for restarting mds
Prevent duplicate 'mds0 caps stale' message from spamming the console every few seconds while the MDS restarts. Set s_renew_requested earlier, so that we only print the message once, even if we don't send an actual request. Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--fs/ceph/mds_client.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 5ec864198368..5cbf46abfee3 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -863,6 +863,7 @@ static int send_renew_caps(struct ceph_mds_client *mdsc,
863 if (time_after_eq(jiffies, session->s_cap_ttl) && 863 if (time_after_eq(jiffies, session->s_cap_ttl) &&
864 time_after_eq(session->s_cap_ttl, session->s_renew_requested)) 864 time_after_eq(session->s_cap_ttl, session->s_renew_requested))
865 pr_info("mds%d caps stale\n", session->s_mds); 865 pr_info("mds%d caps stale\n", session->s_mds);
866 session->s_renew_requested = jiffies;
866 867
867 /* do not try to renew caps until a recovering mds has reconnected 868 /* do not try to renew caps until a recovering mds has reconnected
868 * with its clients. */ 869 * with its clients. */
@@ -875,7 +876,6 @@ static int send_renew_caps(struct ceph_mds_client *mdsc,
875 876
876 dout("send_renew_caps to mds%d (%s)\n", session->s_mds, 877 dout("send_renew_caps to mds%d (%s)\n", session->s_mds,
877 ceph_mds_state_name(state)); 878 ceph_mds_state_name(state));
878 session->s_renew_requested = jiffies;
879 msg = create_session_msg(CEPH_SESSION_REQUEST_RENEWCAPS, 879 msg = create_session_msg(CEPH_SESSION_REQUEST_RENEWCAPS,
880 ++session->s_renew_seq); 880 ++session->s_renew_seq);
881 if (IS_ERR(msg)) 881 if (IS_ERR(msg))