diff options
author | NeilBrown <neilb@suse.de> | 2007-09-27 06:47:43 -0400 |
---|---|---|
committer | Jens Axboe <axboe@carl.home.kernel.dk> | 2007-10-10 03:25:57 -0400 |
commit | 6712ecf8f648118c3363c142196418f89a510b90 (patch) | |
tree | 347d39a7d5a7ed96d3b1afecd28de2a0f98b98c9 | |
parent | 5bb23a688b2de23d7765a1dd439d89c038378978 (diff) |
Drop 'size' argument from bio_endio and bi_end_io
As bi_end_io is only called once when the reqeust is complete,
the 'size' argument is now redundant. Remove it.
Now there is no need for bio_endio to subtract the size completed
from bi_size. So don't do that either.
While we are at it, change bi_end_io to return void.
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
45 files changed, 132 insertions, 328 deletions
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c index b55ed0df33f0..cd9d2c5d91ae 100644 --- a/block/ll_rw_blk.c +++ b/block/ll_rw_blk.c | |||
@@ -547,7 +547,7 @@ static void req_bio_endio(struct request *rq, struct bio *bio, | |||
547 | bio->bi_size -= nbytes; | 547 | bio->bi_size -= nbytes; |
548 | bio->bi_sector += (nbytes >> 9); | 548 | bio->bi_sector += (nbytes >> 9); |
549 | if (bio->bi_size == 0) | 549 | if (bio->bi_size == 0) |
550 | bio_endio(bio, bio->bi_size, error); | 550 | bio_endio(bio, error); |
551 | } else { | 551 | } else { |
552 | 552 | ||
553 | /* | 553 | /* |
@@ -2401,7 +2401,7 @@ static int __blk_rq_map_user(struct request_queue *q, struct request *rq, | |||
2401 | return bio->bi_size; | 2401 | return bio->bi_size; |
2402 | 2402 | ||
2403 | /* if it was boucned we must call the end io function */ | 2403 | /* if it was boucned we must call the end io function */ |
2404 | bio_endio(bio, bio->bi_size, 0); | 2404 | bio_endio(bio, 0); |
2405 | __blk_rq_unmap_user(orig_bio); | 2405 | __blk_rq_unmap_user(orig_bio); |
2406 | bio_put(bio); | 2406 | bio_put(bio); |
2407 | return ret; | 2407 | return ret; |
@@ -2510,7 +2510,7 @@ int blk_rq_map_user_iov(struct request_queue *q, struct request *rq, | |||
2510 | return PTR_ERR(bio); | 2510 | return PTR_ERR(bio); |
2511 | 2511 | ||
2512 | if (bio->bi_size != len) { | 2512 | if (bio->bi_size != len) { |
2513 | bio_endio(bio, bio->bi_size, 0); | 2513 | bio_endio(bio, 0); |
2514 | bio_unmap_user(bio); | 2514 | bio_unmap_user(bio); |
2515 | return -EINVAL; | 2515 | return -EINVAL; |
2516 | } | 2516 | } |
@@ -3040,7 +3040,7 @@ out: | |||
3040 | return 0; | 3040 | return 0; |
3041 | 3041 | ||
3042 | end_io: | 3042 | end_io: |
3043 | bio_endio(bio, nr_sectors << 9, err); | 3043 | bio_endio(bio, err); |
3044 | return 0; | 3044 | return 0; |
3045 | } | 3045 | } |
3046 | 3046 | ||
@@ -3187,7 +3187,7 @@ static inline void __generic_make_request(struct bio *bio) | |||
3187 | bdevname(bio->bi_bdev, b), | 3187 | bdevname(bio->bi_bdev, b), |
3188 | (long long) bio->bi_sector); | 3188 | (long long) bio->bi_sector); |
3189 | end_io: | 3189 | end_io: |
3190 | bio_endio(bio, bio->bi_size, -EIO); | 3190 | bio_endio(bio, -EIO); |
3191 | break; | 3191 | break; |
3192 | } | 3192 | } |
3193 | 3193 | ||
diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index 007faaf008e7..b1d00ef6659c 100644 --- a/drivers/block/aoe/aoeblk.c +++ b/drivers/block/aoe/aoeblk.c | |||
@@ -138,7 +138,7 @@ aoeblk_make_request(struct request_queue *q, struct bio *bio) | |||
138 | buf = mempool_alloc(d->bufpool, GFP_NOIO); | 138 | buf = mempool_alloc(d->bufpool, GFP_NOIO); |
139 | if (buf == NULL) { | 139 | if (buf == NULL) { |
140 | printk(KERN_INFO "aoe: buf allocation failure\n"); | 140 | printk(KERN_INFO "aoe: buf allocation failure\n"); |
141 | bio_endio(bio, bio->bi_size, -ENOMEM); | 141 | bio_endio(bio, -ENOMEM); |
142 | return 0; | 142 | return 0; |
143 | } | 143 | } |
144 | memset(buf, 0, sizeof(*buf)); | 144 | memset(buf, 0, sizeof(*buf)); |
@@ -159,7 +159,7 @@ aoeblk_make_request(struct request_queue *q, struct bio *bio) | |||
159 | d->aoemajor, d->aoeminor); | 159 | d->aoemajor, d->aoeminor); |
160 | spin_unlock_irqrestore(&d->lock, flags); | 160 | spin_unlock_irqrestore(&d->lock, flags); |
161 | mempool_free(buf, d->bufpool); | 161 | mempool_free(buf, d->bufpool); |
162 | bio_endio(bio, bio->bi_size, -ENXIO); | 162 | bio_endio(bio, -ENXIO); |
163 | return 0; | 163 | return 0; |
164 | } | 164 | } |
165 | 165 | ||
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 01fbdd38e3be..5abae34ad65b 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c | |||
@@ -652,7 +652,7 @@ aoecmd_ata_rsp(struct sk_buff *skb) | |||
652 | disk_stat_add(disk, sectors[rw], n_sect); | 652 | disk_stat_add(disk, sectors[rw], n_sect); |
653 | disk_stat_add(disk, io_ticks, duration); | 653 | disk_stat_add(disk, io_ticks, duration); |
654 | n = (buf->flags & BUFFL_FAIL) ? -EIO : 0; | 654 | n = (buf->flags & BUFFL_FAIL) ? -EIO : 0; |
655 | bio_endio(buf->bio, buf->bio->bi_size, n); | 655 | bio_endio(buf->bio, n); |
656 | mempool_free(buf, d->bufpool); | 656 | mempool_free(buf, d->bufpool); |
657 | } | 657 | } |
658 | } | 658 | } |
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index 05a97197c918..51f50710e5fc 100644 --- a/drivers/block/aoe/aoedev.c +++ b/drivers/block/aoe/aoedev.c | |||
@@ -119,7 +119,7 @@ aoedev_downdev(struct aoedev *d) | |||
119 | bio = buf->bio; | 119 | bio = buf->bio; |
120 | if (--buf->nframesout == 0) { | 120 | if (--buf->nframesout == 0) { |
121 | mempool_free(buf, d->bufpool); | 121 | mempool_free(buf, d->bufpool); |
122 | bio_endio(bio, bio->bi_size, -EIO); | 122 | bio_endio(bio, -EIO); |
123 | } | 123 | } |
124 | skb_shinfo(f->skb)->nr_frags = f->skb->data_len = 0; | 124 | skb_shinfo(f->skb)->nr_frags = f->skb->data_len = 0; |
125 | } | 125 | } |
@@ -130,7 +130,7 @@ aoedev_downdev(struct aoedev *d) | |||
130 | list_del(d->bufq.next); | 130 | list_del(d->bufq.next); |
131 | bio = buf->bio; | 131 | bio = buf->bio; |
132 | mempool_free(buf, d->bufpool); | 132 | mempool_free(buf, d->bufpool); |
133 | bio_endio(bio, bio->bi_size, -EIO); | 133 | bio_endio(bio, -EIO); |
134 | } | 134 | } |
135 | 135 | ||
136 | if (d->gd) | 136 | if (d->gd) |
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 084358a828e9..28d145756f6c 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
@@ -1194,7 +1194,7 @@ static inline void complete_buffers(struct bio *bio, int status) | |||
1194 | int nr_sectors = bio_sectors(bio); | 1194 | int nr_sectors = bio_sectors(bio); |
1195 | 1195 | ||
1196 | bio->bi_next = NULL; | 1196 | bio->bi_next = NULL; |
1197 | bio_endio(bio, nr_sectors << 9, status ? 0 : -EIO); | 1197 | bio_endio(bio, status ? 0 : -EIO); |
1198 | bio = xbh; | 1198 | bio = xbh; |
1199 | } | 1199 | } |
1200 | } | 1200 | } |
diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index eb9799acf65b..3853c9a38d6a 100644 --- a/drivers/block/cpqarray.c +++ b/drivers/block/cpqarray.c | |||
@@ -987,7 +987,7 @@ static inline void complete_buffers(struct bio *bio, int ok) | |||
987 | xbh = bio->bi_next; | 987 | xbh = bio->bi_next; |
988 | bio->bi_next = NULL; | 988 | bio->bi_next = NULL; |
989 | 989 | ||
990 | bio_endio(bio, nr_sectors << 9, ok ? 0 : -EIO); | 990 | bio_endio(bio, ok ? 0 : -EIO); |
991 | 991 | ||
992 | bio = xbh; | 992 | bio = xbh; |
993 | } | 993 | } |
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index f0a86e201b44..80483aac4cc9 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c | |||
@@ -3810,14 +3810,10 @@ static int check_floppy_change(struct gendisk *disk) | |||
3810 | * a disk in the drive, and whether that disk is writable. | 3810 | * a disk in the drive, and whether that disk is writable. |
3811 | */ | 3811 | */ |
3812 | 3812 | ||
3813 | static int floppy_rb0_complete(struct bio *bio, unsigned int bytes_done, | 3813 | static void floppy_rb0_complete(struct bio *bio, |
3814 | int err) | 3814 | int err) |
3815 | { | 3815 | { |
3816 | if (bio->bi_size) | ||
3817 | return 1; | ||
3818 | |||
3819 | complete((struct completion *)bio->bi_private); | 3816 | complete((struct completion *)bio->bi_private); |
3820 | return 0; | ||
3821 | } | 3817 | } |
3822 | 3818 | ||
3823 | static int __floppy_read_block_0(struct block_device *bdev) | 3819 | static int __floppy_read_block_0(struct block_device *bdev) |
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 9f015fce4135..b9233a06934c 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c | |||
@@ -551,7 +551,7 @@ static int loop_make_request(struct request_queue *q, struct bio *old_bio) | |||
551 | 551 | ||
552 | out: | 552 | out: |
553 | spin_unlock_irq(&lo->lo_lock); | 553 | spin_unlock_irq(&lo->lo_lock); |
554 | bio_io_error(old_bio, old_bio->bi_size); | 554 | bio_io_error(old_bio); |
555 | return 0; | 555 | return 0; |
556 | } | 556 | } |
557 | 557 | ||
@@ -580,7 +580,7 @@ static inline void loop_handle_bio(struct loop_device *lo, struct bio *bio) | |||
580 | bio_put(bio); | 580 | bio_put(bio); |
581 | } else { | 581 | } else { |
582 | int ret = do_bio_filebacked(lo, bio); | 582 | int ret = do_bio_filebacked(lo, bio); |
583 | bio_endio(bio, bio->bi_size, ret); | 583 | bio_endio(bio, ret); |
584 | } | 584 | } |
585 | } | 585 | } |
586 | 586 | ||
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index fadbfd880bab..540bf3676985 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c | |||
@@ -1058,15 +1058,12 @@ static void pkt_make_local_copy(struct packet_data *pkt, struct bio_vec *bvec) | |||
1058 | } | 1058 | } |
1059 | } | 1059 | } |
1060 | 1060 | ||
1061 | static int pkt_end_io_read(struct bio *bio, unsigned int bytes_done, int err) | 1061 | static void pkt_end_io_read(struct bio *bio, int err) |
1062 | { | 1062 | { |
1063 | struct packet_data *pkt = bio->bi_private; | 1063 | struct packet_data *pkt = bio->bi_private; |
1064 | struct pktcdvd_device *pd = pkt->pd; | 1064 | struct pktcdvd_device *pd = pkt->pd; |
1065 | BUG_ON(!pd); | 1065 | BUG_ON(!pd); |
1066 | 1066 | ||
1067 | if (bio->bi_size) | ||
1068 | return 1; | ||
1069 | |||
1070 | VPRINTK("pkt_end_io_read: bio=%p sec0=%llx sec=%llx err=%d\n", bio, | 1067 | VPRINTK("pkt_end_io_read: bio=%p sec0=%llx sec=%llx err=%d\n", bio, |
1071 | (unsigned long long)pkt->sector, (unsigned long long)bio->bi_sector, err); | 1068 | (unsigned long long)pkt->sector, (unsigned long long)bio->bi_sector, err); |
1072 | 1069 | ||
@@ -1077,19 +1074,14 @@ static int pkt_end_io_read(struct bio *bio, unsigned int bytes_done, int err) | |||
1077 | wake_up(&pd->wqueue); | 1074 | wake_up(&pd->wqueue); |
1078 | } | 1075 | } |
1079 | pkt_bio_finished(pd); | 1076 | pkt_bio_finished(pd); |
1080 | |||
1081 | return 0; | ||
1082 | } | 1077 | } |
1083 | 1078 | ||
1084 | static int pkt_end_io_packet_write(struct bio *bio, unsigned int bytes_done, int err) | 1079 | static void pkt_end_io_packet_write(struct bio *bio, int err) |
1085 | { | 1080 | { |
1086 | struct packet_data *pkt = bio->bi_private; | 1081 | struct packet_data *pkt = bio->bi_private; |
1087 | struct pktcdvd_device *pd = pkt->pd; | 1082 | struct pktcdvd_device *pd = pkt->pd; |
1088 | BUG_ON(!pd); | 1083 | BUG_ON(!pd); |
1089 | 1084 | ||
1090 | if (bio->bi_size) | ||
1091 | return 1; | ||
1092 | |||
1093 | VPRINTK("pkt_end_io_packet_write: id=%d, err=%d\n", pkt->id, err); | 1085 | VPRINTK("pkt_end_io_packet_write: id=%d, err=%d\n", pkt->id, err); |
1094 | 1086 | ||
1095 | pd->stats.pkt_ended++; | 1087 | pd->stats.pkt_ended++; |
@@ -1098,7 +1090,6 @@ static int pkt_end_io_packet_write(struct bio *bio, unsigned int bytes_done, int | |||
1098 | atomic_dec(&pkt->io_wait); | 1090 | atomic_dec(&pkt->io_wait); |
1099 | atomic_inc(&pkt->run_sm); | 1091 | atomic_inc(&pkt->run_sm); |
1100 | wake_up(&pd->wqueue); | 1092 | wake_up(&pd->wqueue); |
1101 | return 0; | ||
1102 | } | 1093 | } |
1103 | 1094 | ||
1104 | /* | 1095 | /* |
@@ -1470,7 +1461,7 @@ static void pkt_finish_packet(struct packet_data *pkt, int uptodate) | |||
1470 | while (bio) { | 1461 | while (bio) { |
1471 | next = bio->bi_next; | 1462 | next = bio->bi_next; |
1472 | bio->bi_next = NULL; | 1463 | bio->bi_next = NULL; |
1473 | bio_endio(bio, bio->bi_size, uptodate ? 0 : -EIO); | 1464 | bio_endio(bio, uptodate ? 0 : -EIO); |
1474 | bio = next; | 1465 | bio = next; |
1475 | } | 1466 | } |
1476 | pkt->orig_bios = pkt->orig_bios_tail = NULL; | 1467 | pkt->orig_bios = pkt->orig_bios_tail = NULL; |
@@ -2462,19 +2453,15 @@ static int pkt_close(struct inode *inode, struct file *file) | |||
2462 | } | 2453 | } |
2463 | 2454 | ||
2464 | 2455 | ||
2465 | static int pkt_end_io_read_cloned(struct bio *bio, unsigned int bytes_done, int err) | 2456 | static void pkt_end_io_read_cloned(struct bio *bio, int err) |
2466 | { | 2457 | { |
2467 | struct packet_stacked_data *psd = bio->bi_private; | 2458 | struct packet_stacked_data *psd = bio->bi_private; |
2468 | struct pktcdvd_device *pd = psd->pd; | 2459 | struct pktcdvd_device *pd = psd->pd; |
2469 | 2460 | ||
2470 | if (bio->bi_size) | ||
2471 | return 1; | ||
2472 | |||
2473 | bio_put(bio); | 2461 | bio_put(bio); |
2474 | bio_endio(psd->bio, psd->bio->bi_size, err); | 2462 | bio_endio(psd->bio, err); |
2475 | mempool_free(psd, psd_pool); | 2463 | mempool_free(psd, psd_pool); |
2476 | pkt_bio_finished(pd); | 2464 | pkt_bio_finished(pd); |
2477 | return 0; | ||
2478 | } | 2465 | } |
2479 | 2466 | ||
2480 | static int pkt_make_request(struct request_queue *q, struct bio *bio) | 2467 | static int pkt_make_request(struct request_queue *q, struct bio *bio) |
@@ -2620,7 +2607,7 @@ static int pkt_make_request(struct request_queue *q, struct bio *bio) | |||
2620 | } | 2607 | } |
2621 | return 0; | 2608 | return 0; |
2622 | end_io: | 2609 | end_io: |
2623 | bio_io_error(bio, bio->bi_size); | 2610 | bio_io_error(bio); |
2624 | return 0; | 2611 | return 0; |
2625 | } | 2612 | } |
2626 | 2613 | ||
diff --git a/drivers/block/rd.c b/drivers/block/rd.c index 65150b548f3a..701ea77f62e9 100644 --- a/drivers/block/rd.c +++ b/drivers/block/rd.c | |||
@@ -287,10 +287,10 @@ static int rd_make_request(struct request_queue *q, struct bio *bio) | |||
287 | if (ret) | 287 | if (ret) |
288 | goto fail; | 288 | goto fail; |
289 | 289 | ||
290 | bio_endio(bio, bio->bi_size, 0); | 290 | bio_endio(bio, 0); |
291 | return 0; | 291 | return 0; |
292 | fail: | 292 | fail: |
293 | bio_io_error(bio, bio->bi_size); | 293 | bio_io_error(bio); |
294 | return 0; | 294 | return 0; |
295 | } | 295 | } |
296 | 296 | ||
diff --git a/drivers/block/umem.c b/drivers/block/umem.c index c378e285d708..be7fac86725e 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c | |||
@@ -545,7 +545,7 @@ static void process_page(unsigned long data) | |||
545 | 545 | ||
546 | return_bio = bio->bi_next; | 546 | return_bio = bio->bi_next; |
547 | bio->bi_next = NULL; | 547 | bio->bi_next = NULL; |
548 | bio_endio(bio, bio->bi_size, 0); | 548 | bio_endio(bio, 0); |
549 | } | 549 | } |
550 | } | 550 | } |
551 | 551 | ||
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index bdc52d6922b7..8216a6f75be5 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c | |||
@@ -489,7 +489,7 @@ static void dec_pending(struct dm_crypt_io *io, int error) | |||
489 | if (!atomic_dec_and_test(&io->pending)) | 489 | if (!atomic_dec_and_test(&io->pending)) |
490 | return; | 490 | return; |
491 | 491 | ||
492 | bio_endio(io->base_bio, io->base_bio->bi_size, io->error); | 492 | bio_endio(io->base_bio, io->error); |
493 | 493 | ||
494 | mempool_free(io, cc->io_pool); | 494 | mempool_free(io, cc->io_pool); |
495 | } | 495 | } |
@@ -509,25 +509,19 @@ static void kcryptd_queue_io(struct dm_crypt_io *io) | |||
509 | queue_work(_kcryptd_workqueue, &io->work); | 509 | queue_work(_kcryptd_workqueue, &io->work); |
510 | } | 510 | } |
511 | 511 | ||
512 | static int crypt_endio(struct bio *clone, unsigned int done, int error) | 512 | static void crypt_endio(struct bio *clone, int error) |
513 | { | 513 | { |
514 | struct dm_crypt_io *io = clone->bi_private; | 514 | struct dm_crypt_io *io = clone->bi_private; |
515 | struct crypt_config *cc = io->target->private; | 515 | struct crypt_config *cc = io->target->private; |
516 | unsigned read_io = bio_data_dir(clone) == READ; | 516 | unsigned read_io = bio_data_dir(clone) == READ; |
517 | 517 | ||
518 | /* | 518 | /* |
519 | * free the processed pages, even if | 519 | * free the processed pages |
520 | * it's only a partially completed write | ||
521 | */ | 520 | */ |
522 | if (!read_io) | 521 | if (!read_io) { |
523 | crypt_free_buffer_pages(cc, clone, done); | 522 | crypt_free_buffer_pages(cc, clone, clone->bi_size); |
524 | |||
525 | /* keep going - not finished yet */ | ||
526 | if (unlikely(clone->bi_size)) | ||
527 | return 1; | ||
528 | |||
529 | if (!read_io) | ||
530 | goto out; | 523 | goto out; |
524 | } | ||
531 | 525 | ||
532 | if (unlikely(!bio_flagged(clone, BIO_UPTODATE))) { | 526 | if (unlikely(!bio_flagged(clone, BIO_UPTODATE))) { |
533 | error = -EIO; | 527 | error = -EIO; |
@@ -537,12 +531,11 @@ static int crypt_endio(struct bio *clone, unsigned int done, int error) | |||
537 | bio_put(clone); | 531 | bio_put(clone); |
538 | io->post_process = 1; | 532 | io->post_process = 1; |
539 | kcryptd_queue_io(io); | 533 | kcryptd_queue_io(io); |
540 | return 0; | 534 | return; |
541 | 535 | ||
542 | out: | 536 | out: |
543 | bio_put(clone); | 537 | bio_put(clone); |
544 | dec_pending(io, error); | 538 | dec_pending(io, error); |
545 | return error; | ||
546 | } | 539 | } |
547 | 540 | ||
548 | static void clone_init(struct dm_crypt_io *io, struct bio *clone) | 541 | static void clone_init(struct dm_crypt_io *io, struct bio *clone) |
diff --git a/drivers/md/dm-emc.c b/drivers/md/dm-emc.c index 71cc858b7860..a2191a4fcf77 100644 --- a/drivers/md/dm-emc.c +++ b/drivers/md/dm-emc.c | |||
@@ -38,13 +38,10 @@ static inline void free_bio(struct bio *bio) | |||
38 | bio_put(bio); | 38 | bio_put(bio); |
39 | } | 39 | } |
40 | 40 | ||
41 | static int emc_endio(struct bio *bio, unsigned int bytes_done, int error) | 41 | static void emc_endio(struct bio *bio, int error) |
42 | { | 42 | { |
43 | struct dm_path *path = bio->bi_private; | 43 | struct dm_path *path = bio->bi_private; |
44 | 44 | ||
45 | if (bio->bi_size) | ||
46 | return 1; | ||
47 | |||
48 | /* We also need to look at the sense keys here whether or not to | 45 | /* We also need to look at the sense keys here whether or not to |
49 | * switch to the next PG etc. | 46 | * switch to the next PG etc. |
50 | * | 47 | * |
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c index f3a772486437..b8e342fe7586 100644 --- a/drivers/md/dm-io.c +++ b/drivers/md/dm-io.c | |||
@@ -124,15 +124,11 @@ static void dec_count(struct io *io, unsigned int region, int error) | |||
124 | } | 124 | } |
125 | } | 125 | } |
126 | 126 | ||
127 | static int endio(struct bio *bio, unsigned int done, int error) | 127 | static void endio(struct bio *bio, int error) |
128 | { | 128 | { |
129 | struct io *io; | 129 | struct io *io; |
130 | unsigned region; | 130 | unsigned region; |
131 | 131 | ||
132 | /* keep going until we've finished */ | ||
133 | if (bio->bi_size) | ||
134 | return 1; | ||
135 | |||
136 | if (error && bio_data_dir(bio) == READ) | 132 | if (error && bio_data_dir(bio) == READ) |
137 | zero_fill_bio(bio); | 133 | zero_fill_bio(bio); |
138 | 134 | ||
@@ -146,8 +142,6 @@ static int endio(struct bio *bio, unsigned int done, int error) | |||
146 | bio_put(bio); | 142 | bio_put(bio); |
147 | 143 | ||
148 | dec_count(io, region, error); | 144 | dec_count(io, region, error); |
149 | |||
150 | return 0; | ||
151 | } | 145 | } |
152 | 146 | ||
153 | /*----------------------------------------------------------------- | 147 | /*----------------------------------------------------------------- |
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index d6ca9d0a6fd1..31056abca89d 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c | |||
@@ -390,11 +390,11 @@ static void dispatch_queued_ios(struct multipath *m) | |||
390 | 390 | ||
391 | r = map_io(m, bio, mpio, 1); | 391 | r = map_io(m, bio, mpio, 1); |
392 | if (r < 0) | 392 | if (r < 0) |
393 | bio_endio(bio, bio->bi_size, r); | 393 | bio_endio(bio, r); |
394 | else if (r == DM_MAPIO_REMAPPED) | 394 | else if (r == DM_MAPIO_REMAPPED) |
395 | generic_make_request(bio); | 395 | generic_make_request(bio); |
396 | else if (r == DM_MAPIO_REQUEUE) | 396 | else if (r == DM_MAPIO_REQUEUE) |
397 | bio_endio(bio, bio->bi_size, -EIO); | 397 | bio_endio(bio, -EIO); |
398 | 398 | ||
399 | bio = next; | 399 | bio = next; |
400 | } | 400 | } |
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c index 144071e70a93..d09ff15490a5 100644 --- a/drivers/md/dm-raid1.c +++ b/drivers/md/dm-raid1.c | |||
@@ -820,7 +820,7 @@ static void write_callback(unsigned long error, void *context) | |||
820 | break; | 820 | break; |
821 | } | 821 | } |
822 | } | 822 | } |
823 | bio_endio(bio, bio->bi_size, 0); | 823 | bio_endio(bio, 0); |
824 | } | 824 | } |
825 | 825 | ||
826 | static void do_write(struct mirror_set *ms, struct bio *bio) | 826 | static void do_write(struct mirror_set *ms, struct bio *bio) |
@@ -900,7 +900,7 @@ static void do_writes(struct mirror_set *ms, struct bio_list *writes) | |||
900 | */ | 900 | */ |
901 | if (unlikely(ms->log_failure)) | 901 | if (unlikely(ms->log_failure)) |
902 | while ((bio = bio_list_pop(&sync))) | 902 | while ((bio = bio_list_pop(&sync))) |
903 | bio_endio(bio, bio->bi_size, -EIO); | 903 | bio_endio(bio, -EIO); |
904 | else while ((bio = bio_list_pop(&sync))) | 904 | else while ((bio = bio_list_pop(&sync))) |
905 | do_write(ms, bio); | 905 | do_write(ms, bio); |
906 | 906 | ||
diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 83ddbfe6b8a4..98a633f3d6b0 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c | |||
@@ -636,7 +636,7 @@ static void error_bios(struct bio *bio) | |||
636 | while (bio) { | 636 | while (bio) { |
637 | n = bio->bi_next; | 637 | n = bio->bi_next; |
638 | bio->bi_next = NULL; | 638 | bio->bi_next = NULL; |
639 | bio_io_error(bio, bio->bi_size); | 639 | bio_io_error(bio); |
640 | bio = n; | 640 | bio = n; |
641 | } | 641 | } |
642 | } | 642 | } |
diff --git a/drivers/md/dm-zero.c b/drivers/md/dm-zero.c index f314d7dc9c26..bdec206c404b 100644 --- a/drivers/md/dm-zero.c +++ b/drivers/md/dm-zero.c | |||
@@ -43,7 +43,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio, | |||
43 | break; | 43 | break; |
44 | } | 44 | } |
45 | 45 | ||
46 | bio_endio(bio, bio->bi_size, 0); | 46 | bio_endio(bio, 0); |
47 | 47 | ||
48 | /* accepted bio, don't make new request */ | 48 | /* accepted bio, don't make new request */ |
49 | return DM_MAPIO_SUBMITTED; | 49 | return DM_MAPIO_SUBMITTED; |
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 2120155929a6..167765c47747 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c | |||
@@ -484,23 +484,20 @@ static void dec_pending(struct dm_io *io, int error) | |||
484 | blk_add_trace_bio(io->md->queue, io->bio, | 484 | blk_add_trace_bio(io->md->queue, io->bio, |
485 | BLK_TA_COMPLETE); | 485 | BLK_TA_COMPLETE); |
486 | 486 | ||
487 | bio_endio(io->bio, io->bio->bi_size, io->error); | 487 | bio_endio(io->bio, io->error); |
488 | } | 488 | } |
489 | 489 | ||
490 | free_io(io->md, io); | 490 | free_io(io->md, io); |
491 | } | 491 | } |
492 | } | 492 | } |
493 | 493 | ||
494 | static int clone_endio(struct bio *bio, unsigned int done, int error) | 494 | static void clone_endio(struct bio *bio, int error) |
495 | { | 495 | { |
496 | int r = 0; | 496 | int r = 0; |
497 | struct dm_target_io *tio = bio->bi_private; | 497 | struct dm_target_io *tio = bio->bi_private; |
498 | struct mapped_device *md = tio->io->md; | 498 | struct mapped_device *md = tio->io->md; |
499 | dm_endio_fn endio = tio->ti->type->end_io; | 499 | dm_endio_fn endio = tio->ti->type->end_io; |
500 | 500 | ||
501 | if (bio->bi_size) | ||
502 | return 1; | ||
503 | |||
504 | if (!bio_flagged(bio, BIO_UPTODATE) && !error) | 501 | if (!bio_flagged(bio, BIO_UPTODATE) && !error) |
505 | error = -EIO; | 502 | error = -EIO; |
506 | 503 | ||
@@ -514,7 +511,7 @@ static int clone_endio(struct bio *bio, unsigned int done, int error) | |||
514 | error = r; | 511 | error = r; |
515 | else if (r == DM_ENDIO_INCOMPLETE) | 512 | else if (r == DM_ENDIO_INCOMPLETE) |
516 | /* The target will handle the io */ | 513 | /* The target will handle the io */ |
517 | return 1; | 514 | return; |
518 | else if (r) { | 515 | else if (r) { |
519 | DMWARN("unimplemented target endio return value: %d", r); | 516 | DMWARN("unimplemented target endio return value: %d", r); |
520 | BUG(); | 517 | BUG(); |
@@ -530,7 +527,6 @@ static int clone_endio(struct bio *bio, unsigned int done, int error) | |||
530 | 527 | ||
531 | bio_put(bio); | 528 | bio_put(bio); |
532 | free_tio(md, tio); | 529 | free_tio(md, tio); |
533 | return r; | ||
534 | } | 530 | } |
535 | 531 | ||
536 | static sector_t max_io_len(struct mapped_device *md, | 532 | static sector_t max_io_len(struct mapped_device *md, |
@@ -761,7 +757,7 @@ static void __split_bio(struct mapped_device *md, struct bio *bio) | |||
761 | 757 | ||
762 | ci.map = dm_get_table(md); | 758 | ci.map = dm_get_table(md); |
763 | if (!ci.map) { | 759 | if (!ci.map) { |
764 | bio_io_error(bio, bio->bi_size); | 760 | bio_io_error(bio); |
765 | return; | 761 | return; |
766 | } | 762 | } |
767 | 763 | ||
@@ -803,7 +799,7 @@ static int dm_request(struct request_queue *q, struct bio *bio) | |||
803 | * guarantee it is (or can be) handled by the targets correctly. | 799 | * guarantee it is (or can be) handled by the targets correctly. |
804 | */ | 800 | */ |
805 | if (unlikely(bio_barrier(bio))) { | 801 | if (unlikely(bio_barrier(bio))) { |
806 | bio_endio(bio, bio->bi_size, -EOPNOTSUPP); | 802 | bio_endio(bio, -EOPNOTSUPP); |
807 | return 0; | 803 | return 0; |
808 | } | 804 | } |
809 | 805 | ||
@@ -820,13 +816,13 @@ static int dm_request(struct request_queue *q, struct bio *bio) | |||
820 | up_read(&md->io_lock); | 816 | up_read(&md->io_lock); |
821 | 817 | ||
822 | if (bio_rw(bio) == READA) { | 818 | if (bio_rw(bio) == READA) { |
823 | bio_io_error(bio, bio->bi_size); | 819 | bio_io_error(bio); |
824 | return 0; | 820 | return 0; |
825 | } | 821 | } |
826 | 822 | ||
827 | r = queue_io(md, bio); | 823 | r = queue_io(md, bio); |
828 | if (r < 0) { | 824 | if (r < 0) { |
829 | bio_io_error(bio, bio->bi_size); | 825 | bio_io_error(bio); |
830 | return 0; | 826 | return 0; |
831 | 827 | ||
832 | } else if (r == 0) | 828 | } else if (r == 0) |
diff --git a/drivers/md/faulty.c b/drivers/md/faulty.c index cb059cf14c2e..cf2ddce34118 100644 --- a/drivers/md/faulty.c +++ b/drivers/md/faulty.c | |||
@@ -65,18 +65,16 @@ | |||
65 | #include <linux/raid/md.h> | 65 | #include <linux/raid/md.h> |
66 | 66 | ||
67 | 67 | ||
68 | static int faulty_fail(struct bio *bio, unsigned int bytes_done, int error) | 68 | static void faulty_fail(struct bio *bio, int error) |
69 | { | 69 | { |
70 | struct bio *b = bio->bi_private; | 70 | struct bio *b = bio->bi_private; |
71 | 71 | ||
72 | b->bi_size = bio->bi_size; | 72 | b->bi_size = bio->bi_size; |
73 | b->bi_sector = bio->bi_sector; | 73 | b->bi_sector = bio->bi_sector; |
74 | 74 | ||
75 | if (bio->bi_size == 0) | 75 | bio_put(bio); |
76 | bio_put(bio); | ||
77 | 76 | ||
78 | clear_bit(BIO_UPTODATE, &b->bi_flags); | 77 | bio_io_error(b); |
79 | return (b->bi_end_io)(b, bytes_done, -EIO); | ||
80 | } | 78 | } |
81 | 79 | ||
82 | typedef struct faulty_conf { | 80 | typedef struct faulty_conf { |
@@ -179,7 +177,7 @@ static int make_request(struct request_queue *q, struct bio *bio) | |||
179 | /* special case - don't decrement, don't generic_make_request, | 177 | /* special case - don't decrement, don't generic_make_request, |
180 | * just fail immediately | 178 | * just fail immediately |
181 | */ | 179 | */ |
182 | bio_endio(bio, bio->bi_size, -EIO); | 180 | bio_endio(bio, -EIO); |
183 | return 0; | 181 | return 0; |
184 | } | 182 | } |
185 | 183 | ||
diff --git a/drivers/md/linear.c b/drivers/md/linear.c index 17f795c3e0ab..550148770bb2 100644 --- a/drivers/md/linear.c +++ b/drivers/md/linear.c | |||
@@ -338,7 +338,7 @@ static int linear_make_request (struct request_queue *q, struct bio *bio) | |||
338 | sector_t block; | 338 | sector_t block; |
339 | 339 | ||
340 | if (unlikely(bio_barrier(bio))) { | 340 | if (unlikely(bio_barrier(bio))) { |
341 | bio_endio(bio, bio->bi_size, -EOPNOTSUPP); | 341 | bio_endio(bio, -EOPNOTSUPP); |
342 | return 0; | 342 | return 0; |
343 | } | 343 | } |
344 | 344 | ||
@@ -358,7 +358,7 @@ static int linear_make_request (struct request_queue *q, struct bio *bio) | |||
358 | bdevname(tmp_dev->rdev->bdev, b), | 358 | bdevname(tmp_dev->rdev->bdev, b), |
359 | (unsigned long long)tmp_dev->size, | 359 | (unsigned long long)tmp_dev->size, |
360 | (unsigned long long)tmp_dev->offset); | 360 | (unsigned long long)tmp_dev->offset); |
361 | bio_io_error(bio, bio->bi_size); | 361 | bio_io_error(bio); |
362 | return 0; | 362 | return 0; |
363 | } | 363 | } |
364 | if (unlikely(bio->bi_sector + (bio->bi_size >> 9) > | 364 | if (unlikely(bio->bi_sector + (bio->bi_size >> 9) > |
diff --git a/drivers/md/md.c b/drivers/md/md.c index f883b7e37f3d..e8f102ea9b03 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c | |||
@@ -213,7 +213,7 @@ static DEFINE_SPINLOCK(all_mddevs_lock); | |||
213 | 213 | ||
214 | static int md_fail_request (struct request_queue *q, struct bio *bio) | 214 | static int md_fail_request (struct request_queue *q, struct bio *bio) |
215 | { | 215 | { |
216 | bio_io_error(bio, bio->bi_size); | 216 | bio_io_error(bio); |
217 | return 0; | 217 | return 0; |
218 | } | 218 | } |
219 | 219 | ||
@@ -384,12 +384,10 @@ static void free_disk_sb(mdk_rdev_t * rdev) | |||
384 | } | 384 | } |
385 | 385 | ||
386 | 386 | ||
387 | static int super_written(struct bio *bio, unsigned int bytes_done, int error) | 387 | static void super_written(struct bio *bio, int error) |
388 | { | 388 | { |
389 | mdk_rdev_t *rdev = bio->bi_private; | 389 | mdk_rdev_t *rdev = bio->bi_private; |
390 | mddev_t *mddev = rdev->mddev; | 390 | mddev_t *mddev = rdev->mddev; |
391 | if (bio->bi_size) | ||
392 | return 1; | ||
393 | 391 | ||
394 | if (error || !test_bit(BIO_UPTODATE, &bio->bi_flags)) { | 392 | if (error || !test_bit(BIO_UPTODATE, &bio->bi_flags)) { |
395 | printk("md: super_written gets error=%d, uptodate=%d\n", | 393 | printk("md: super_written gets error=%d, uptodate=%d\n", |
@@ -401,16 +399,13 @@ static int super_written(struct bio *bio, unsigned int bytes_done, int error) | |||
401 | if (atomic_dec_and_test(&mddev->pending_writes)) | 399 | if (atomic_dec_and_test(&mddev->pending_writes)) |
402 | wake_up(&mddev->sb_wait); | 400 | wake_up(&mddev->sb_wait); |
403 | bio_put(bio); | 401 | bio_put(bio); |
404 | return 0; | ||
405 | } | 402 | } |
406 | 403 | ||
407 | static int super_written_barrier(struct bio *bio, unsigned int bytes_done, int error) | 404 | static void super_written_barrier(struct bio *bio, int error) |
408 | { | 405 | { |
409 | struct bio *bio2 = bio->bi_private; | 406 | struct bio *bio2 = bio->bi_private; |
410 | mdk_rdev_t *rdev = bio2->bi_private; | 407 | mdk_rdev_t *rdev = bio2->bi_private; |
411 | mddev_t *mddev = rdev->mddev; | 408 | mddev_t *mddev = rdev->mddev; |
412 | if (bio->bi_size) | ||
413 | return 1; | ||
414 | 409 | ||
415 | if (!test_bit(BIO_UPTODATE, &bio->bi_flags) && | 410 | if (!test_bit(BIO_UPTODATE, &bio->bi_flags) && |
416 | error == -EOPNOTSUPP) { | 411 | error == -EOPNOTSUPP) { |
@@ -424,11 +419,11 @@ static int super_written_barrier(struct bio *bio, unsigned int bytes_done, int e | |||
424 | spin_unlock_irqrestore(&mddev->write_lock, flags); | 419 | spin_unlock_irqrestore(&mddev->write_lock, flags); |
425 | wake_up(&mddev->sb_wait); | 420 | wake_up(&mddev->sb_wait); |
426 | bio_put(bio); | 421 | bio_put(bio); |
427 | return 0; | 422 | } else { |
423 | bio_put(bio2); | ||
424 | bio->bi_private = rdev; | ||
425 | super_written(bio, error); | ||
428 | } | 426 | } |
429 | bio_put(bio2); | ||
430 | bio->bi_private = rdev; | ||
431 | return super_written(bio, bytes_done, error); | ||
432 | } | 427 | } |
433 | 428 | ||
434 | void md_super_write(mddev_t *mddev, mdk_rdev_t *rdev, | 429 | void md_super_write(mddev_t *mddev, mdk_rdev_t *rdev, |
@@ -489,13 +484,9 @@ void md_super_wait(mddev_t *mddev) | |||
489 | finish_wait(&mddev->sb_wait, &wq); | 484 | finish_wait(&mddev->sb_wait, &wq); |
490 | } | 485 | } |
491 | 486 | ||
492 | static int bi_complete(struct bio *bio, unsigned int bytes_done, int error) | 487 | static void bi_complete(struct bio *bio, int error) |
493 | { | 488 | { |
494 | if (bio->bi_size) | ||
495 | return 1; | ||
496 | |||
497 | complete((struct completion*)bio->bi_private); | 489 | complete((struct completion*)bio->bi_private); |
498 | return 0; | ||
499 | } | 490 | } |
500 | 491 | ||
501 | int sync_page_io(struct block_device *bdev, sector_t sector, int size, | 492 | int sync_page_io(struct block_device *bdev, sector_t sector, int size, |
diff --git a/drivers/md/multipath.c b/drivers/md/multipath.c index 1e2af43a73b9..f2a63f394ad9 100644 --- a/drivers/md/multipath.c +++ b/drivers/md/multipath.c | |||
@@ -82,21 +82,17 @@ static void multipath_end_bh_io (struct multipath_bh *mp_bh, int err) | |||
82 | struct bio *bio = mp_bh->master_bio; | 82 | struct bio *bio = mp_bh->master_bio; |
83 | multipath_conf_t *conf = mddev_to_conf(mp_bh->mddev); | 83 | multipath_conf_t *conf = mddev_to_conf(mp_bh->mddev); |
84 | 84 | ||
85 | bio_endio(bio, bio->bi_size, err); | 85 | bio_endio(bio, err); |
86 | mempool_free(mp_bh, conf->pool); | 86 | mempool_free(mp_bh, conf->pool); |
87 | } | 87 | } |
88 | 88 | ||
89 | static int multipath_end_request(struct bio *bio, unsigned int bytes_done, | 89 | static void multipath_end_request(struct bio *bio, int error) |
90 | int error) | ||
91 | { | 90 | { |
92 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 91 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
93 | struct multipath_bh * mp_bh = (struct multipath_bh *)(bio->bi_private); | 92 | struct multipath_bh * mp_bh = (struct multipath_bh *)(bio->bi_private); |
94 | multipath_conf_t *conf = mddev_to_conf(mp_bh->mddev); | 93 | multipath_conf_t *conf = mddev_to_conf(mp_bh->mddev); |
95 | mdk_rdev_t *rdev = conf->multipaths[mp_bh->path].rdev; | 94 | mdk_rdev_t *rdev = conf->multipaths[mp_bh->path].rdev; |
96 | 95 | ||
97 | if (bio->bi_size) | ||
98 | return 1; | ||
99 | |||
100 | if (uptodate) | 96 | if (uptodate) |
101 | multipath_end_bh_io(mp_bh, 0); | 97 | multipath_end_bh_io(mp_bh, 0); |
102 | else if (!bio_rw_ahead(bio)) { | 98 | else if (!bio_rw_ahead(bio)) { |
@@ -112,7 +108,6 @@ static int multipath_end_request(struct bio *bio, unsigned int bytes_done, | |||
112 | } else | 108 | } else |
113 | multipath_end_bh_io(mp_bh, error); | 109 | multipath_end_bh_io(mp_bh, error); |
114 | rdev_dec_pending(rdev, conf->mddev); | 110 | rdev_dec_pending(rdev, conf->mddev); |
115 | return 0; | ||
116 | } | 111 | } |
117 | 112 | ||
118 | static void unplug_slaves(mddev_t *mddev) | 113 | static void unplug_slaves(mddev_t *mddev) |
@@ -155,7 +150,7 @@ static int multipath_make_request (struct request_queue *q, struct bio * bio) | |||
155 | const int rw = bio_data_dir(bio); | 150 | const int rw = bio_data_dir(bio); |
156 | 151 | ||
157 | if (unlikely(bio_barrier(bio))) { | 152 | if (unlikely(bio_barrier(bio))) { |
158 | bio_endio(bio, bio->bi_size, -EOPNOTSUPP); | 153 | bio_endio(bio, -EOPNOTSUPP); |
159 | return 0; | 154 | return 0; |
160 | } | 155 | } |
161 | 156 | ||
@@ -169,7 +164,7 @@ static int multipath_make_request (struct request_queue *q, struct bio * bio) | |||
169 | 164 | ||
170 | mp_bh->path = multipath_map(conf); | 165 | mp_bh->path = multipath_map(conf); |
171 | if (mp_bh->path < 0) { | 166 | if (mp_bh->path < 0) { |
172 | bio_endio(bio, bio->bi_size, -EIO); | 167 | bio_endio(bio, -EIO); |
173 | mempool_free(mp_bh, conf->pool); | 168 | mempool_free(mp_bh, conf->pool); |
174 | return 0; | 169 | return 0; |
175 | } | 170 | } |
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c index b8216bc6db45..ef0da2d84959 100644 --- a/drivers/md/raid0.c +++ b/drivers/md/raid0.c | |||
@@ -420,7 +420,7 @@ static int raid0_make_request (struct request_queue *q, struct bio *bio) | |||
420 | const int rw = bio_data_dir(bio); | 420 | const int rw = bio_data_dir(bio); |
421 | 421 | ||
422 | if (unlikely(bio_barrier(bio))) { | 422 | if (unlikely(bio_barrier(bio))) { |
423 | bio_endio(bio, bio->bi_size, -EOPNOTSUPP); | 423 | bio_endio(bio, -EOPNOTSUPP); |
424 | return 0; | 424 | return 0; |
425 | } | 425 | } |
426 | 426 | ||
@@ -490,7 +490,7 @@ bad_map: | |||
490 | " or bigger than %dk %llu %d\n", chunk_size, | 490 | " or bigger than %dk %llu %d\n", chunk_size, |
491 | (unsigned long long)bio->bi_sector, bio->bi_size >> 10); | 491 | (unsigned long long)bio->bi_sector, bio->bi_size >> 10); |
492 | 492 | ||
493 | bio_io_error(bio, bio->bi_size); | 493 | bio_io_error(bio); |
494 | return 0; | 494 | return 0; |
495 | } | 495 | } |
496 | 496 | ||
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index f33a729960ca..6d03bea6fa58 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c | |||
@@ -238,7 +238,7 @@ static void raid_end_bio_io(r1bio_t *r1_bio) | |||
238 | (unsigned long long) bio->bi_sector + | 238 | (unsigned long long) bio->bi_sector + |
239 | (bio->bi_size >> 9) - 1); | 239 | (bio->bi_size >> 9) - 1); |
240 | 240 | ||
241 | bio_endio(bio, bio->bi_size, | 241 | bio_endio(bio, |
242 | test_bit(R1BIO_Uptodate, &r1_bio->state) ? 0 : -EIO); | 242 | test_bit(R1BIO_Uptodate, &r1_bio->state) ? 0 : -EIO); |
243 | } | 243 | } |
244 | free_r1bio(r1_bio); | 244 | free_r1bio(r1_bio); |
@@ -255,16 +255,13 @@ static inline void update_head_pos(int disk, r1bio_t *r1_bio) | |||
255 | r1_bio->sector + (r1_bio->sectors); | 255 | r1_bio->sector + (r1_bio->sectors); |
256 | } | 256 | } |
257 | 257 | ||
258 | static int raid1_end_read_request(struct bio *bio, unsigned int bytes_done, int error) | 258 | static void raid1_end_read_request(struct bio *bio, int error) |
259 | { | 259 | { |
260 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 260 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
261 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); | 261 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); |
262 | int mirror; | 262 | int mirror; |
263 | conf_t *conf = mddev_to_conf(r1_bio->mddev); | 263 | conf_t *conf = mddev_to_conf(r1_bio->mddev); |
264 | 264 | ||
265 | if (bio->bi_size) | ||
266 | return 1; | ||
267 | |||
268 | mirror = r1_bio->read_disk; | 265 | mirror = r1_bio->read_disk; |
269 | /* | 266 | /* |
270 | * this branch is our 'one mirror IO has finished' event handler: | 267 | * this branch is our 'one mirror IO has finished' event handler: |
@@ -301,10 +298,9 @@ static int raid1_end_read_request(struct bio *bio, unsigned int bytes_done, int | |||
301 | } | 298 | } |
302 | 299 | ||
303 | rdev_dec_pending(conf->mirrors[mirror].rdev, conf->mddev); | 300 | rdev_dec_pending(conf->mirrors[mirror].rdev, conf->mddev); |
304 | return 0; | ||
305 | } | 301 | } |
306 | 302 | ||
307 | static int raid1_end_write_request(struct bio *bio, unsigned int bytes_done, int error) | 303 | static void raid1_end_write_request(struct bio *bio, int error) |
308 | { | 304 | { |
309 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 305 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
310 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); | 306 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); |
@@ -312,8 +308,6 @@ static int raid1_end_write_request(struct bio *bio, unsigned int bytes_done, int | |||
312 | conf_t *conf = mddev_to_conf(r1_bio->mddev); | 308 | conf_t *conf = mddev_to_conf(r1_bio->mddev); |
313 | struct bio *to_put = NULL; | 309 | struct bio *to_put = NULL; |
314 | 310 | ||
315 | if (bio->bi_size) | ||
316 | return 1; | ||
317 | 311 | ||
318 | for (mirror = 0; mirror < conf->raid_disks; mirror++) | 312 | for (mirror = 0; mirror < conf->raid_disks; mirror++) |
319 | if (r1_bio->bios[mirror] == bio) | 313 | if (r1_bio->bios[mirror] == bio) |
@@ -366,7 +360,7 @@ static int raid1_end_write_request(struct bio *bio, unsigned int bytes_done, int | |||
366 | (unsigned long long) mbio->bi_sector, | 360 | (unsigned long long) mbio->bi_sector, |
367 | (unsigned long long) mbio->bi_sector + | 361 | (unsigned long long) mbio->bi_sector + |
368 | (mbio->bi_size >> 9) - 1); | 362 | (mbio->bi_size >> 9) - 1); |
369 | bio_endio(mbio, mbio->bi_size, 0); | 363 | bio_endio(mbio, 0); |
370 | } | 364 | } |
371 | } | 365 | } |
372 | } | 366 | } |
@@ -400,8 +394,6 @@ static int raid1_end_write_request(struct bio *bio, unsigned int bytes_done, int | |||
400 | 394 | ||
401 | if (to_put) | 395 | if (to_put) |
402 | bio_put(to_put); | 396 | bio_put(to_put); |
403 | |||
404 | return 0; | ||
405 | } | 397 | } |
406 | 398 | ||
407 | 399 | ||
@@ -796,7 +788,7 @@ static int make_request(struct request_queue *q, struct bio * bio) | |||
796 | if (unlikely(!mddev->barriers_work && bio_barrier(bio))) { | 788 | if (unlikely(!mddev->barriers_work && bio_barrier(bio))) { |
797 | if (rw == WRITE) | 789 | if (rw == WRITE) |
798 | md_write_end(mddev); | 790 | md_write_end(mddev); |
799 | bio_endio(bio, bio->bi_size, -EOPNOTSUPP); | 791 | bio_endio(bio, -EOPNOTSUPP); |
800 | return 0; | 792 | return 0; |
801 | } | 793 | } |
802 | 794 | ||
@@ -1137,14 +1129,11 @@ abort: | |||
1137 | } | 1129 | } |
1138 | 1130 | ||
1139 | 1131 | ||
1140 | static int end_sync_read(struct bio *bio, unsigned int bytes_done, int error) | 1132 | static void end_sync_read(struct bio *bio, int error) |
1141 | { | 1133 | { |
1142 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); | 1134 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); |
1143 | int i; | 1135 | int i; |
1144 | 1136 | ||
1145 | if (bio->bi_size) | ||
1146 | return 1; | ||
1147 | |||
1148 | for (i=r1_bio->mddev->raid_disks; i--; ) | 1137 | for (i=r1_bio->mddev->raid_disks; i--; ) |
1149 | if (r1_bio->bios[i] == bio) | 1138 | if (r1_bio->bios[i] == bio) |
1150 | break; | 1139 | break; |
@@ -1160,10 +1149,9 @@ static int end_sync_read(struct bio *bio, unsigned int bytes_done, int error) | |||
1160 | 1149 | ||
1161 | if (atomic_dec_and_test(&r1_bio->remaining)) | 1150 | if (atomic_dec_and_test(&r1_bio->remaining)) |
1162 | reschedule_retry(r1_bio); | 1151 | reschedule_retry(r1_bio); |
1163 | return 0; | ||
1164 | } | 1152 | } |
1165 | 1153 | ||
1166 | static int end_sync_write(struct bio *bio, unsigned int bytes_done, int error) | 1154 | static void end_sync_write(struct bio *bio, int error) |
1167 | { | 1155 | { |
1168 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 1156 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
1169 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); | 1157 | r1bio_t * r1_bio = (r1bio_t *)(bio->bi_private); |
@@ -1172,9 +1160,6 @@ static int end_sync_write(struct bio *bio, unsigned int bytes_done, int error) | |||
1172 | int i; | 1160 | int i; |
1173 | int mirror=0; | 1161 | int mirror=0; |
1174 | 1162 | ||
1175 | if (bio->bi_size) | ||
1176 | return 1; | ||
1177 | |||
1178 | for (i = 0; i < conf->raid_disks; i++) | 1163 | for (i = 0; i < conf->raid_disks; i++) |
1179 | if (r1_bio->bios[i] == bio) { | 1164 | if (r1_bio->bios[i] == bio) { |
1180 | mirror = i; | 1165 | mirror = i; |
@@ -1200,7 +1185,6 @@ static int end_sync_write(struct bio *bio, unsigned int bytes_done, int error) | |||
1200 | md_done_sync(mddev, r1_bio->sectors, uptodate); | 1185 | md_done_sync(mddev, r1_bio->sectors, uptodate); |
1201 | put_buf(r1_bio); | 1186 | put_buf(r1_bio); |
1202 | } | 1187 | } |
1203 | return 0; | ||
1204 | } | 1188 | } |
1205 | 1189 | ||
1206 | static void sync_request_write(mddev_t *mddev, r1bio_t *r1_bio) | 1190 | static void sync_request_write(mddev_t *mddev, r1bio_t *r1_bio) |
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 4e53792aa520..25a96c42bdb0 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c | |||
@@ -227,7 +227,7 @@ static void raid_end_bio_io(r10bio_t *r10_bio) | |||
227 | { | 227 | { |
228 | struct bio *bio = r10_bio->master_bio; | 228 | struct bio *bio = r10_bio->master_bio; |
229 | 229 | ||
230 | bio_endio(bio, bio->bi_size, | 230 | bio_endio(bio, |
231 | test_bit(R10BIO_Uptodate, &r10_bio->state) ? 0 : -EIO); | 231 | test_bit(R10BIO_Uptodate, &r10_bio->state) ? 0 : -EIO); |
232 | free_r10bio(r10_bio); | 232 | free_r10bio(r10_bio); |
233 | } | 233 | } |
@@ -243,15 +243,13 @@ static inline void update_head_pos(int slot, r10bio_t *r10_bio) | |||
243 | r10_bio->devs[slot].addr + (r10_bio->sectors); | 243 | r10_bio->devs[slot].addr + (r10_bio->sectors); |
244 | } | 244 | } |
245 | 245 | ||
246 | static int raid10_end_read_request(struct bio *bio, unsigned int bytes_done, int error) | 246 | static void raid10_end_read_request(struct bio *bio, int error) |
247 | { | 247 | { |
248 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 248 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
249 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); | 249 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); |
250 | int slot, dev; | 250 | int slot, dev; |
251 | conf_t *conf = mddev_to_conf(r10_bio->mddev); | 251 | conf_t *conf = mddev_to_conf(r10_bio->mddev); |
252 | 252 | ||
253 | if (bio->bi_size) | ||
254 | return 1; | ||
255 | 253 | ||
256 | slot = r10_bio->read_slot; | 254 | slot = r10_bio->read_slot; |
257 | dev = r10_bio->devs[slot].devnum; | 255 | dev = r10_bio->devs[slot].devnum; |
@@ -284,19 +282,15 @@ static int raid10_end_read_request(struct bio *bio, unsigned int bytes_done, int | |||
284 | } | 282 | } |
285 | 283 | ||
286 | rdev_dec_pending(conf->mirrors[dev].rdev, conf->mddev); | 284 | rdev_dec_pending(conf->mirrors[dev].rdev, conf->mddev); |
287 | return 0; | ||
288 | } | 285 | } |
289 | 286 | ||
290 | static int raid10_end_write_request(struct bio *bio, unsigned int bytes_done, int error) | 287 | static void raid10_end_write_request(struct bio *bio, int error) |
291 | { | 288 | { |
292 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 289 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
293 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); | 290 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); |
294 | int slot, dev; | 291 | int slot, dev; |
295 | conf_t *conf = mddev_to_conf(r10_bio->mddev); | 292 | conf_t *conf = mddev_to_conf(r10_bio->mddev); |
296 | 293 | ||
297 | if (bio->bi_size) | ||
298 | return 1; | ||
299 | |||
300 | for (slot = 0; slot < conf->copies; slot++) | 294 | for (slot = 0; slot < conf->copies; slot++) |
301 | if (r10_bio->devs[slot].bio == bio) | 295 | if (r10_bio->devs[slot].bio == bio) |
302 | break; | 296 | break; |
@@ -339,7 +333,6 @@ static int raid10_end_write_request(struct bio *bio, unsigned int bytes_done, in | |||
339 | } | 333 | } |
340 | 334 | ||
341 | rdev_dec_pending(conf->mirrors[dev].rdev, conf->mddev); | 335 | rdev_dec_pending(conf->mirrors[dev].rdev, conf->mddev); |
342 | return 0; | ||
343 | } | 336 | } |
344 | 337 | ||
345 | 338 | ||
@@ -787,7 +780,7 @@ static int make_request(struct request_queue *q, struct bio * bio) | |||
787 | unsigned long flags; | 780 | unsigned long flags; |
788 | 781 | ||
789 | if (unlikely(bio_barrier(bio))) { | 782 | if (unlikely(bio_barrier(bio))) { |
790 | bio_endio(bio, bio->bi_size, -EOPNOTSUPP); | 783 | bio_endio(bio, -EOPNOTSUPP); |
791 | return 0; | 784 | return 0; |
792 | } | 785 | } |
793 | 786 | ||
@@ -819,7 +812,7 @@ static int make_request(struct request_queue *q, struct bio * bio) | |||
819 | " or bigger than %dk %llu %d\n", chunk_sects/2, | 812 | " or bigger than %dk %llu %d\n", chunk_sects/2, |
820 | (unsigned long long)bio->bi_sector, bio->bi_size >> 10); | 813 | (unsigned long long)bio->bi_sector, bio->bi_size >> 10); |
821 | 814 | ||
822 | bio_io_error(bio, bio->bi_size); | 815 | bio_io_error(bio); |
823 | return 0; | 816 | return 0; |
824 | } | 817 | } |
825 | 818 | ||
@@ -1155,15 +1148,12 @@ abort: | |||
1155 | } | 1148 | } |
1156 | 1149 | ||
1157 | 1150 | ||
1158 | static int end_sync_read(struct bio *bio, unsigned int bytes_done, int error) | 1151 | static void end_sync_read(struct bio *bio, int error) |
1159 | { | 1152 | { |
1160 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); | 1153 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); |
1161 | conf_t *conf = mddev_to_conf(r10_bio->mddev); | 1154 | conf_t *conf = mddev_to_conf(r10_bio->mddev); |
1162 | int i,d; | 1155 | int i,d; |
1163 | 1156 | ||
1164 | if (bio->bi_size) | ||
1165 | return 1; | ||
1166 | |||
1167 | for (i=0; i<conf->copies; i++) | 1157 | for (i=0; i<conf->copies; i++) |
1168 | if (r10_bio->devs[i].bio == bio) | 1158 | if (r10_bio->devs[i].bio == bio) |
1169 | break; | 1159 | break; |
@@ -1192,10 +1182,9 @@ static int end_sync_read(struct bio *bio, unsigned int bytes_done, int error) | |||
1192 | reschedule_retry(r10_bio); | 1182 | reschedule_retry(r10_bio); |
1193 | } | 1183 | } |
1194 | rdev_dec_pending(conf->mirrors[d].rdev, conf->mddev); | 1184 | rdev_dec_pending(conf->mirrors[d].rdev, conf->mddev); |
1195 | return 0; | ||
1196 | } | 1185 | } |
1197 | 1186 | ||
1198 | static int end_sync_write(struct bio *bio, unsigned int bytes_done, int error) | 1187 | static void end_sync_write(struct bio *bio, int error) |
1199 | { | 1188 | { |
1200 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 1189 | int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
1201 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); | 1190 | r10bio_t * r10_bio = (r10bio_t *)(bio->bi_private); |
@@ -1203,9 +1192,6 @@ static int end_sync_write(struct bio *bio, unsigned int bytes_done, int error) | |||
1203 | conf_t *conf = mddev_to_conf(mddev); | 1192 | conf_t *conf = mddev_to_conf(mddev); |
1204 | int i,d; | 1193 | int i,d; |
1205 | 1194 | ||
1206 | if (bio->bi_size) | ||
1207 | return 1; | ||
1208 | |||
1209 | for (i = 0; i < conf->copies; i++) | 1195 | for (i = 0; i < conf->copies; i++) |
1210 | if (r10_bio->devs[i].bio == bio) | 1196 | if (r10_bio->devs[i].bio == bio) |
1211 | break; | 1197 | break; |
@@ -1228,7 +1214,6 @@ static int end_sync_write(struct bio *bio, unsigned int bytes_done, int error) | |||
1228 | } | 1214 | } |
1229 | } | 1215 | } |
1230 | rdev_dec_pending(conf->mirrors[d].rdev, mddev); | 1216 | rdev_dec_pending(conf->mirrors[d].rdev, mddev); |
1231 | return 0; | ||
1232 | } | 1217 | } |
1233 | 1218 | ||
1234 | /* | 1219 | /* |
@@ -1374,7 +1359,7 @@ static void recovery_request_write(mddev_t *mddev, r10bio_t *r10_bio) | |||
1374 | if (test_bit(R10BIO_Uptodate, &r10_bio->state)) | 1359 | if (test_bit(R10BIO_Uptodate, &r10_bio->state)) |
1375 | generic_make_request(wbio); | 1360 | generic_make_request(wbio); |
1376 | else | 1361 | else |
1377 | bio_endio(wbio, wbio->bi_size, -EIO); | 1362 | bio_endio(wbio, -EIO); |
1378 | } | 1363 | } |
1379 | 1364 | ||
1380 | 1365 | ||
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index f96dea975fa5..caaca9e178bc 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
@@ -108,12 +108,11 @@ static void return_io(struct bio *return_bi) | |||
108 | { | 108 | { |
109 | struct bio *bi = return_bi; | 109 | struct bio *bi = return_bi; |
110 | while (bi) { | 110 | while (bi) { |
111 | int bytes = bi->bi_size; | ||
112 | 111 | ||
113 | return_bi = bi->bi_next; | 112 | return_bi = bi->bi_next; |
114 | bi->bi_next = NULL; | 113 | bi->bi_next = NULL; |
115 | bi->bi_size = 0; | 114 | bi->bi_size = 0; |
116 | bi->bi_end_io(bi, bytes, | 115 | bi->bi_end_io(bi, |
117 | test_bit(BIO_UPTODATE, &bi->bi_flags) | 116 | test_bit(BIO_UPTODATE, &bi->bi_flags) |
118 | ? 0 : -EIO); | 117 | ? 0 : -EIO); |
119 | bi = return_bi; | 118 | bi = return_bi; |
@@ -382,10 +381,10 @@ static unsigned long get_stripe_work(struct stripe_head *sh) | |||
382 | return pending; | 381 | return pending; |
383 | } | 382 | } |
384 | 383 | ||
385 | static int | 384 | static void |
386 | raid5_end_read_request(struct bio *bi, unsigned int bytes_done, int error); | 385 | raid5_end_read_request(struct bio *bi, int error); |
387 | static int | 386 | static void |
388 | raid5_end_write_request (struct bio *bi, unsigned int bytes_done, int error); | 387 | raid5_end_write_request(struct bio *bi, int error); |
389 | 388 | ||
390 | static void ops_run_io(struct stripe_head *sh) | 389 | static void ops_run_io(struct stripe_head *sh) |
391 | { | 390 | { |
@@ -1110,8 +1109,7 @@ static void shrink_stripes(raid5_conf_t *conf) | |||
1110 | conf->slab_cache = NULL; | 1109 | conf->slab_cache = NULL; |
1111 | } | 1110 | } |
1112 | 1111 | ||
1113 | static int raid5_end_read_request(struct bio * bi, unsigned int bytes_done, | 1112 | static void raid5_end_read_request(struct bio * bi, int error) |
1114 | int error) | ||
1115 | { | 1113 | { |
1116 | struct stripe_head *sh = bi->bi_private; | 1114 | struct stripe_head *sh = bi->bi_private; |
1117 | raid5_conf_t *conf = sh->raid_conf; | 1115 | raid5_conf_t *conf = sh->raid_conf; |
@@ -1120,8 +1118,6 @@ static int raid5_end_read_request(struct bio * bi, unsigned int bytes_done, | |||
1120 | char b[BDEVNAME_SIZE]; | 1118 | char b[BDEVNAME_SIZE]; |
1121 | mdk_rdev_t *rdev; | 1119 | mdk_rdev_t *rdev; |
1122 | 1120 | ||
1123 | if (bi->bi_size) | ||
1124 | return 1; | ||
1125 | 1121 | ||
1126 | for (i=0 ; i<disks; i++) | 1122 | for (i=0 ; i<disks; i++) |
1127 | if (bi == &sh->dev[i].req) | 1123 | if (bi == &sh->dev[i].req) |
@@ -1132,7 +1128,7 @@ static int raid5_end_read_request(struct bio * bi, unsigned int bytes_done, | |||
1132 | uptodate); | 1128 | uptodate); |
1133 | if (i == disks) { | 1129 | if (i == disks) { |
1134 | BUG(); | 1130 | BUG(); |
1135 | return 0; | 1131 | return; |
1136 | } | 1132 | } |
1137 | 1133 | ||
1138 | if (uptodate) { | 1134 | if (uptodate) { |
@@ -1185,20 +1181,15 @@ static int raid5_end_read_request(struct bio * bi, unsigned int bytes_done, | |||
1185 | clear_bit(R5_LOCKED, &sh->dev[i].flags); | 1181 | clear_bit(R5_LOCKED, &sh->dev[i].flags); |
1186 | set_bit(STRIPE_HANDLE, &sh->state); | 1182 | set_bit(STRIPE_HANDLE, &sh->state); |
1187 | release_stripe(sh); | 1183 | release_stripe(sh); |
1188 | return 0; | ||
1189 | } | 1184 | } |
1190 | 1185 | ||
1191 | static int raid5_end_write_request (struct bio *bi, unsigned int bytes_done, | 1186 | static void raid5_end_write_request (struct bio *bi, int error) |
1192 | int error) | ||
1193 | { | 1187 | { |
1194 | struct stripe_head *sh = bi->bi_private; | 1188 | struct stripe_head *sh = bi->bi_private; |
1195 | raid5_conf_t *conf = sh->raid_conf; | 1189 | raid5_conf_t *conf = sh->raid_conf; |
1196 | int disks = sh->disks, i; | 1190 | int disks = sh->disks, i; |
1197 | int uptodate = test_bit(BIO_UPTODATE, &bi->bi_flags); | 1191 | int uptodate = test_bit(BIO_UPTODATE, &bi->bi_flags); |
1198 | 1192 | ||
1199 | if (bi->bi_size) | ||
1200 | return 1; | ||
1201 | |||
1202 | for (i=0 ; i<disks; i++) | 1193 | for (i=0 ; i<disks; i++) |
1203 | if (bi == &sh->dev[i].req) | 1194 | if (bi == &sh->dev[i].req) |
1204 | break; | 1195 | break; |
@@ -1208,7 +1199,7 @@ static int raid5_end_write_request (struct bio *bi, unsigned int bytes_done, | |||
1208 | uptodate); | 1199 | uptodate); |
1209 | if (i == disks) { | 1200 | if (i == disks) { |
1210 | BUG(); | 1201 | BUG(); |
1211 | return 0; | 1202 | return; |
1212 | } | 1203 | } |
1213 | 1204 | ||
1214 | if (!uptodate) | 1205 | if (!uptodate) |
@@ -1219,7 +1210,6 @@ static int raid5_end_write_request (struct bio *bi, unsigned int bytes_done, | |||
1219 | clear_bit(R5_LOCKED, &sh->dev[i].flags); | 1210 | clear_bit(R5_LOCKED, &sh->dev[i].flags); |
1220 | set_bit(STRIPE_HANDLE, &sh->state); | 1211 | set_bit(STRIPE_HANDLE, &sh->state); |
1221 | release_stripe(sh); | 1212 | release_stripe(sh); |
1222 | return 0; | ||
1223 | } | 1213 | } |
1224 | 1214 | ||
1225 | 1215 | ||
@@ -3340,7 +3330,7 @@ static struct bio *remove_bio_from_retry(raid5_conf_t *conf) | |||
3340 | * first). | 3330 | * first). |
3341 | * If the read failed.. | 3331 | * If the read failed.. |
3342 | */ | 3332 | */ |
3343 | static int raid5_align_endio(struct bio *bi, unsigned int bytes, int error) | 3333 | static void raid5_align_endio(struct bio *bi, int error) |
3344 | { | 3334 | { |
3345 | struct bio* raid_bi = bi->bi_private; | 3335 | struct bio* raid_bi = bi->bi_private; |
3346 | mddev_t *mddev; | 3336 | mddev_t *mddev; |
@@ -3348,8 +3338,6 @@ static int raid5_align_endio(struct bio *bi, unsigned int bytes, int error) | |||
3348 | int uptodate = test_bit(BIO_UPTODATE, &bi->bi_flags); | 3338 | int uptodate = test_bit(BIO_UPTODATE, &bi->bi_flags); |
3349 | mdk_rdev_t *rdev; | 3339 | mdk_rdev_t *rdev; |
3350 | 3340 | ||
3351 | if (bi->bi_size) | ||
3352 | return 1; | ||
3353 | bio_put(bi); | 3341 | bio_put(bi); |
3354 | 3342 | ||
3355 | mddev = raid_bi->bi_bdev->bd_disk->queue->queuedata; | 3343 | mddev = raid_bi->bi_bdev->bd_disk->queue->queuedata; |
@@ -3360,17 +3348,16 @@ static int raid5_align_endio(struct bio *bi, unsigned int bytes, int error) | |||
3360 | rdev_dec_pending(rdev, conf->mddev); | 3348 | rdev_dec_pending(rdev, conf->mddev); |
3361 | 3349 | ||
3362 | if (!error && uptodate) { | 3350 | if (!error && uptodate) { |
3363 | bio_endio(raid_bi, bytes, 0); | 3351 | bio_endio(raid_bi, 0); |
3364 | if (atomic_dec_and_test(&conf->active_aligned_reads)) | 3352 | if (atomic_dec_and_test(&conf->active_aligned_reads)) |
3365 | wake_up(&conf->wait_for_stripe); | 3353 | wake_up(&conf->wait_for_stripe); |
3366 | return 0; | 3354 | return; |
3367 | } | 3355 | } |
3368 | 3356 | ||
3369 | 3357 | ||
3370 | pr_debug("raid5_align_endio : io error...handing IO for a retry\n"); | 3358 | pr_debug("raid5_align_endio : io error...handing IO for a retry\n"); |
3371 | 3359 | ||
3372 | add_bio_to_retry(raid_bi, conf); | 3360 | add_bio_to_retry(raid_bi, conf); |
3373 | return 0; | ||
3374 | } | 3361 | } |
3375 | 3362 | ||
3376 | static int bio_fits_rdev(struct bio *bi) | 3363 | static int bio_fits_rdev(struct bio *bi) |
@@ -3476,7 +3463,7 @@ static int make_request(struct request_queue *q, struct bio * bi) | |||
3476 | int remaining; | 3463 | int remaining; |
3477 | 3464 | ||
3478 | if (unlikely(bio_barrier(bi))) { | 3465 | if (unlikely(bio_barrier(bi))) { |
3479 | bio_endio(bi, bi->bi_size, -EOPNOTSUPP); | 3466 | bio_endio(bi, -EOPNOTSUPP); |
3480 | return 0; | 3467 | return 0; |
3481 | } | 3468 | } |
3482 | 3469 | ||
@@ -3592,12 +3579,11 @@ static int make_request(struct request_queue *q, struct bio * bi) | |||
3592 | remaining = --bi->bi_phys_segments; | 3579 | remaining = --bi->bi_phys_segments; |
3593 | spin_unlock_irq(&conf->device_lock); | 3580 | spin_unlock_irq(&conf->device_lock); |
3594 | if (remaining == 0) { | 3581 | if (remaining == 0) { |
3595 | int bytes = bi->bi_size; | ||
3596 | 3582 | ||
3597 | if ( rw == WRITE ) | 3583 | if ( rw == WRITE ) |
3598 | md_write_end(mddev); | 3584 | md_write_end(mddev); |
3599 | bi->bi_size = 0; | 3585 | |
3600 | bi->bi_end_io(bi, bytes, | 3586 | bi->bi_end_io(bi, |
3601 | test_bit(BIO_UPTODATE, &bi->bi_flags) | 3587 | test_bit(BIO_UPTODATE, &bi->bi_flags) |
3602 | ? 0 : -EIO); | 3588 | ? 0 : -EIO); |
3603 | } | 3589 | } |
@@ -3875,10 +3861,8 @@ static int retry_aligned_read(raid5_conf_t *conf, struct bio *raid_bio) | |||
3875 | remaining = --raid_bio->bi_phys_segments; | 3861 | remaining = --raid_bio->bi_phys_segments; |
3876 | spin_unlock_irq(&conf->device_lock); | 3862 | spin_unlock_irq(&conf->device_lock); |
3877 | if (remaining == 0) { | 3863 | if (remaining == 0) { |
3878 | int bytes = raid_bio->bi_size; | ||
3879 | 3864 | ||
3880 | raid_bio->bi_size = 0; | 3865 | raid_bio->bi_end_io(raid_bio, |
3881 | raid_bio->bi_end_io(raid_bio, bytes, | ||
3882 | test_bit(BIO_UPTODATE, &raid_bio->bi_flags) | 3866 | test_bit(BIO_UPTODATE, &raid_bio->bi_flags) |
3883 | ? 0 : -EIO); | 3867 | ? 0 : -EIO); |
3884 | } | 3868 | } |
diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 4d8798bacf97..859f870552e3 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c | |||
@@ -674,10 +674,10 @@ dcssblk_make_request(struct request_queue *q, struct bio *bio) | |||
674 | } | 674 | } |
675 | bytes_done += bvec->bv_len; | 675 | bytes_done += bvec->bv_len; |
676 | } | 676 | } |
677 | bio_endio(bio, bytes_done, 0); | 677 | bio_endio(bio, 0); |
678 | return 0; | 678 | return 0; |
679 | fail: | 679 | fail: |
680 | bio_io_error(bio, bio->bi_size); | 680 | bio_io_error(bio); |
681 | return 0; | 681 | return 0; |
682 | } | 682 | } |
683 | 683 | ||
diff --git a/drivers/s390/block/xpram.c b/drivers/s390/block/xpram.c index 354a060e5bec..0fbacc8b1063 100644 --- a/drivers/s390/block/xpram.c +++ b/drivers/s390/block/xpram.c | |||
@@ -230,12 +230,10 @@ static int xpram_make_request(struct request_queue *q, struct bio *bio) | |||
230 | } | 230 | } |
231 | } | 231 | } |
232 | set_bit(BIO_UPTODATE, &bio->bi_flags); | 232 | set_bit(BIO_UPTODATE, &bio->bi_flags); |
233 | bytes = bio->bi_size; | 233 | bio_end_io(bio, 0); |
234 | bio->bi_size = 0; | ||
235 | bio->bi_end_io(bio, bytes, 0); | ||
236 | return 0; | 234 | return 0; |
237 | fail: | 235 | fail: |
238 | bio_io_error(bio, bio->bi_size); | 236 | bio_io_error(bio); |
239 | return 0; | 237 | return 0; |
240 | } | 238 | } |
241 | 239 | ||
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 59b398530295..604f4d717933 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c | |||
@@ -266,13 +266,9 @@ static int scsi_merge_bio(struct request *rq, struct bio *bio) | |||
266 | return blk_rq_append_bio(q, rq, bio); | 266 | return blk_rq_append_bio(q, rq, bio); |
267 | } | 267 | } |
268 | 268 | ||
269 | static int scsi_bi_endio(struct bio *bio, unsigned int bytes_done, int error) | 269 | static void scsi_bi_endio(struct bio *bio, int error) |
270 | { | 270 | { |
271 | if (bio->bi_size) | ||
272 | return 1; | ||
273 | |||
274 | bio_put(bio); | 271 | bio_put(bio); |
275 | return 0; | ||
276 | } | 272 | } |
277 | 273 | ||
278 | /** | 274 | /** |
@@ -328,7 +324,7 @@ static int scsi_req_map_sg(struct request *rq, struct scatterlist *sgl, | |||
328 | if (bio->bi_vcnt >= nr_vecs) { | 324 | if (bio->bi_vcnt >= nr_vecs) { |
329 | err = scsi_merge_bio(rq, bio); | 325 | err = scsi_merge_bio(rq, bio); |
330 | if (err) { | 326 | if (err) { |
331 | bio_endio(bio, bio->bi_size, 0); | 327 | bio_endio(bio, 0); |
332 | goto free_bios; | 328 | goto free_bios; |
333 | } | 329 | } |
334 | bio = NULL; | 330 | bio = NULL; |
@@ -350,7 +346,7 @@ free_bios: | |||
350 | /* | 346 | /* |
351 | * call endio instead of bio_put incase it was bounced | 347 | * call endio instead of bio_put incase it was bounced |
352 | */ | 348 | */ |
353 | bio_endio(bio, bio->bi_size, 0); | 349 | bio_endio(bio, 0); |
354 | } | 350 | } |
355 | 351 | ||
356 | return err; | 352 | return err; |
@@ -798,13 +798,9 @@ void bio_unmap_user(struct bio *bio) | |||
798 | bio_put(bio); | 798 | bio_put(bio); |
799 | } | 799 | } |
800 | 800 | ||
801 | static int bio_map_kern_endio(struct bio *bio, unsigned int bytes_done, int err) | 801 | static void bio_map_kern_endio(struct bio *bio, int err) |
802 | { | 802 | { |
803 | if (bio->bi_size) | ||
804 | return 1; | ||
805 | |||
806 | bio_put(bio); | 803 | bio_put(bio); |
807 | return 0; | ||
808 | } | 804 | } |
809 | 805 | ||
810 | 806 | ||
@@ -1002,12 +998,10 @@ void bio_check_pages_dirty(struct bio *bio) | |||
1002 | /** | 998 | /** |
1003 | * bio_endio - end I/O on a bio | 999 | * bio_endio - end I/O on a bio |
1004 | * @bio: bio | 1000 | * @bio: bio |
1005 | * @bytes_done: number of bytes completed | ||
1006 | * @error: error, if any | 1001 | * @error: error, if any |
1007 | * | 1002 | * |
1008 | * Description: | 1003 | * Description: |
1009 | * bio_endio() will end I/O on @bytes_done number of bytes. This | 1004 | * bio_endio() will end I/O on the whole bio. bio_endio() is the |
1010 | * must always be the whole (remaining) bio. bio_endio() is the | ||
1011 | * preferred way to end I/O on a bio, it takes care of clearing | 1005 | * preferred way to end I/O on a bio, it takes care of clearing |
1012 | * BIO_UPTODATE on error. @error is 0 on success, and and one of the | 1006 | * BIO_UPTODATE on error. @error is 0 on success, and and one of the |
1013 | * established -Exxxx (-EIO, for instance) error values in case | 1007 | * established -Exxxx (-EIO, for instance) error values in case |
@@ -1015,22 +1009,15 @@ void bio_check_pages_dirty(struct bio *bio) | |||
1015 | * bio unless they own it and thus know that it has an end_io | 1009 | * bio unless they own it and thus know that it has an end_io |
1016 | * function. | 1010 | * function. |
1017 | **/ | 1011 | **/ |
1018 | void bio_endio(struct bio *bio, unsigned int bytes_done, int error) | 1012 | void bio_endio(struct bio *bio, int error) |
1019 | { | 1013 | { |
1020 | if (error) | 1014 | if (error) |
1021 | clear_bit(BIO_UPTODATE, &bio->bi_flags); | 1015 | clear_bit(BIO_UPTODATE, &bio->bi_flags); |
1022 | else if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) | 1016 | else if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) |
1023 | error = -EIO; | 1017 | error = -EIO; |
1024 | 1018 | ||
1025 | if (unlikely(bytes_done != bio->bi_size)) { | ||
1026 | printk("%s: want %u bytes done, only %u left\n", __FUNCTION__, | ||
1027 | bytes_done, bio->bi_size); | ||
1028 | bytes_done = bio->bi_size; | ||
1029 | } | ||
1030 | |||
1031 | bio->bi_size = 0; /* expected by some callees - will be removed */ | ||
1032 | if (bio->bi_end_io) | 1019 | if (bio->bi_end_io) |
1033 | bio->bi_end_io(bio, bytes_done, error); | 1020 | bio->bi_end_io(bio, error); |
1034 | } | 1021 | } |
1035 | 1022 | ||
1036 | void bio_pair_release(struct bio_pair *bp) | 1023 | void bio_pair_release(struct bio_pair *bp) |
@@ -1038,37 +1025,29 @@ void bio_pair_release(struct bio_pair *bp) | |||
1038 | if (atomic_dec_and_test(&bp->cnt)) { | 1025 | if (atomic_dec_and_test(&bp->cnt)) { |
1039 | struct bio *master = bp->bio1.bi_private; | 1026 | struct bio *master = bp->bio1.bi_private; |
1040 | 1027 | ||
1041 | bio_endio(master, master->bi_size, bp->error); | 1028 | bio_endio(master, bp->error); |
1042 | mempool_free(bp, bp->bio2.bi_private); | 1029 | mempool_free(bp, bp->bio2.bi_private); |
1043 | } | 1030 | } |
1044 | } | 1031 | } |
1045 | 1032 | ||
1046 | static int bio_pair_end_1(struct bio * bi, unsigned int done, int err) | 1033 | static void bio_pair_end_1(struct bio *bi, int err) |
1047 | { | 1034 | { |
1048 | struct bio_pair *bp = container_of(bi, struct bio_pair, bio1); | 1035 | struct bio_pair *bp = container_of(bi, struct bio_pair, bio1); |
1049 | 1036 | ||
1050 | if (err) | 1037 | if (err) |
1051 | bp->error = err; | 1038 | bp->error = err; |
1052 | 1039 | ||
1053 | if (bi->bi_size) | ||
1054 | return 1; | ||
1055 | |||
1056 | bio_pair_release(bp); | 1040 | bio_pair_release(bp); |
1057 | return 0; | ||
1058 | } | 1041 | } |
1059 | 1042 | ||
1060 | static int bio_pair_end_2(struct bio * bi, unsigned int done, int err) | 1043 | static void bio_pair_end_2(struct bio *bi, int err) |
1061 | { | 1044 | { |
1062 | struct bio_pair *bp = container_of(bi, struct bio_pair, bio2); | 1045 | struct bio_pair *bp = container_of(bi, struct bio_pair, bio2); |
1063 | 1046 | ||
1064 | if (err) | 1047 | if (err) |
1065 | bp->error = err; | 1048 | bp->error = err; |
1066 | 1049 | ||
1067 | if (bi->bi_size) | ||
1068 | return 1; | ||
1069 | |||
1070 | bio_pair_release(bp); | 1050 | bio_pair_release(bp); |
1071 | return 0; | ||
1072 | } | 1051 | } |
1073 | 1052 | ||
1074 | /* | 1053 | /* |
diff --git a/fs/block_dev.c b/fs/block_dev.c index 2980eabe5779..6339a30879b7 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -172,7 +172,7 @@ blkdev_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, | |||
172 | } | 172 | } |
173 | 173 | ||
174 | #if 0 | 174 | #if 0 |
175 | static int blk_end_aio(struct bio *bio, unsigned int bytes_done, int error) | 175 | static void blk_end_aio(struct bio *bio, int error) |
176 | { | 176 | { |
177 | struct kiocb *iocb = bio->bi_private; | 177 | struct kiocb *iocb = bio->bi_private; |
178 | atomic_t *bio_count = &iocb->ki_bio_count; | 178 | atomic_t *bio_count = &iocb->ki_bio_count; |
diff --git a/fs/buffer.c b/fs/buffer.c index 0e5ec371ce72..75b51dfa5e03 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -2634,13 +2634,10 @@ sector_t generic_block_bmap(struct address_space *mapping, sector_t block, | |||
2634 | return tmp.b_blocknr; | 2634 | return tmp.b_blocknr; |
2635 | } | 2635 | } |
2636 | 2636 | ||
2637 | static int end_bio_bh_io_sync(struct bio *bio, unsigned int bytes_done, int err) | 2637 | static void end_bio_bh_io_sync(struct bio *bio, int err) |
2638 | { | 2638 | { |
2639 | struct buffer_head *bh = bio->bi_private; | 2639 | struct buffer_head *bh = bio->bi_private; |
2640 | 2640 | ||
2641 | if (bio->bi_size) | ||
2642 | return 1; | ||
2643 | |||
2644 | if (err == -EOPNOTSUPP) { | 2641 | if (err == -EOPNOTSUPP) { |
2645 | set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); | 2642 | set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); |
2646 | set_bit(BH_Eopnotsupp, &bh->b_state); | 2643 | set_bit(BH_Eopnotsupp, &bh->b_state); |
@@ -2648,7 +2645,6 @@ static int end_bio_bh_io_sync(struct bio *bio, unsigned int bytes_done, int err) | |||
2648 | 2645 | ||
2649 | bh->b_end_io(bh, test_bit(BIO_UPTODATE, &bio->bi_flags)); | 2646 | bh->b_end_io(bh, test_bit(BIO_UPTODATE, &bio->bi_flags)); |
2650 | bio_put(bio); | 2647 | bio_put(bio); |
2651 | return 0; | ||
2652 | } | 2648 | } |
2653 | 2649 | ||
2654 | int submit_bh(int rw, struct buffer_head * bh) | 2650 | int submit_bh(int rw, struct buffer_head * bh) |
diff --git a/fs/direct-io.c b/fs/direct-io.c index 901dc55e9f54..b5928a7b6a5a 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c | |||
@@ -264,15 +264,12 @@ static int dio_bio_complete(struct dio *dio, struct bio *bio); | |||
264 | /* | 264 | /* |
265 | * Asynchronous IO callback. | 265 | * Asynchronous IO callback. |
266 | */ | 266 | */ |
267 | static int dio_bio_end_aio(struct bio *bio, unsigned int bytes_done, int error) | 267 | static void dio_bio_end_aio(struct bio *bio, int error) |
268 | { | 268 | { |
269 | struct dio *dio = bio->bi_private; | 269 | struct dio *dio = bio->bi_private; |
270 | unsigned long remaining; | 270 | unsigned long remaining; |
271 | unsigned long flags; | 271 | unsigned long flags; |
272 | 272 | ||
273 | if (bio->bi_size) | ||
274 | return 1; | ||
275 | |||
276 | /* cleanup the bio */ | 273 | /* cleanup the bio */ |
277 | dio_bio_complete(dio, bio); | 274 | dio_bio_complete(dio, bio); |
278 | 275 | ||
@@ -287,8 +284,6 @@ static int dio_bio_end_aio(struct bio *bio, unsigned int bytes_done, int error) | |||
287 | aio_complete(dio->iocb, ret, 0); | 284 | aio_complete(dio->iocb, ret, 0); |
288 | kfree(dio); | 285 | kfree(dio); |
289 | } | 286 | } |
290 | |||
291 | return 0; | ||
292 | } | 287 | } |
293 | 288 | ||
294 | /* | 289 | /* |
@@ -298,21 +293,17 @@ static int dio_bio_end_aio(struct bio *bio, unsigned int bytes_done, int error) | |||
298 | * During I/O bi_private points at the dio. After I/O, bi_private is used to | 293 | * During I/O bi_private points at the dio. After I/O, bi_private is used to |
299 | * implement a singly-linked list of completed BIOs, at dio->bio_list. | 294 | * implement a singly-linked list of completed BIOs, at dio->bio_list. |
300 | */ | 295 | */ |
301 | static int dio_bio_end_io(struct bio *bio, unsigned int bytes_done, int error) | 296 | static void dio_bio_end_io(struct bio *bio, int error) |
302 | { | 297 | { |
303 | struct dio *dio = bio->bi_private; | 298 | struct dio *dio = bio->bi_private; |
304 | unsigned long flags; | 299 | unsigned long flags; |
305 | 300 | ||
306 | if (bio->bi_size) | ||
307 | return 1; | ||
308 | |||
309 | spin_lock_irqsave(&dio->bio_lock, flags); | 301 | spin_lock_irqsave(&dio->bio_lock, flags); |
310 | bio->bi_private = dio->bio_list; | 302 | bio->bi_private = dio->bio_list; |
311 | dio->bio_list = bio; | 303 | dio->bio_list = bio; |
312 | if (--dio->refcount == 1 && dio->waiter) | 304 | if (--dio->refcount == 1 && dio->waiter) |
313 | wake_up_process(dio->waiter); | 305 | wake_up_process(dio->waiter); |
314 | spin_unlock_irqrestore(&dio->bio_lock, flags); | 306 | spin_unlock_irqrestore(&dio->bio_lock, flags); |
315 | return 0; | ||
316 | } | 307 | } |
317 | 308 | ||
318 | static int | 309 | static int |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index f916b9740c75..2473e2a86d1b 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -160,11 +160,9 @@ int gfs2_check_sb(struct gfs2_sbd *sdp, struct gfs2_sb_host *sb, int silent) | |||
160 | } | 160 | } |
161 | 161 | ||
162 | 162 | ||
163 | static int end_bio_io_page(struct bio *bio, unsigned int bytes_done, int error) | 163 | static void end_bio_io_page(struct bio *bio, int error) |
164 | { | 164 | { |
165 | struct page *page = bio->bi_private; | 165 | struct page *page = bio->bi_private; |
166 | if (bio->bi_size) | ||
167 | return 1; | ||
168 | 166 | ||
169 | if (!error) | 167 | if (!error) |
170 | SetPageUptodate(page); | 168 | SetPageUptodate(page); |
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index de3e4a506dbc..57c3b8ac36bf 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c | |||
@@ -2200,16 +2200,13 @@ static int lbmIOWait(struct lbuf * bp, int flag) | |||
2200 | * | 2200 | * |
2201 | * executed at INTIODONE level | 2201 | * executed at INTIODONE level |
2202 | */ | 2202 | */ |
2203 | static int lbmIODone(struct bio *bio, unsigned int bytes_done, int error) | 2203 | static void lbmIODone(struct bio *bio, int error) |
2204 | { | 2204 | { |
2205 | struct lbuf *bp = bio->bi_private; | 2205 | struct lbuf *bp = bio->bi_private; |
2206 | struct lbuf *nextbp, *tail; | 2206 | struct lbuf *nextbp, *tail; |
2207 | struct jfs_log *log; | 2207 | struct jfs_log *log; |
2208 | unsigned long flags; | 2208 | unsigned long flags; |
2209 | 2209 | ||
2210 | if (bio->bi_size) | ||
2211 | return 1; | ||
2212 | |||
2213 | /* | 2210 | /* |
2214 | * get back jfs buffer bound to the i/o buffer | 2211 | * get back jfs buffer bound to the i/o buffer |
2215 | */ | 2212 | */ |
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 62e96be02acf..1332adc0b9fa 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c | |||
@@ -280,14 +280,10 @@ static void last_read_complete(struct page *page) | |||
280 | unlock_page(page); | 280 | unlock_page(page); |
281 | } | 281 | } |
282 | 282 | ||
283 | static int metapage_read_end_io(struct bio *bio, unsigned int bytes_done, | 283 | static void metapage_read_end_io(struct bio *bio, int err) |
284 | int err) | ||
285 | { | 284 | { |
286 | struct page *page = bio->bi_private; | 285 | struct page *page = bio->bi_private; |
287 | 286 | ||
288 | if (bio->bi_size) | ||
289 | return 1; | ||
290 | |||
291 | if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) { | 287 | if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) { |
292 | printk(KERN_ERR "metapage_read_end_io: I/O error\n"); | 288 | printk(KERN_ERR "metapage_read_end_io: I/O error\n"); |
293 | SetPageError(page); | 289 | SetPageError(page); |
@@ -341,16 +337,12 @@ static void last_write_complete(struct page *page) | |||
341 | end_page_writeback(page); | 337 | end_page_writeback(page); |
342 | } | 338 | } |
343 | 339 | ||
344 | static int metapage_write_end_io(struct bio *bio, unsigned int bytes_done, | 340 | static void metapage_write_end_io(struct bio *bio, int err) |
345 | int err) | ||
346 | { | 341 | { |
347 | struct page *page = bio->bi_private; | 342 | struct page *page = bio->bi_private; |
348 | 343 | ||
349 | BUG_ON(!PagePrivate(page)); | 344 | BUG_ON(!PagePrivate(page)); |
350 | 345 | ||
351 | if (bio->bi_size) | ||
352 | return 1; | ||
353 | |||
354 | if (! test_bit(BIO_UPTODATE, &bio->bi_flags)) { | 346 | if (! test_bit(BIO_UPTODATE, &bio->bi_flags)) { |
355 | printk(KERN_ERR "metapage_write_end_io: I/O error\n"); | 347 | printk(KERN_ERR "metapage_write_end_io: I/O error\n"); |
356 | SetPageError(page); | 348 | SetPageError(page); |
diff --git a/fs/mpage.c b/fs/mpage.c index c1698f2291aa..b1c3e5890508 100644 --- a/fs/mpage.c +++ b/fs/mpage.c | |||
@@ -39,14 +39,11 @@ | |||
39 | * status of that page is hard. See end_buffer_async_read() for the details. | 39 | * status of that page is hard. See end_buffer_async_read() for the details. |
40 | * There is no point in duplicating all that complexity. | 40 | * There is no point in duplicating all that complexity. |
41 | */ | 41 | */ |
42 | static int mpage_end_io_read(struct bio *bio, unsigned int bytes_done, int err) | 42 | static void mpage_end_io_read(struct bio *bio, int err) |
43 | { | 43 | { |
44 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 44 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
45 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; | 45 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; |
46 | 46 | ||
47 | if (bio->bi_size) | ||
48 | return 1; | ||
49 | |||
50 | do { | 47 | do { |
51 | struct page *page = bvec->bv_page; | 48 | struct page *page = bvec->bv_page; |
52 | 49 | ||
@@ -62,17 +59,13 @@ static int mpage_end_io_read(struct bio *bio, unsigned int bytes_done, int err) | |||
62 | unlock_page(page); | 59 | unlock_page(page); |
63 | } while (bvec >= bio->bi_io_vec); | 60 | } while (bvec >= bio->bi_io_vec); |
64 | bio_put(bio); | 61 | bio_put(bio); |
65 | return 0; | ||
66 | } | 62 | } |
67 | 63 | ||
68 | static int mpage_end_io_write(struct bio *bio, unsigned int bytes_done, int err) | 64 | static void mpage_end_io_write(struct bio *bio, int err) |
69 | { | 65 | { |
70 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 66 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
71 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; | 67 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; |
72 | 68 | ||
73 | if (bio->bi_size) | ||
74 | return 1; | ||
75 | |||
76 | do { | 69 | do { |
77 | struct page *page = bvec->bv_page; | 70 | struct page *page = bvec->bv_page; |
78 | 71 | ||
@@ -87,7 +80,6 @@ static int mpage_end_io_write(struct bio *bio, unsigned int bytes_done, int err) | |||
87 | end_page_writeback(page); | 80 | end_page_writeback(page); |
88 | } while (bvec >= bio->bi_io_vec); | 81 | } while (bvec >= bio->bi_io_vec); |
89 | bio_put(bio); | 82 | bio_put(bio); |
90 | return 0; | ||
91 | } | 83 | } |
92 | 84 | ||
93 | static struct bio *mpage_bio_submit(int rw, struct bio *bio) | 85 | static struct bio *mpage_bio_submit(int rw, struct bio *bio) |
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index 2bd7f788cf34..da2c2b442b49 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2/cluster/heartbeat.c | |||
@@ -217,7 +217,6 @@ static void o2hb_wait_on_io(struct o2hb_region *reg, | |||
217 | } | 217 | } |
218 | 218 | ||
219 | static int o2hb_bio_end_io(struct bio *bio, | 219 | static int o2hb_bio_end_io(struct bio *bio, |
220 | unsigned int bytes_done, | ||
221 | int error) | 220 | int error) |
222 | { | 221 | { |
223 | struct o2hb_bio_wait_ctxt *wc = bio->bi_private; | 222 | struct o2hb_bio_wait_ctxt *wc = bio->bi_private; |
@@ -227,9 +226,6 @@ static int o2hb_bio_end_io(struct bio *bio, | |||
227 | wc->wc_error = error; | 226 | wc->wc_error = error; |
228 | } | 227 | } |
229 | 228 | ||
230 | if (bio->bi_size) | ||
231 | return 1; | ||
232 | |||
233 | o2hb_bio_wait_dec(wc, 1); | 229 | o2hb_bio_wait_dec(wc, 1); |
234 | bio_put(bio); | 230 | bio_put(bio); |
235 | return 0; | 231 | return 0; |
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index 5f152f60d74d..3f13519436af 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c | |||
@@ -326,14 +326,10 @@ xfs_iomap_valid( | |||
326 | STATIC int | 326 | STATIC int |
327 | xfs_end_bio( | 327 | xfs_end_bio( |
328 | struct bio *bio, | 328 | struct bio *bio, |
329 | unsigned int bytes_done, | ||
330 | int error) | 329 | int error) |
331 | { | 330 | { |
332 | xfs_ioend_t *ioend = bio->bi_private; | 331 | xfs_ioend_t *ioend = bio->bi_private; |
333 | 332 | ||
334 | if (bio->bi_size) | ||
335 | return 1; | ||
336 | |||
337 | ASSERT(atomic_read(&bio->bi_cnt) >= 1); | 333 | ASSERT(atomic_read(&bio->bi_cnt) >= 1); |
338 | ioend->io_error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? 0 : error; | 334 | ioend->io_error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? 0 : error; |
339 | 335 | ||
diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c index b0f0e58866de..6a75f4d984a1 100644 --- a/fs/xfs/linux-2.6/xfs_buf.c +++ b/fs/xfs/linux-2.6/xfs_buf.c | |||
@@ -1106,16 +1106,12 @@ _xfs_buf_ioend( | |||
1106 | STATIC int | 1106 | STATIC int |
1107 | xfs_buf_bio_end_io( | 1107 | xfs_buf_bio_end_io( |
1108 | struct bio *bio, | 1108 | struct bio *bio, |
1109 | unsigned int bytes_done, | ||
1110 | int error) | 1109 | int error) |
1111 | { | 1110 | { |
1112 | xfs_buf_t *bp = (xfs_buf_t *)bio->bi_private; | 1111 | xfs_buf_t *bp = (xfs_buf_t *)bio->bi_private; |
1113 | unsigned int blocksize = bp->b_target->bt_bsize; | 1112 | unsigned int blocksize = bp->b_target->bt_bsize; |
1114 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; | 1113 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; |
1115 | 1114 | ||
1116 | if (bio->bi_size) | ||
1117 | return 1; | ||
1118 | |||
1119 | if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) | 1115 | if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) |
1120 | bp->b_error = EIO; | 1116 | bp->b_error = EIO; |
1121 | 1117 | ||
diff --git a/include/linux/bio.h b/include/linux/bio.h index 1ddef34f43c3..089a8bc55dd4 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h | |||
@@ -64,7 +64,7 @@ struct bio_vec { | |||
64 | 64 | ||
65 | struct bio_set; | 65 | struct bio_set; |
66 | struct bio; | 66 | struct bio; |
67 | typedef int (bio_end_io_t) (struct bio *, unsigned int, int); | 67 | typedef void (bio_end_io_t) (struct bio *, int); |
68 | typedef void (bio_destructor_t) (struct bio *); | 68 | typedef void (bio_destructor_t) (struct bio *); |
69 | 69 | ||
70 | /* | 70 | /* |
@@ -226,7 +226,7 @@ struct bio { | |||
226 | #define BIO_SEG_BOUNDARY(q, b1, b2) \ | 226 | #define BIO_SEG_BOUNDARY(q, b1, b2) \ |
227 | BIOVEC_SEG_BOUNDARY((q), __BVEC_END((b1)), __BVEC_START((b2))) | 227 | BIOVEC_SEG_BOUNDARY((q), __BVEC_END((b1)), __BVEC_START((b2))) |
228 | 228 | ||
229 | #define bio_io_error(bio, bytes) bio_endio((bio), (bytes), -EIO) | 229 | #define bio_io_error(bio) bio_endio((bio), -EIO) |
230 | 230 | ||
231 | /* | 231 | /* |
232 | * drivers should not use the __ version unless they _really_ want to | 232 | * drivers should not use the __ version unless they _really_ want to |
@@ -286,7 +286,7 @@ extern struct bio *bio_alloc_bioset(gfp_t, int, struct bio_set *); | |||
286 | extern void bio_put(struct bio *); | 286 | extern void bio_put(struct bio *); |
287 | extern void bio_free(struct bio *, struct bio_set *); | 287 | extern void bio_free(struct bio *, struct bio_set *); |
288 | 288 | ||
289 | extern void bio_endio(struct bio *, unsigned int, int); | 289 | extern void bio_endio(struct bio *, int); |
290 | struct request_queue; | 290 | struct request_queue; |
291 | extern int bio_phys_segments(struct request_queue *, struct bio *); | 291 | extern int bio_phys_segments(struct request_queue *, struct bio *); |
292 | extern int bio_hw_segments(struct request_queue *, struct bio *); | 292 | extern int bio_hw_segments(struct request_queue *, struct bio *); |
diff --git a/include/linux/swap.h b/include/linux/swap.h index 665f85f2a3af..edf681a7fd8f 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h | |||
@@ -221,7 +221,7 @@ extern void swap_unplug_io_fn(struct backing_dev_info *, struct page *); | |||
221 | /* linux/mm/page_io.c */ | 221 | /* linux/mm/page_io.c */ |
222 | extern int swap_readpage(struct file *, struct page *); | 222 | extern int swap_readpage(struct file *, struct page *); |
223 | extern int swap_writepage(struct page *page, struct writeback_control *wbc); | 223 | extern int swap_writepage(struct page *page, struct writeback_control *wbc); |
224 | extern int end_swap_bio_read(struct bio *bio, unsigned int bytes_done, int err); | 224 | extern void end_swap_bio_read(struct bio *bio, int err); |
225 | 225 | ||
226 | /* linux/mm/swap_state.c */ | 226 | /* linux/mm/swap_state.c */ |
227 | extern struct address_space swapper_space; | 227 | extern struct address_space swapper_space; |
diff --git a/mm/bounce.c b/mm/bounce.c index 179fe38a2416..3b549bf31f7d 100644 --- a/mm/bounce.c +++ b/mm/bounce.c | |||
@@ -140,26 +140,19 @@ static void bounce_end_io(struct bio *bio, mempool_t *pool, int err) | |||
140 | mempool_free(bvec->bv_page, pool); | 140 | mempool_free(bvec->bv_page, pool); |
141 | } | 141 | } |
142 | 142 | ||
143 | bio_endio(bio_orig, bio_orig->bi_size, err); | 143 | bio_endio(bio_orig, err); |
144 | bio_put(bio); | 144 | bio_put(bio); |
145 | } | 145 | } |
146 | 146 | ||
147 | static int bounce_end_io_write(struct bio *bio, unsigned int bytes_done, int err) | 147 | static void bounce_end_io_write(struct bio *bio, int err) |
148 | { | 148 | { |
149 | if (bio->bi_size) | ||
150 | return 1; | ||
151 | |||
152 | bounce_end_io(bio, page_pool, err); | 149 | bounce_end_io(bio, page_pool, err); |
153 | return 0; | ||
154 | } | 150 | } |
155 | 151 | ||
156 | static int bounce_end_io_write_isa(struct bio *bio, unsigned int bytes_done, int err) | 152 | static void bounce_end_io_write_isa(struct bio *bio, int err) |
157 | { | 153 | { |
158 | if (bio->bi_size) | ||
159 | return 1; | ||
160 | 154 | ||
161 | bounce_end_io(bio, isa_page_pool, err); | 155 | bounce_end_io(bio, isa_page_pool, err); |
162 | return 0; | ||
163 | } | 156 | } |
164 | 157 | ||
165 | static void __bounce_end_io_read(struct bio *bio, mempool_t *pool, int err) | 158 | static void __bounce_end_io_read(struct bio *bio, mempool_t *pool, int err) |
@@ -172,22 +165,14 @@ static void __bounce_end_io_read(struct bio *bio, mempool_t *pool, int err) | |||
172 | bounce_end_io(bio, pool, err); | 165 | bounce_end_io(bio, pool, err); |
173 | } | 166 | } |
174 | 167 | ||
175 | static int bounce_end_io_read(struct bio *bio, unsigned int bytes_done, int err) | 168 | static void bounce_end_io_read(struct bio *bio, int err) |
176 | { | 169 | { |
177 | if (bio->bi_size) | ||
178 | return 1; | ||
179 | |||
180 | __bounce_end_io_read(bio, page_pool, err); | 170 | __bounce_end_io_read(bio, page_pool, err); |
181 | return 0; | ||
182 | } | 171 | } |
183 | 172 | ||
184 | static int bounce_end_io_read_isa(struct bio *bio, unsigned int bytes_done, int err) | 173 | static void bounce_end_io_read_isa(struct bio *bio, int err) |
185 | { | 174 | { |
186 | if (bio->bi_size) | ||
187 | return 1; | ||
188 | |||
189 | __bounce_end_io_read(bio, isa_page_pool, err); | 175 | __bounce_end_io_read(bio, isa_page_pool, err); |
190 | return 0; | ||
191 | } | 176 | } |
192 | 177 | ||
193 | static void __blk_queue_bounce(struct request_queue *q, struct bio **bio_orig, | 178 | static void __blk_queue_bounce(struct request_queue *q, struct bio **bio_orig, |
diff --git a/mm/page_io.c b/mm/page_io.c index dbffec0d78c9..3b97f6850273 100644 --- a/mm/page_io.c +++ b/mm/page_io.c | |||
@@ -44,14 +44,11 @@ static struct bio *get_swap_bio(gfp_t gfp_flags, pgoff_t index, | |||
44 | return bio; | 44 | return bio; |
45 | } | 45 | } |
46 | 46 | ||
47 | static int end_swap_bio_write(struct bio *bio, unsigned int bytes_done, int err) | 47 | static void end_swap_bio_write(struct bio *bio, int err) |
48 | { | 48 | { |
49 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 49 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
50 | struct page *page = bio->bi_io_vec[0].bv_page; | 50 | struct page *page = bio->bi_io_vec[0].bv_page; |
51 | 51 | ||
52 | if (bio->bi_size) | ||
53 | return 1; | ||
54 | |||
55 | if (!uptodate) { | 52 | if (!uptodate) { |
56 | SetPageError(page); | 53 | SetPageError(page); |
57 | /* | 54 | /* |
@@ -71,17 +68,13 @@ static int end_swap_bio_write(struct bio *bio, unsigned int bytes_done, int err) | |||
71 | } | 68 | } |
72 | end_page_writeback(page); | 69 | end_page_writeback(page); |
73 | bio_put(bio); | 70 | bio_put(bio); |
74 | return 0; | ||
75 | } | 71 | } |
76 | 72 | ||
77 | int end_swap_bio_read(struct bio *bio, unsigned int bytes_done, int err) | 73 | void end_swap_bio_read(struct bio *bio, int err) |
78 | { | 74 | { |
79 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | 75 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); |
80 | struct page *page = bio->bi_io_vec[0].bv_page; | 76 | struct page *page = bio->bi_io_vec[0].bv_page; |
81 | 77 | ||
82 | if (bio->bi_size) | ||
83 | return 1; | ||
84 | |||
85 | if (!uptodate) { | 78 | if (!uptodate) { |
86 | SetPageError(page); | 79 | SetPageError(page); |
87 | ClearPageUptodate(page); | 80 | ClearPageUptodate(page); |
@@ -94,7 +87,6 @@ int end_swap_bio_read(struct bio *bio, unsigned int bytes_done, int err) | |||
94 | } | 87 | } |
95 | unlock_page(page); | 88 | unlock_page(page); |
96 | bio_put(bio); | 89 | bio_put(bio); |
97 | return 0; | ||
98 | } | 90 | } |
99 | 91 | ||
100 | /* | 92 | /* |