diff options
author | Mark Lord <liml@rtr.ca> | 2008-01-26 18:28:23 -0500 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2008-02-01 11:29:46 -0500 |
commit | 3606a380692cf958355a40fc1aa336800c17baf1 (patch) | |
tree | 263971d3bbb033658fdfa76f6c02ae540a21f554 | |
parent | 24e1c13c93cbdd05e4b7ea921c0050b036555adc (diff) |
sata_mv ncq EH fixes
A hard reset is necessary after hotplug events.
Only clear the error irq bits that were set on entry.
Signed-off-by: Mark Lord <mlord@pobox.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r-- | drivers/ata/sata_mv.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 7e72463a90eb..5dd969e10302 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c | |||
@@ -1437,6 +1437,7 @@ static void mv_err_intr(struct ata_port *ap, struct ata_queued_cmd *qc) | |||
1437 | ata_ehi_hotplugged(ehi); | 1437 | ata_ehi_hotplugged(ehi); |
1438 | ata_ehi_push_desc(ehi, edma_err_cause & EDMA_ERR_DEV_DCON ? | 1438 | ata_ehi_push_desc(ehi, edma_err_cause & EDMA_ERR_DEV_DCON ? |
1439 | "dev disconnect" : "dev connect"); | 1439 | "dev disconnect" : "dev connect"); |
1440 | action |= ATA_EH_HARDRESET; | ||
1440 | } | 1441 | } |
1441 | 1442 | ||
1442 | if (IS_GEN_I(hpriv)) { | 1443 | if (IS_GEN_I(hpriv)) { |
@@ -1465,7 +1466,7 @@ static void mv_err_intr(struct ata_port *ap, struct ata_queued_cmd *qc) | |||
1465 | } | 1466 | } |
1466 | 1467 | ||
1467 | /* Clear EDMA now that SERR cleanup done */ | 1468 | /* Clear EDMA now that SERR cleanup done */ |
1468 | writelfl(0, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS); | 1469 | writelfl(~edma_err_cause, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS); |
1469 | 1470 | ||
1470 | if (!err_mask) { | 1471 | if (!err_mask) { |
1471 | err_mask = AC_ERR_OTHER; | 1472 | err_mask = AC_ERR_OTHER; |