diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-10-16 17:18:29 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-10-16 17:18:29 -0400 |
commit | 00269b54edbf25f3bb0dccb558ae23a6fc77ed86 (patch) | |
tree | 63eb993fc8c463c5f6d023961b61b9dbaccd82cc | |
parent | dc976c09da4e13b2b3fda23cca9d0682d1de7213 (diff) |
ipv4: Add a missing rcu_assign_pointer() in routing cache.
rt_intern_hash() is doing an update of a RCU guarded hash chain
without using rcu_assign_pointer() or equivalent barrier.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/route.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index a6d7c584f53b..8d23cc7efbad 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c | |||
@@ -1109,7 +1109,12 @@ restart: | |||
1109 | printk("\n"); | 1109 | printk("\n"); |
1110 | } | 1110 | } |
1111 | #endif | 1111 | #endif |
1112 | rt_hash_table[hash].chain = rt; | 1112 | /* |
1113 | * Since lookup is lockfree, we must make sure | ||
1114 | * previous writes to rt are comitted to memory | ||
1115 | * before making rt visible to other CPUS. | ||
1116 | */ | ||
1117 | rcu_assign_pointer(rt_hash_table[hash].chain, rt); | ||
1113 | spin_unlock_bh(rt_hash_lock_addr(hash)); | 1118 | spin_unlock_bh(rt_hash_lock_addr(hash)); |
1114 | *rp = rt; | 1119 | *rp = rt; |
1115 | return 0; | 1120 | return 0; |