diff options
author | Kirill Smelkov <kirr@mns.spb.ru> | 2006-10-03 04:14:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-03 11:04:07 -0400 |
commit | 14e0a193209aeea810ad3d66388f422dc79c5b40 (patch) | |
tree | 10ce3b8e3b9da3d12f31814b009a6db0505a0934 | |
parent | f3d5b34caae393f13a9486036f98c81cac1595c4 (diff) |
[PATCH] ide: fix revision comparison in ide_in_drive_list
Fix ide_in_drive_list: drive_table->id_firmware should be searched *in*
id->fw_rev, not vice versa.
Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/ide/ide-dma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c index 22ef73eb1f68..53feaf82576e 100644 --- a/drivers/ide/ide-dma.c +++ b/drivers/ide/ide-dma.c | |||
@@ -145,7 +145,7 @@ int ide_in_drive_list(struct hd_driveid *id, const struct drive_list_entry *driv | |||
145 | { | 145 | { |
146 | for ( ; drive_table->id_model ; drive_table++) | 146 | for ( ; drive_table->id_model ; drive_table++) |
147 | if ((!strcmp(drive_table->id_model, id->model)) && | 147 | if ((!strcmp(drive_table->id_model, id->model)) && |
148 | ((strstr(drive_table->id_firmware, id->fw_rev)) || | 148 | ((strstr(id->fw_rev, drive_table->id_firmware)) || |
149 | (!strcmp(drive_table->id_firmware, "ALL")))) | 149 | (!strcmp(drive_table->id_firmware, "ALL")))) |
150 | return 1; | 150 | return 1; |
151 | return 0; | 151 | return 0; |