aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Lamparter <chunkeey@web.de>2009-08-20 14:22:01 -0400
committerJohn W. Linville <linville@tuxdriver.com>2009-08-28 14:40:23 -0400
commit90d6f92828a081a86cb4f9644b6eef6207855050 (patch)
treec47f2cad3790829905c4944dbb80a85062591914
parent7c6a3ed5bd61ec981c8a0d0111cfd435adf3f2b7 (diff)
p54: fix broadcast buffering in AP mode
The patch "mac80211: fix PS-poll response race" somehow broke broadcast buffering in a funny way. During normal operation - stations are awake - the firmware refused to transmit broadcast frames and reported P54_TX_PSM_CANCELLED. But everything worked as soon as one station entered PSM. The reason: The stack sets IEEE80211_TX_CTL_SEND_AFTER_DTIM for outgoing broadcast frames as soon as a station is marked as sleeping. This flag triggers a path which will reroute these frames into p54's "content after beacon" queue, which is designed to cope with the demands for psm. This patch restores the old behavior. IEEE80211_TX_CTL_CLEAR_PS_FILT will once again be used to signalize the firmware to ignore the ps canceling for certain frames. Signed-off-by: Christian Lamparter <chunkeey@web.de> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/p54/txrx.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/wireless/p54/txrx.c b/drivers/net/wireless/p54/txrx.c
index 6fc0b6148c8a..b6dda2b27fb5 100644
--- a/drivers/net/wireless/p54/txrx.c
+++ b/drivers/net/wireless/p54/txrx.c
@@ -623,6 +623,9 @@ static void p54_tx_80211_header(struct p54_common *priv, struct sk_buff *skb,
623 if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE) 623 if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE)
624 *flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL; 624 *flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL;
625 625
626 if (info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT)
627 *flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL;
628
626 *queue = skb_get_queue_mapping(skb) + P54_QUEUE_DATA; 629 *queue = skb_get_queue_mapping(skb) + P54_QUEUE_DATA;
627 630
628 switch (priv->mode) { 631 switch (priv->mode) {