aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2006-01-11 18:39:14 -0500
committerDavid S. Miller <davem@sunset.davemloft.net>2006-01-11 19:32:12 -0500
commita7768097557be91d0d4c37e8f2e38cd126c4cdf9 (patch)
tree476e148a9e6f861405860df720c5705fb9e14ba8
parent82bf7e97ac5b9fd03aea10df6910cad50d6c032d (diff)
[NETFILTER]: ip_ct_proto_gre_fini() cannot be __exit
It is invoked from failures paths of __init code. Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/netfilter/ip_conntrack_helper_pptp.c2
-rw-r--r--net/ipv4/netfilter/ip_conntrack_proto_gre.c5
2 files changed, 5 insertions, 2 deletions
diff --git a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
index 4108a5e12b3c..d716bba798f2 100644
--- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
+++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
@@ -762,7 +762,7 @@ static struct ip_conntrack_helper pptp = {
762 .help = conntrack_pptp_help 762 .help = conntrack_pptp_help
763}; 763};
764 764
765extern void __exit ip_ct_proto_gre_fini(void); 765extern void ip_ct_proto_gre_fini(void);
766extern int __init ip_ct_proto_gre_init(void); 766extern int __init ip_ct_proto_gre_init(void);
767 767
768/* ip_conntrack_pptp initialization */ 768/* ip_conntrack_pptp initialization */
diff --git a/net/ipv4/netfilter/ip_conntrack_proto_gre.c b/net/ipv4/netfilter/ip_conntrack_proto_gre.c
index 57956dee60c8..c777abf16cb7 100644
--- a/net/ipv4/netfilter/ip_conntrack_proto_gre.c
+++ b/net/ipv4/netfilter/ip_conntrack_proto_gre.c
@@ -309,7 +309,10 @@ int __init ip_ct_proto_gre_init(void)
309 return ip_conntrack_protocol_register(&gre); 309 return ip_conntrack_protocol_register(&gre);
310} 310}
311 311
312void __exit ip_ct_proto_gre_fini(void) 312/* This cannot be __exit, as it is invoked from ip_conntrack_helper_pptp.c's
313 * init() code on errors.
314 */
315void ip_ct_proto_gre_fini(void)
313{ 316{
314 struct list_head *pos, *n; 317 struct list_head *pos, *n;
315 318