diff options
author | FUJITA Tomonori <tomof@acm.org> | 2008-02-05 01:28:03 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-05 12:44:10 -0500 |
commit | d1b5163206769aa93271bc1029e877ea9f920a5d (patch) | |
tree | 436b2d39dba80d28b0ec3a6f602c813cf0ec4fe0 | |
parent | fde6a3c82d67f592eb587be4d12222b0ae6d4321 (diff) |
iommu sg merging: parisc: make iommu respect the segment size limits
This patch makes iommu respect segment size limits when merging sg
lists.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Cc: Matthew Wilcox <willy@debian.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/parisc/ccio-dma.c | 2 | ||||
-rw-r--r-- | drivers/parisc/iommu-helpers.h | 7 | ||||
-rw-r--r-- | drivers/parisc/sba_iommu.c | 2 |
3 files changed, 8 insertions, 3 deletions
diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c index ca52307b8f40..d08b284de196 100644 --- a/drivers/parisc/ccio-dma.c +++ b/drivers/parisc/ccio-dma.c | |||
@@ -941,7 +941,7 @@ ccio_map_sg(struct device *dev, struct scatterlist *sglist, int nents, | |||
941 | ** w/o this association, we wouldn't have coherent DMA! | 941 | ** w/o this association, we wouldn't have coherent DMA! |
942 | ** Access to the virtual address is what forces a two pass algorithm. | 942 | ** Access to the virtual address is what forces a two pass algorithm. |
943 | */ | 943 | */ |
944 | coalesced = iommu_coalesce_chunks(ioc, sglist, nents, ccio_alloc_range); | 944 | coalesced = iommu_coalesce_chunks(ioc, dev, sglist, nents, ccio_alloc_range); |
945 | 945 | ||
946 | /* | 946 | /* |
947 | ** Program the I/O Pdir | 947 | ** Program the I/O Pdir |
diff --git a/drivers/parisc/iommu-helpers.h b/drivers/parisc/iommu-helpers.h index 0a1f99a2e93e..97ba8286c596 100644 --- a/drivers/parisc/iommu-helpers.h +++ b/drivers/parisc/iommu-helpers.h | |||
@@ -95,12 +95,14 @@ iommu_fill_pdir(struct ioc *ioc, struct scatterlist *startsg, int nents, | |||
95 | */ | 95 | */ |
96 | 96 | ||
97 | static inline unsigned int | 97 | static inline unsigned int |
98 | iommu_coalesce_chunks(struct ioc *ioc, struct scatterlist *startsg, int nents, | 98 | iommu_coalesce_chunks(struct ioc *ioc, struct device *dev, |
99 | struct scatterlist *startsg, int nents, | ||
99 | int (*iommu_alloc_range)(struct ioc *, size_t)) | 100 | int (*iommu_alloc_range)(struct ioc *, size_t)) |
100 | { | 101 | { |
101 | struct scatterlist *contig_sg; /* contig chunk head */ | 102 | struct scatterlist *contig_sg; /* contig chunk head */ |
102 | unsigned long dma_offset, dma_len; /* start/len of DMA stream */ | 103 | unsigned long dma_offset, dma_len; /* start/len of DMA stream */ |
103 | unsigned int n_mappings = 0; | 104 | unsigned int n_mappings = 0; |
105 | unsigned int max_seg_size = dma_get_max_seg_size(dev); | ||
104 | 106 | ||
105 | while (nents > 0) { | 107 | while (nents > 0) { |
106 | 108 | ||
@@ -142,6 +144,9 @@ iommu_coalesce_chunks(struct ioc *ioc, struct scatterlist *startsg, int nents, | |||
142 | IOVP_SIZE) > DMA_CHUNK_SIZE)) | 144 | IOVP_SIZE) > DMA_CHUNK_SIZE)) |
143 | break; | 145 | break; |
144 | 146 | ||
147 | if (startsg->length + dma_len > max_seg_size) | ||
148 | break; | ||
149 | |||
145 | /* | 150 | /* |
146 | ** Next see if we can append the next chunk (i.e. | 151 | ** Next see if we can append the next chunk (i.e. |
147 | ** it must end on one page and begin on another | 152 | ** it must end on one page and begin on another |
diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c index e527a0e1d6c0..d06627c3f353 100644 --- a/drivers/parisc/sba_iommu.c +++ b/drivers/parisc/sba_iommu.c | |||
@@ -946,7 +946,7 @@ sba_map_sg(struct device *dev, struct scatterlist *sglist, int nents, | |||
946 | ** w/o this association, we wouldn't have coherent DMA! | 946 | ** w/o this association, we wouldn't have coherent DMA! |
947 | ** Access to the virtual address is what forces a two pass algorithm. | 947 | ** Access to the virtual address is what forces a two pass algorithm. |
948 | */ | 948 | */ |
949 | coalesced = iommu_coalesce_chunks(ioc, sglist, nents, sba_alloc_range); | 949 | coalesced = iommu_coalesce_chunks(ioc, dev, sglist, nents, sba_alloc_range); |
950 | 950 | ||
951 | /* | 951 | /* |
952 | ** Program the I/O Pdir | 952 | ** Program the I/O Pdir |