aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Ahern <dsahern@gmail.com>2011-11-13 13:30:08 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2011-11-28 08:45:53 -0500
commitc8e6672035e84799e6167e933fafedc8e3256973 (patch)
tree6c69ce411ffdf9742153c9e861f3dd084201a8c1
parent1758af10cf13d156014035b29ff50eab3773d849 (diff)
perf tools: make -C consistent across commands (for cpu list arg)
Currently the meaning of -C varies by perf command: for perf-top, perf-stat, perf-record it means cpu list. For perf-report it means comm list. Then perf-annotate, perf-report and perf-script use -c for cpu list. Fix annotate, report and script to use -C for cpu list to be consistent with top, stat and record. This means report needs to use -c for comm list which does introduce a backward compatibility change. v1 -> v2 - update perf-script.txt too Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1321209008-7004-1-git-send-email-dsahern@gmail.com Signed-off-by: David Ahern <dsahern@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/Documentation/perf-annotate.txt2
-rw-r--r--tools/perf/Documentation/perf-report.txt4
-rw-r--r--tools/perf/Documentation/perf-script.txt2
-rw-r--r--tools/perf/builtin-annotate.c2
-rw-r--r--tools/perf/builtin-report.c4
-rw-r--r--tools/perf/builtin-script.c2
6 files changed, 8 insertions, 8 deletions
diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt
index fe6762ed56bd..476029d30621 100644
--- a/tools/perf/Documentation/perf-annotate.txt
+++ b/tools/perf/Documentation/perf-annotate.txt
@@ -66,7 +66,7 @@ OPTIONS
66 used. This interfaces starts by centering on the line with more 66 used. This interfaces starts by centering on the line with more
67 samples, TAB/UNTAB cycles through the lines with more samples. 67 samples, TAB/UNTAB cycles through the lines with more samples.
68 68
69-c:: 69-C::
70--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can 70--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
71 be provided as a comma-separated list with no space: 0,1. Ranges of 71 be provided as a comma-separated list with no space: 0,1. Ranges of
72 CPUs are specified with -: 0-2. Default is to report samples on all 72 CPUs are specified with -: 0-2. Default is to report samples on all
diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 212f24d672e1..dc85392a5ac7 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -39,7 +39,7 @@ OPTIONS
39-T:: 39-T::
40--threads:: 40--threads::
41 Show per-thread event counters 41 Show per-thread event counters
42-C:: 42-c::
43--comms=:: 43--comms=::
44 Only consider symbols in these comms. CSV that understands 44 Only consider symbols in these comms. CSV that understands
45 file://filename entries. 45 file://filename entries.
@@ -128,7 +128,7 @@ OPTIONS
128--symfs=<directory>:: 128--symfs=<directory>::
129 Look for files with symbols relative to this directory. 129 Look for files with symbols relative to this directory.
130 130
131-c:: 131-C::
132--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can 132--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
133 be provided as a comma-separated list with no space: 0,1. Ranges of 133 be provided as a comma-separated list with no space: 0,1. Ranges of
134 CPUs are specified with -: 0-2. Default is to report samples on all 134 CPUs are specified with -: 0-2. Default is to report samples on all
diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
index dec87ecb530e..3613b0a1aff2 100644
--- a/tools/perf/Documentation/perf-script.txt
+++ b/tools/perf/Documentation/perf-script.txt
@@ -182,7 +182,7 @@ OPTIONS
182--hide-call-graph:: 182--hide-call-graph::
183 When printing symbols do not display call chain. 183 When printing symbols do not display call chain.
184 184
185-c:: 185-C::
186--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can 186--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
187 be provided as a comma-separated list with no space: 0,1. Ranges of 187 be provided as a comma-separated list with no space: 0,1. Ranges of
188 CPUs are specified with -: 0-2. Default is to report samples on all 188 CPUs are specified with -: 0-2. Default is to report samples on all
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index c01139fa4a10..d449645c5ef1 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -274,7 +274,7 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __used)
274 "print matching source lines (may be slow)"), 274 "print matching source lines (may be slow)"),
275 OPT_BOOLEAN('P', "full-paths", &annotate.full_paths, 275 OPT_BOOLEAN('P', "full-paths", &annotate.full_paths,
276 "Don't shorten the displayed pathnames"), 276 "Don't shorten the displayed pathnames"),
277 OPT_STRING('c', "cpu", &annotate.cpu_list, "cpu", "list of cpus to profile"), 277 OPT_STRING('C', "cpu", &annotate.cpu_list, "cpu", "list of cpus to profile"),
278 OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory", 278 OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
279 "Look for files with symbols relative to this directory"), 279 "Look for files with symbols relative to this directory"),
280 OPT_BOOLEAN(0, "source", &symbol_conf.annotate_src, 280 OPT_BOOLEAN(0, "source", &symbol_conf.annotate_src,
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index eef8e423deb0..ece7c5d3f504 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -492,7 +492,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
492 "alias for inverted call graph"), 492 "alias for inverted call graph"),
493 OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]", 493 OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
494 "only consider symbols in these dsos"), 494 "only consider symbols in these dsos"),
495 OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]", 495 OPT_STRING('c', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
496 "only consider symbols in these comms"), 496 "only consider symbols in these comms"),
497 OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]", 497 OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
498 "only consider these symbols"), 498 "only consider these symbols"),
@@ -506,7 +506,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
506 "Only display entries resolved to a symbol"), 506 "Only display entries resolved to a symbol"),
507 OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory", 507 OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
508 "Look for files with symbols relative to this directory"), 508 "Look for files with symbols relative to this directory"),
509 OPT_STRING('c', "cpu", &report.cpu_list, "cpu", 509 OPT_STRING('C', "cpu", &report.cpu_list, "cpu",
510 "list of cpus to profile"), 510 "list of cpus to profile"),
511 OPT_BOOLEAN('I', "show-info", &report.show_full_info, 511 OPT_BOOLEAN('I', "show-info", &report.show_full_info,
512 "Display extended information about perf.data file"), 512 "Display extended information about perf.data file"),
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 5f8afc65d5f3..7731a09e975c 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -1085,7 +1085,7 @@ static const struct option options[] = {
1085 OPT_CALLBACK('f', "fields", NULL, "str", 1085 OPT_CALLBACK('f', "fields", NULL, "str",
1086 "comma separated output fields prepend with 'type:'. Valid types: hw,sw,trace,raw. Fields: comm,tid,pid,time,cpu,event,trace,ip,sym,dso,addr", 1086 "comma separated output fields prepend with 'type:'. Valid types: hw,sw,trace,raw. Fields: comm,tid,pid,time,cpu,event,trace,ip,sym,dso,addr",
1087 parse_output_fields), 1087 parse_output_fields),
1088 OPT_STRING('c', "cpu", &cpu_list, "cpu", "list of cpus to profile"), 1088 OPT_STRING('C', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
1089 OPT_BOOLEAN('I', "show-info", &show_full_info, 1089 OPT_BOOLEAN('I', "show-info", &show_full_info,
1090 "display extended information from perf.data file"), 1090 "display extended information from perf.data file"),
1091 OPT_END() 1091 OPT_END()