diff options
author | Adrian Bunk <bunk@stusta.de> | 2006-11-30 20:22:29 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-12-03 00:31:51 -0500 |
commit | f5b99bcdddfb2338227faad3489c24907f37ee8e (patch) | |
tree | ab12dd443300df741e388ca80df0860dc65d24b0 | |
parent | 2718aa7c55ba7264dd463b8f7006f0975366fa7b (diff) |
[NET]: Possible cleanups.
This patch contains the following possible cleanups:
- make the following needlessly global functions statis:
- ipv4/tcp.c: __tcp_alloc_md5sig_pool()
- ipv4/tcp_ipv4.c: tcp_v4_reqsk_md5_lookup()
- ipv4/udplite.c: udplite_rcv()
- ipv4/udplite.c: udplite_err()
- make the following needlessly global structs static:
- ipv4/tcp_ipv4.c: tcp_request_sock_ipv4_ops
- ipv4/tcp_ipv4.c: tcp_sock_ipv4_specific
- ipv6/tcp_ipv6.c: tcp_request_sock_ipv6_ops
- net/ipv{4,6}/udplite.c: remove inline's from static functions
(gcc should know best when to inline them)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/tcp.c | 2 | ||||
-rw-r--r-- | net/ipv4/tcp_ipv4.c | 8 | ||||
-rw-r--r-- | net/ipv4/udplite.c | 10 | ||||
-rw-r--r-- | net/ipv6/tcp_ipv6.c | 2 | ||||
-rw-r--r-- | net/ipv6/udplite.c | 10 |
5 files changed, 16 insertions, 16 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index a6b228914b8e..090c690627e5 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c | |||
@@ -2278,7 +2278,7 @@ void tcp_free_md5sig_pool(void) | |||
2278 | 2278 | ||
2279 | EXPORT_SYMBOL(tcp_free_md5sig_pool); | 2279 | EXPORT_SYMBOL(tcp_free_md5sig_pool); |
2280 | 2280 | ||
2281 | struct tcp_md5sig_pool **__tcp_alloc_md5sig_pool(void) | 2281 | static struct tcp_md5sig_pool **__tcp_alloc_md5sig_pool(void) |
2282 | { | 2282 | { |
2283 | int cpu; | 2283 | int cpu; |
2284 | struct tcp_md5sig_pool **pool; | 2284 | struct tcp_md5sig_pool **pool; |
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index dd3509a59fe0..7684297d80aa 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
@@ -840,8 +840,8 @@ struct tcp_md5sig_key *tcp_v4_md5_lookup(struct sock *sk, | |||
840 | 840 | ||
841 | EXPORT_SYMBOL(tcp_v4_md5_lookup); | 841 | EXPORT_SYMBOL(tcp_v4_md5_lookup); |
842 | 842 | ||
843 | struct tcp_md5sig_key *tcp_v4_reqsk_md5_lookup(struct sock *sk, | 843 | static struct tcp_md5sig_key *tcp_v4_reqsk_md5_lookup(struct sock *sk, |
844 | struct request_sock *req) | 844 | struct request_sock *req) |
845 | { | 845 | { |
846 | return tcp_v4_md5_do_lookup(sk, inet_rsk(req)->rmt_addr); | 846 | return tcp_v4_md5_do_lookup(sk, inet_rsk(req)->rmt_addr); |
847 | } | 847 | } |
@@ -1233,7 +1233,7 @@ struct request_sock_ops tcp_request_sock_ops __read_mostly = { | |||
1233 | .send_reset = tcp_v4_send_reset, | 1233 | .send_reset = tcp_v4_send_reset, |
1234 | }; | 1234 | }; |
1235 | 1235 | ||
1236 | struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = { | 1236 | static struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = { |
1237 | #ifdef CONFIG_TCP_MD5SIG | 1237 | #ifdef CONFIG_TCP_MD5SIG |
1238 | .md5_lookup = tcp_v4_reqsk_md5_lookup, | 1238 | .md5_lookup = tcp_v4_reqsk_md5_lookup, |
1239 | #endif | 1239 | #endif |
@@ -1820,7 +1820,7 @@ struct inet_connection_sock_af_ops ipv4_specific = { | |||
1820 | #endif | 1820 | #endif |
1821 | }; | 1821 | }; |
1822 | 1822 | ||
1823 | struct tcp_sock_af_ops tcp_sock_ipv4_specific = { | 1823 | static struct tcp_sock_af_ops tcp_sock_ipv4_specific = { |
1824 | #ifdef CONFIG_TCP_MD5SIG | 1824 | #ifdef CONFIG_TCP_MD5SIG |
1825 | .md5_lookup = tcp_v4_md5_lookup, | 1825 | .md5_lookup = tcp_v4_md5_lookup, |
1826 | .calc_md5_hash = tcp_v4_calc_md5_hash, | 1826 | .calc_md5_hash = tcp_v4_calc_md5_hash, |
diff --git a/net/ipv4/udplite.c b/net/ipv4/udplite.c index 561de6d8c734..b28fe1edf98b 100644 --- a/net/ipv4/udplite.c +++ b/net/ipv4/udplite.c | |||
@@ -18,23 +18,23 @@ DEFINE_SNMP_STAT(struct udp_mib, udplite_statistics) __read_mostly; | |||
18 | struct hlist_head udplite_hash[UDP_HTABLE_SIZE]; | 18 | struct hlist_head udplite_hash[UDP_HTABLE_SIZE]; |
19 | static int udplite_port_rover; | 19 | static int udplite_port_rover; |
20 | 20 | ||
21 | __inline__ int udplite_get_port(struct sock *sk, unsigned short p, | 21 | int udplite_get_port(struct sock *sk, unsigned short p, |
22 | int (*c)(const struct sock *, const struct sock *)) | 22 | int (*c)(const struct sock *, const struct sock *)) |
23 | { | 23 | { |
24 | return __udp_lib_get_port(sk, p, udplite_hash, &udplite_port_rover, c); | 24 | return __udp_lib_get_port(sk, p, udplite_hash, &udplite_port_rover, c); |
25 | } | 25 | } |
26 | 26 | ||
27 | static __inline__ int udplite_v4_get_port(struct sock *sk, unsigned short snum) | 27 | static int udplite_v4_get_port(struct sock *sk, unsigned short snum) |
28 | { | 28 | { |
29 | return udplite_get_port(sk, snum, ipv4_rcv_saddr_equal); | 29 | return udplite_get_port(sk, snum, ipv4_rcv_saddr_equal); |
30 | } | 30 | } |
31 | 31 | ||
32 | __inline__ int udplite_rcv(struct sk_buff *skb) | 32 | static int udplite_rcv(struct sk_buff *skb) |
33 | { | 33 | { |
34 | return __udp4_lib_rcv(skb, udplite_hash, 1); | 34 | return __udp4_lib_rcv(skb, udplite_hash, 1); |
35 | } | 35 | } |
36 | 36 | ||
37 | __inline__ void udplite_err(struct sk_buff *skb, u32 info) | 37 | static void udplite_err(struct sk_buff *skb, u32 info) |
38 | { | 38 | { |
39 | return __udp4_lib_err(skb, info, udplite_hash); | 39 | return __udp4_lib_err(skb, info, udplite_hash); |
40 | } | 40 | } |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 517c50024bfc..dd1a23b5a0f5 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
@@ -929,7 +929,7 @@ static struct request_sock_ops tcp6_request_sock_ops __read_mostly = { | |||
929 | .send_reset = tcp_v6_send_reset | 929 | .send_reset = tcp_v6_send_reset |
930 | }; | 930 | }; |
931 | 931 | ||
932 | struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = { | 932 | static struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = { |
933 | #ifdef CONFIG_TCP_MD5SIG | 933 | #ifdef CONFIG_TCP_MD5SIG |
934 | .md5_lookup = tcp_v6_reqsk_md5_lookup, | 934 | .md5_lookup = tcp_v6_reqsk_md5_lookup, |
935 | #endif | 935 | #endif |
diff --git a/net/ipv6/udplite.c b/net/ipv6/udplite.c index d4cafacc235b..629f97162fbc 100644 --- a/net/ipv6/udplite.c +++ b/net/ipv6/udplite.c | |||
@@ -17,14 +17,14 @@ | |||
17 | 17 | ||
18 | DEFINE_SNMP_STAT(struct udp_mib, udplite_stats_in6) __read_mostly; | 18 | DEFINE_SNMP_STAT(struct udp_mib, udplite_stats_in6) __read_mostly; |
19 | 19 | ||
20 | static __inline__ int udplitev6_rcv(struct sk_buff **pskb) | 20 | static int udplitev6_rcv(struct sk_buff **pskb) |
21 | { | 21 | { |
22 | return __udp6_lib_rcv(pskb, udplite_hash, 1); | 22 | return __udp6_lib_rcv(pskb, udplite_hash, 1); |
23 | } | 23 | } |
24 | 24 | ||
25 | static __inline__ void udplitev6_err(struct sk_buff *skb, | 25 | static void udplitev6_err(struct sk_buff *skb, |
26 | struct inet6_skb_parm *opt, | 26 | struct inet6_skb_parm *opt, |
27 | int type, int code, int offset, __be32 info) | 27 | int type, int code, int offset, __be32 info) |
28 | { | 28 | { |
29 | return __udp6_lib_err(skb, opt, type, code, offset, info, udplite_hash); | 29 | return __udp6_lib_err(skb, opt, type, code, offset, info, udplite_hash); |
30 | } | 30 | } |
@@ -35,7 +35,7 @@ static struct inet6_protocol udplitev6_protocol = { | |||
35 | .flags = INET6_PROTO_NOPOLICY|INET6_PROTO_FINAL, | 35 | .flags = INET6_PROTO_NOPOLICY|INET6_PROTO_FINAL, |
36 | }; | 36 | }; |
37 | 37 | ||
38 | static __inline__ int udplite_v6_get_port(struct sock *sk, unsigned short snum) | 38 | static int udplite_v6_get_port(struct sock *sk, unsigned short snum) |
39 | { | 39 | { |
40 | return udplite_get_port(sk, snum, ipv6_rcv_saddr_equal); | 40 | return udplite_get_port(sk, snum, ipv6_rcv_saddr_equal); |
41 | } | 41 | } |