diff options
author | Michal Miroslaw <mirq-linux@rere.qmqm.pl> | 2007-03-23 14:11:31 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:27:38 -0400 |
commit | f414c16c04b1c998e90370791f9a728e292146ea (patch) | |
tree | f7bd0d8f678fdea9526a5557683fb2511101f8dc | |
parent | 55b5a91e1723280570957990a0c5ab8c3ec4090a (diff) |
[NETFILTER]: nfnetlink_log: micro-optimization for inst==NULL in nfulnl_recv_config()
Simple micro-optimization: don't call instance_put() on known NULL pointers.
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/netfilter/nfnetlink_log.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index d14cf514160f..d4b45e28ebde 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c | |||
@@ -810,13 +810,13 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, | |||
810 | NETLINK_CB(skb).pid); | 810 | NETLINK_CB(skb).pid); |
811 | if (!inst) { | 811 | if (!inst) { |
812 | ret = -EINVAL; | 812 | ret = -EINVAL; |
813 | goto out_put; | 813 | goto out; |
814 | } | 814 | } |
815 | break; | 815 | break; |
816 | case NFULNL_CFG_CMD_UNBIND: | 816 | case NFULNL_CFG_CMD_UNBIND: |
817 | if (!inst) { | 817 | if (!inst) { |
818 | ret = -ENODEV; | 818 | ret = -ENODEV; |
819 | goto out_put; | 819 | goto out; |
820 | } | 820 | } |
821 | 821 | ||
822 | if (inst->peer_pid != NETLINK_CB(skb).pid) { | 822 | if (inst->peer_pid != NETLINK_CB(skb).pid) { |
@@ -849,7 +849,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, | |||
849 | "group=%u pid=%u =>ENOENT\n", | 849 | "group=%u pid=%u =>ENOENT\n", |
850 | group_num, NETLINK_CB(skb).pid); | 850 | group_num, NETLINK_CB(skb).pid); |
851 | ret = -ENOENT; | 851 | ret = -ENOENT; |
852 | goto out_put; | 852 | goto out; |
853 | } | 853 | } |
854 | 854 | ||
855 | if (inst->peer_pid != NETLINK_CB(skb).pid) { | 855 | if (inst->peer_pid != NETLINK_CB(skb).pid) { |