diff options
author | J. Bruce Fields <bfields@fieldses.org> | 2006-03-20 23:24:13 -0500 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2006-03-20 23:24:13 -0500 |
commit | f3ee439f43381e45b191cf721b4a51d41f33301f (patch) | |
tree | 1ac11992c5ec5669c0d6ed68a9881dd51a01220f | |
parent | eaa82edf20d738a7ae31f4b0a5f72f64c14a58df (diff) |
LOCKD: nlmsvc_traverse_blocks return is unused
Note that we never return non-zero.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | fs/lockd/svclock.c | 3 | ||||
-rw-r--r-- | fs/lockd/svcsubs.c | 5 | ||||
-rw-r--r-- | include/linux/lockd/lockd.h | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c index ce754efe2841..d2b66bad7d50 100644 --- a/fs/lockd/svclock.c +++ b/fs/lockd/svclock.c | |||
@@ -309,14 +309,13 @@ restart: | |||
309 | * Loop over all blocks and perform the action specified. | 309 | * Loop over all blocks and perform the action specified. |
310 | * (NLM_ACT_CHECK handled by nlmsvc_inspect_file). | 310 | * (NLM_ACT_CHECK handled by nlmsvc_inspect_file). |
311 | */ | 311 | */ |
312 | int | 312 | void |
313 | nlmsvc_traverse_blocks(struct nlm_host *host, struct nlm_file *file, int action) | 313 | nlmsvc_traverse_blocks(struct nlm_host *host, struct nlm_file *file, int action) |
314 | { | 314 | { |
315 | if (action == NLM_ACT_MARK) | 315 | if (action == NLM_ACT_MARK) |
316 | nlmsvc_act_mark(host, file); | 316 | nlmsvc_act_mark(host, file); |
317 | else | 317 | else |
318 | nlmsvc_act_unlock(host, file); | 318 | nlmsvc_act_unlock(host, file); |
319 | return 0; | ||
320 | } | 319 | } |
321 | 320 | ||
322 | /* | 321 | /* |
diff --git a/fs/lockd/svcsubs.c b/fs/lockd/svcsubs.c index 601e5b3dfe20..2043011a1a2d 100644 --- a/fs/lockd/svcsubs.c +++ b/fs/lockd/svcsubs.c | |||
@@ -224,8 +224,9 @@ nlm_inspect_file(struct nlm_host *host, struct nlm_file *file, int action) | |||
224 | if (file->f_count || file->f_blocks || file->f_shares) | 224 | if (file->f_count || file->f_blocks || file->f_shares) |
225 | return 1; | 225 | return 1; |
226 | } else { | 226 | } else { |
227 | if (nlmsvc_traverse_blocks(host, file, action) | 227 | nlmsvc_traverse_blocks(host, file, action); |
228 | || nlmsvc_traverse_shares(host, file, action)) | 228 | |
229 | if (nlmsvc_traverse_shares(host, file, action)) | ||
229 | return 1; | 230 | return 1; |
230 | } | 231 | } |
231 | return nlm_traverse_locks(host, file, action); | 232 | return nlm_traverse_locks(host, file, action); |
diff --git a/include/linux/lockd/lockd.h b/include/linux/lockd/lockd.h index a04137d0c5de..995f89dc8c04 100644 --- a/include/linux/lockd/lockd.h +++ b/include/linux/lockd/lockd.h | |||
@@ -183,7 +183,7 @@ u32 nlmsvc_testlock(struct nlm_file *, struct nlm_lock *, | |||
183 | struct nlm_lock *); | 183 | struct nlm_lock *); |
184 | u32 nlmsvc_cancel_blocked(struct nlm_file *, struct nlm_lock *); | 184 | u32 nlmsvc_cancel_blocked(struct nlm_file *, struct nlm_lock *); |
185 | unsigned long nlmsvc_retry_blocked(void); | 185 | unsigned long nlmsvc_retry_blocked(void); |
186 | int nlmsvc_traverse_blocks(struct nlm_host *, struct nlm_file *, | 186 | void nlmsvc_traverse_blocks(struct nlm_host *, struct nlm_file *, |
187 | int action); | 187 | int action); |
188 | void nlmsvc_grant_reply(struct svc_rqst *, struct nlm_cookie *, u32); | 188 | void nlmsvc_grant_reply(struct svc_rqst *, struct nlm_cookie *, u32); |
189 | 189 | ||