diff options
author | Lai Jiangshan <laijs@cn.fujitsu.com> | 2009-03-30 01:48:00 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-04-07 07:59:23 -0400 |
commit | cf8e3474654f20433aab9aa35826d43b5f245008 (patch) | |
tree | bbb3e87ca324ae4192fd524c0777047ee075c5d9 | |
parent | 301fd748e2c81e78e74edbc694a64caa7b95dda2 (diff) |
tracing: fix incorrect return type of ns2usecs()
Impact: fix time output bug in 32bits system
ns2usecs() returns 'long', it's incorrect.
(In i386)
...
<idle>-0 [000] 521.442100: _spin_lock <-tick_do_update_jiffies64
<idle>-0 [000] 521.442101: do_timer <-tick_do_update_jiffies64
<idle>-0 [000] 521.442102: update_wall_time <-do_timer
<idle>-0 [000] 521.442102: update_xtime_cache <-update_wall_time
....
(It always print the time less than 2200 seconds besides ...)
Because 'long' is 32bits in i386. ( (1<<31) useconds is about 2200 seconds)
...
<idle>-0 [001] 4154502640.134759: rcu_bh_qsctr_inc <-__do_softirq
<idle>-0 [001] 4154502640.134760: _local_bh_enable <-__do_softirq
<idle>-0 [001] 4154502640.134761: idle_cpu <-irq_exit
...
(very large value)
Because 'long' is a signed type and it is 32bits in i386.
Changes in v2:
return 'unsigned long long' instead of 'cycle_t'
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
LKML-Reference: <49D05D10.4030009@cn.fujitsu.com>
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | kernel/trace/trace.c | 3 | ||||
-rw-r--r-- | kernel/trace/trace.h | 2 | ||||
-rw-r--r-- | kernel/trace/trace_output.c | 2 |
3 files changed, 3 insertions, 4 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index a0174a40c563..457dd8c97e0d 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
@@ -147,8 +147,7 @@ static int __init set_ftrace_dump_on_oops(char *str) | |||
147 | } | 147 | } |
148 | __setup("ftrace_dump_on_oops", set_ftrace_dump_on_oops); | 148 | __setup("ftrace_dump_on_oops", set_ftrace_dump_on_oops); |
149 | 149 | ||
150 | long | 150 | unsigned long long ns2usecs(cycle_t nsec) |
151 | ns2usecs(cycle_t nsec) | ||
152 | { | 151 | { |
153 | nsec += 500; | 152 | nsec += 500; |
154 | do_div(nsec, 1000); | 153 | do_div(nsec, 1000); |
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index cb0ce3fc36d3..0d81a4a2a4a5 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h | |||
@@ -596,7 +596,7 @@ extern int trace_selftest_startup_branch(struct tracer *trace, | |||
596 | #endif /* CONFIG_FTRACE_STARTUP_TEST */ | 596 | #endif /* CONFIG_FTRACE_STARTUP_TEST */ |
597 | 597 | ||
598 | extern void *head_page(struct trace_array_cpu *data); | 598 | extern void *head_page(struct trace_array_cpu *data); |
599 | extern long ns2usecs(cycle_t nsec); | 599 | extern unsigned long long ns2usecs(cycle_t nsec); |
600 | extern int | 600 | extern int |
601 | trace_vbprintk(unsigned long ip, const char *fmt, va_list args); | 601 | trace_vbprintk(unsigned long ip, const char *fmt, va_list args); |
602 | extern int | 602 | extern int |
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index d72b9a63b247..64b54a59c55b 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c | |||
@@ -423,7 +423,7 @@ int trace_print_lat_context(struct trace_iterator *iter) | |||
423 | 423 | ||
424 | trace_find_cmdline(entry->pid, comm); | 424 | trace_find_cmdline(entry->pid, comm); |
425 | 425 | ||
426 | ret = trace_seq_printf(s, "%16s %5d %3d %d %08x %08lx [%08lx]" | 426 | ret = trace_seq_printf(s, "%16s %5d %3d %d %08x %08lx [%08llx]" |
427 | " %ld.%03ldms (+%ld.%03ldms): ", comm, | 427 | " %ld.%03ldms (+%ld.%03ldms): ", comm, |
428 | entry->pid, iter->cpu, entry->flags, | 428 | entry->pid, iter->cpu, entry->flags, |
429 | entry->preempt_count, iter->idx, | 429 | entry->preempt_count, iter->idx, |