aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Lamparter <chunkeey@web.de>2008-11-24 08:52:51 -0500
committerJohn W. Linville <linville@tuxdriver.com>2008-11-26 09:47:50 -0500
commitb50563a68520dea3a19b5a8013c4ae0f8e3b49dd (patch)
tree81f8758265cf29f050b922fe167fea2367f6e17b
parent99405f930fda280c9114b15e178902cd204f967f (diff)
p54: fix wmm queue settings
This patch fixes a regression (introduced by "p54: more definitions form lmac_longbow.h and pda.h") It turned out that the "ret" variable wasn't initialized and this caused the following warnings/errors to appear: wmaster1: failed to set TX queue parameters for queue 2 wmaster1: failed to set TX queue parameters for queue 3 wmaster1: failed to set TX queue parameters for queue 1 wmaster1: failed to set TX queue parameters for queue 0 Signed-off-by: Christian Lamparter <chunkeey@web.de> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/p54/p54common.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
index 829b3f916db9..602392628e4e 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -1728,10 +1728,9 @@ static int p54_conf_tx(struct ieee80211_hw *dev, u16 queue,
1728 if ((params) && !(queue > 4)) { 1728 if ((params) && !(queue > 4)) {
1729 P54_SET_QUEUE(priv->qos_params[queue], params->aifs, 1729 P54_SET_QUEUE(priv->qos_params[queue], params->aifs,
1730 params->cw_min, params->cw_max, params->txop); 1730 params->cw_min, params->cw_max, params->txop);
1731 ret = p54_set_edcf(dev);
1731 } else 1732 } else
1732 ret = -EINVAL; 1733 ret = -EINVAL;
1733 if (!ret)
1734 ret = p54_set_edcf(dev);
1735 mutex_unlock(&priv->conf_mutex); 1734 mutex_unlock(&priv->conf_mutex);
1736 return ret; 1735 return ret;
1737} 1736}