aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederic Weisbecker <fweisbec@gmail.com>2009-02-20 11:34:06 -0500
committerIngo Molnar <mingo@elte.hu>2009-02-20 13:30:04 -0500
commit91f73f90d97fa67effbb49e0a79c50cf26dfe324 (patch)
tree8b76397e3bf252c295547494872df6f1d6626023
parent64b36ca7f408e0bd45487c8c28f168f11f3b6dcd (diff)
tracing/markers: make markers select tracepoints
Sometimes it happens that KConfig dependencies are not handled like in the following scenario: - config A bool - config B bool depends on A - config C bool select B If one selects C, then it will select B without checking its dependency to A, if A hasn't been selected elsewhere, it will result in a build failure. This is what happens on the following build error: kernel/built-in.o: In function `marker_update_probe_range': (.text+0x52f64): undefined reference to `tracepoint_probe_register_noupdate' kernel/built-in.o: In function `marker_update_probe_range': (.text+0x52f74): undefined reference to `tracepoint_probe_unregister_noupdate' kernel/built-in.o: In function `marker_update_probe_range': (.text+0x52fb9): undefined reference to `tracepoint_probe_unregister_noupdate' kernel/built-in.o: In function `marker_update_probes': marker.c:(.text+0x530ba): undefined reference to `tracepoint_probe_update_all' CONFIG_KVM_TRACE will select CONFIG_MARKER, but the latter depends on CONFIG_TRACEPOINTS which will not be selected. Reported-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--init/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/init/Kconfig b/init/Kconfig
index f068071fcc5d..26b5bab6f6e8 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -945,7 +945,7 @@ config TRACEPOINTS
945 945
946config MARKERS 946config MARKERS
947 bool "Activate markers" 947 bool "Activate markers"
948 depends on TRACEPOINTS 948 select TRACEPOINTS
949 help 949 help
950 Place an empty function call at each marker site. Can be 950 Place an empty function call at each marker site. Can be
951 dynamically changed for a probe function. 951 dynamically changed for a probe function.