diff options
author | Ingo Molnar <mingo@elte.hu> | 2008-03-03 07:53:58 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-03-03 08:18:27 -0500 |
commit | 902955fc13259dcec1321d45251a477977fcba39 (patch) | |
tree | e9812c743b2e0f601486c9bb64525f24d4ac0fc4 | |
parent | 9b5cf48b06a52c04b85c88642c3b620db8e1d592 (diff) |
x86: revert "x86: fix pmd_bad and pud_bad to support huge pages"
revert commit cded932b75ab0a5f9181ee3da34a0a488d1a14fd,
"x86: fix pmd_bad and pud_bad to support huge pages", it causes
a bootup hang, as reported and bisected by Arjan van de Ven.
Bisected-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | include/asm-x86/pgtable_32.h | 4 | ||||
-rw-r--r-- | include/asm-x86/pgtable_64.h | 6 |
2 files changed, 3 insertions, 7 deletions
diff --git a/include/asm-x86/pgtable_32.h b/include/asm-x86/pgtable_32.h index b478efa971e0..a842c7222b1e 100644 --- a/include/asm-x86/pgtable_32.h +++ b/include/asm-x86/pgtable_32.h | |||
@@ -91,9 +91,7 @@ extern unsigned long pg0[]; | |||
91 | /* To avoid harmful races, pmd_none(x) should check only the lower when PAE */ | 91 | /* To avoid harmful races, pmd_none(x) should check only the lower when PAE */ |
92 | #define pmd_none(x) (!(unsigned long)pmd_val(x)) | 92 | #define pmd_none(x) (!(unsigned long)pmd_val(x)) |
93 | #define pmd_present(x) (pmd_val(x) & _PAGE_PRESENT) | 93 | #define pmd_present(x) (pmd_val(x) & _PAGE_PRESENT) |
94 | #define pmd_bad(x) ((pmd_val(x) \ | 94 | #define pmd_bad(x) ((pmd_val(x) & (~PAGE_MASK & ~_PAGE_USER)) != _KERNPG_TABLE) |
95 | & ~(PAGE_MASK | _PAGE_USER | _PAGE_PSE | _PAGE_NX)) \ | ||
96 | != _KERNPG_TABLE) | ||
97 | 95 | ||
98 | 96 | ||
99 | #define pages_to_mb(x) ((x) >> (20-PAGE_SHIFT)) | 97 | #define pages_to_mb(x) ((x) >> (20-PAGE_SHIFT)) |
diff --git a/include/asm-x86/pgtable_64.h b/include/asm-x86/pgtable_64.h index 0a9258333cbd..0a0b77bc736a 100644 --- a/include/asm-x86/pgtable_64.h +++ b/include/asm-x86/pgtable_64.h | |||
@@ -153,14 +153,12 @@ static inline unsigned long pgd_bad(pgd_t pgd) | |||
153 | 153 | ||
154 | static inline unsigned long pud_bad(pud_t pud) | 154 | static inline unsigned long pud_bad(pud_t pud) |
155 | { | 155 | { |
156 | return pud_val(pud) & | 156 | return pud_val(pud) & ~(PTE_MASK | _KERNPG_TABLE | _PAGE_USER); |
157 | ~(PTE_MASK | _KERNPG_TABLE | _PAGE_USER | _PAGE_PSE | _PAGE_NX); | ||
158 | } | 157 | } |
159 | 158 | ||
160 | static inline unsigned long pmd_bad(pmd_t pmd) | 159 | static inline unsigned long pmd_bad(pmd_t pmd) |
161 | { | 160 | { |
162 | return pmd_val(pmd) & | 161 | return pmd_val(pmd) & ~(PTE_MASK | _KERNPG_TABLE | _PAGE_USER); |
163 | ~(PTE_MASK | _KERNPG_TABLE | _PAGE_USER | _PAGE_PSE | _PAGE_NX); | ||
164 | } | 162 | } |
165 | 163 | ||
166 | #define pte_none(x) (!pte_val(x)) | 164 | #define pte_none(x) (!pte_val(x)) |