diff options
author | Joe Perches <joe@perches.com> | 2010-03-05 16:43:48 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-03-06 14:26:44 -0500 |
commit | 8f53a9b80f011080555c498d2ca2dc6b1a77c42c (patch) | |
tree | b4636535f12817c107ba8fc1932882984eee9e46 | |
parent | 849382948992cc6482c778b1e854c19368b60c05 (diff) |
scripts/checkpatch.pl: add WARN on sizeof(&foo)
sizeof(&foo) is frequently an error. Warn on its use.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3257d3d96767..309050f30874 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2572,6 +2572,11 @@ sub process { | |||
2572 | WARN("plain inline is preferred over $1\n" . $herecurr); | 2572 | WARN("plain inline is preferred over $1\n" . $herecurr); |
2573 | } | 2573 | } |
2574 | 2574 | ||
2575 | # check for sizeof(&) | ||
2576 | if ($line =~ /\bsizeof\s*\(\s*\&/) { | ||
2577 | WARN("sizeof(& should be avoided\n" . $herecurr); | ||
2578 | } | ||
2579 | |||
2575 | # check for new externs in .c files. | 2580 | # check for new externs in .c files. |
2576 | if ($realfile =~ /\.c$/ && defined $stat && | 2581 | if ($realfile =~ /\.c$/ && defined $stat && |
2577 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) | 2582 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |