diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-06-27 18:30:26 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-07-10 23:40:38 -0400 |
commit | 8a702bbb7ddaa2e78c17dbaaf48e3cd5943676f0 (patch) | |
tree | 82c49e57220dff3d801658a7d0d3eddfedb76758 | |
parent | 0df7fb74fbb709591301871a38aac7735a1d6583 (diff) |
SUNRPC: Suppress some noisy and unnecessary printk() calls in call_verify()
Convert them into dprintk() calls.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | net/sunrpc/clnt.c | 24 |
1 files changed, 15 insertions, 9 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 50af8bbe7f20..e1553cf2a68f 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c | |||
@@ -1315,9 +1315,9 @@ call_verify(struct rpc_task *task) | |||
1315 | * - if it isn't pointer subtraction in the NFS client may give | 1315 | * - if it isn't pointer subtraction in the NFS client may give |
1316 | * undefined results | 1316 | * undefined results |
1317 | */ | 1317 | */ |
1318 | printk(KERN_WARNING | 1318 | dprintk("RPC: %5u %s: XDR representation not a multiple of" |
1319 | "call_verify: XDR representation not a multiple of" | 1319 | " 4 bytes: 0x%x\n", task->tk_pid, __FUNCTION__, |
1320 | " 4 bytes: 0x%x\n", task->tk_rqstp->rq_rcv_buf.len); | 1320 | task->tk_rqstp->rq_rcv_buf.len); |
1321 | goto out_eio; | 1321 | goto out_eio; |
1322 | } | 1322 | } |
1323 | if ((len -= 3) < 0) | 1323 | if ((len -= 3) < 0) |
@@ -1325,7 +1325,8 @@ call_verify(struct rpc_task *task) | |||
1325 | p += 1; /* skip XID */ | 1325 | p += 1; /* skip XID */ |
1326 | 1326 | ||
1327 | if ((n = ntohl(*p++)) != RPC_REPLY) { | 1327 | if ((n = ntohl(*p++)) != RPC_REPLY) { |
1328 | printk(KERN_WARNING "call_verify: not an RPC reply: %x\n", n); | 1328 | dprintk("RPC: %5u %s: not an RPC reply: %x\n", |
1329 | task->tk_pid, __FUNCTION__, n); | ||
1329 | goto out_garbage; | 1330 | goto out_garbage; |
1330 | } | 1331 | } |
1331 | if ((n = ntohl(*p++)) != RPC_MSG_ACCEPTED) { | 1332 | if ((n = ntohl(*p++)) != RPC_MSG_ACCEPTED) { |
@@ -1376,7 +1377,8 @@ call_verify(struct rpc_task *task) | |||
1376 | "authentication.\n", task->tk_client->cl_server); | 1377 | "authentication.\n", task->tk_client->cl_server); |
1377 | break; | 1378 | break; |
1378 | default: | 1379 | default: |
1379 | printk(KERN_WARNING "call_verify: unknown auth error: %x\n", n); | 1380 | dprintk("RPC: %5u %s: unknown auth error: %x\n", |
1381 | task->tk_pid, __FUNCTION__, n); | ||
1380 | error = -EIO; | 1382 | error = -EIO; |
1381 | } | 1383 | } |
1382 | dprintk("RPC: %5u %s: call rejected %d\n", | 1384 | dprintk("RPC: %5u %s: call rejected %d\n", |
@@ -1384,7 +1386,8 @@ call_verify(struct rpc_task *task) | |||
1384 | goto out_err; | 1386 | goto out_err; |
1385 | } | 1387 | } |
1386 | if (!(p = rpcauth_checkverf(task, p))) { | 1388 | if (!(p = rpcauth_checkverf(task, p))) { |
1387 | printk(KERN_WARNING "call_verify: auth check failed\n"); | 1389 | dprintk("RPC: %5u %s: auth check failed\n", |
1390 | task->tk_pid, __FUNCTION__); | ||
1388 | goto out_garbage; /* bad verifier, retry */ | 1391 | goto out_garbage; /* bad verifier, retry */ |
1389 | } | 1392 | } |
1390 | len = p - (__be32 *)iov->iov_base - 1; | 1393 | len = p - (__be32 *)iov->iov_base - 1; |
@@ -1423,7 +1426,8 @@ call_verify(struct rpc_task *task) | |||
1423 | task->tk_pid, __FUNCTION__); | 1426 | task->tk_pid, __FUNCTION__); |
1424 | break; /* retry */ | 1427 | break; /* retry */ |
1425 | default: | 1428 | default: |
1426 | printk(KERN_WARNING "call_verify: server accept status: %x\n", n); | 1429 | dprintk("RPC: %5u %s: server accept status: %x\n", |
1430 | task->tk_pid, __FUNCTION__, n); | ||
1427 | /* Also retry */ | 1431 | /* Also retry */ |
1428 | } | 1432 | } |
1429 | 1433 | ||
@@ -1437,14 +1441,16 @@ out_garbage: | |||
1437 | out_retry: | 1441 | out_retry: |
1438 | return ERR_PTR(-EAGAIN); | 1442 | return ERR_PTR(-EAGAIN); |
1439 | } | 1443 | } |
1440 | printk(KERN_WARNING "RPC %s: retry failed, exit EIO\n", __FUNCTION__); | ||
1441 | out_eio: | 1444 | out_eio: |
1442 | error = -EIO; | 1445 | error = -EIO; |
1443 | out_err: | 1446 | out_err: |
1444 | rpc_exit(task, error); | 1447 | rpc_exit(task, error); |
1448 | dprintk("RPC: %5u %s: call failed with error %d\n", task->tk_pid, | ||
1449 | __FUNCTION__, error); | ||
1445 | return ERR_PTR(error); | 1450 | return ERR_PTR(error); |
1446 | out_overflow: | 1451 | out_overflow: |
1447 | printk(KERN_WARNING "RPC %s: server reply was truncated.\n", __FUNCTION__); | 1452 | dprintk("RPC: %5u %s: server reply was truncated.\n", task->tk_pid, |
1453 | __FUNCTION__); | ||
1448 | goto out_garbage; | 1454 | goto out_garbage; |
1449 | } | 1455 | } |
1450 | 1456 | ||