diff options
author | Michael S. Tsirkin <mst@mellanox.co.il> | 2006-02-07 19:39:26 -0500 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2006-02-07 19:39:26 -0500 |
commit | 7bcb974ef6a0ae903888272c92c66ea779388c01 (patch) | |
tree | 926245a2e120dd5884f3bab92020612fcfbd78bf | |
parent | 479a079663bd4c5f3d2714643b1b8c406aaba3e0 (diff) |
IPoIB: Fix another send-only join race
Further, there's an additional issue that I saw in testing:
ipoib_mcast_send may get called when priv->broadcast is NULL (e.g. if
the device was downed and then upped internally because of a port
event).
If this happends and the send-only join request gets completed before
priv->broadcast is set, we get an oops.
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index 1c7148208ce8..932bf139a65d 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c | |||
@@ -701,7 +701,7 @@ void ipoib_mcast_send(struct net_device *dev, union ib_gid *mgid, | |||
701 | */ | 701 | */ |
702 | spin_lock(&priv->lock); | 702 | spin_lock(&priv->lock); |
703 | 703 | ||
704 | if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags)) { | 704 | if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags) || !priv->broadcast) { |
705 | ++priv->stats.tx_dropped; | 705 | ++priv->stats.tx_dropped; |
706 | dev_kfree_skb_any(skb); | 706 | dev_kfree_skb_any(skb); |
707 | goto unlock; | 707 | goto unlock; |