aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael J. Wysocki <rjw@sisk.pl>2006-12-13 03:34:28 -0500
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-13 12:05:49 -0500
commit3df494a32b936aef76d893f5065f962ebd9b9437 (patch)
tree825a96b219eeb87ef7a627a2494cf4fa7cd4d03e
parent6a2d7a955d8de6cb19ed9cd194b3c83008a22c32 (diff)
[PATCH] PM: Fix freezing of stopped tasks
Currently, if a task is stopped (ie. it's in the TASK_STOPPED state), it is considered by the freezer as unfreezeable. However, there may be a race between the freezer and the delivery of the continuation signal to the task resulting in the task running after we have finished freezing the other tasks. This, in turn, may lead to undesirable effects up to and including data corruption. To prevent this from happening we first need to make the freezer consider stopped tasks as freezeable. For this purpose we need to make freezeable() stop returning 0 for these tasks and we need to force them to enter the refrigerator. However, if there's no continuation signal in the meantime, the stopped tasks should remain stopped after all processes have been thawed, so we need to send an additional SIGSTOP to each of them before waking it up. Also, a stopped task that has just been woken up should first check if there's a freezing request for it and go to the refrigerator if that's the case. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--kernel/power/process.c12
-rw-r--r--kernel/signal.c4
2 files changed, 9 insertions, 7 deletions
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 99eeb119b06d..b9a32860bef3 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -28,8 +28,7 @@ static inline int freezeable(struct task_struct * p)
28 if ((p == current) || 28 if ((p == current) ||
29 (p->flags & PF_NOFREEZE) || 29 (p->flags & PF_NOFREEZE) ||
30 (p->exit_state == EXIT_ZOMBIE) || 30 (p->exit_state == EXIT_ZOMBIE) ||
31 (p->exit_state == EXIT_DEAD) || 31 (p->exit_state == EXIT_DEAD))
32 (p->state == TASK_STOPPED))
33 return 0; 32 return 0;
34 return 1; 33 return 1;
35} 34}
@@ -61,9 +60,12 @@ static inline void freeze_process(struct task_struct *p)
61 unsigned long flags; 60 unsigned long flags;
62 61
63 if (!freezing(p)) { 62 if (!freezing(p)) {
63 if (p->state == TASK_STOPPED)
64 force_sig_specific(SIGSTOP, p);
65
64 freeze(p); 66 freeze(p);
65 spin_lock_irqsave(&p->sighand->siglock, flags); 67 spin_lock_irqsave(&p->sighand->siglock, flags);
66 signal_wake_up(p, 0); 68 signal_wake_up(p, p->state == TASK_STOPPED);
67 spin_unlock_irqrestore(&p->sighand->siglock, flags); 69 spin_unlock_irqrestore(&p->sighand->siglock, flags);
68 } 70 }
69} 71}
@@ -103,9 +105,7 @@ static unsigned int try_to_freeze_tasks(int freeze_user_space)
103 if (frozen(p)) 105 if (frozen(p))
104 continue; 106 continue;
105 107
106 if (p->state == TASK_TRACED && 108 if (p->state == TASK_TRACED && frozen(p->parent)) {
107 (frozen(p->parent) ||
108 p->parent->state == TASK_STOPPED)) {
109 cancel_freezing(p); 109 cancel_freezing(p);
110 continue; 110 continue;
111 } 111 }
diff --git a/kernel/signal.c b/kernel/signal.c
index 1921ffdc5e77..5630255d2e2a 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1705,7 +1705,9 @@ finish_stop(int stop_count)
1705 read_unlock(&tasklist_lock); 1705 read_unlock(&tasklist_lock);
1706 } 1706 }
1707 1707
1708 schedule(); 1708 do {
1709 schedule();
1710 } while (try_to_freeze());
1709 /* 1711 /*
1710 * Now we don't run again until continued. 1712 * Now we don't run again until continued.
1711 */ 1713 */