diff options
author | Robert P. J. Day <rpjday@mindspring.com> | 2007-02-10 04:45:52 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-11 13:51:31 -0500 |
commit | 3de3af130b75a79c7381573e5ea69cb59502023f (patch) | |
tree | 3c3f33898d84d16e5d75c1469338c1544870fd49 | |
parent | 100bb9349ea5cb4e667977de55bd6dc4ac7bc22f (diff) |
[PATCH] Remove unnecessary memset(0) calls after kzalloc() calls.
Delete the few remaining unnecessary calls to memset(0) after a call to
kzalloc().
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
Cc: Andi Kleen <ak@suse.de>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Adam Belay <ambx1@neo.rr.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | arch/x86_64/kernel/mce_amd.c | 2 | ||||
-rw-r--r-- | drivers/input/gameport/ns558.c | 1 | ||||
-rw-r--r-- | drivers/pnp/pnpbios/rsparser.c | 1 |
3 files changed, 0 insertions, 4 deletions
diff --git a/arch/x86_64/kernel/mce_amd.c b/arch/x86_64/kernel/mce_amd.c index fa09debad4b7..93c707257637 100644 --- a/arch/x86_64/kernel/mce_amd.c +++ b/arch/x86_64/kernel/mce_amd.c | |||
@@ -401,7 +401,6 @@ static __cpuinit int allocate_threshold_blocks(unsigned int cpu, | |||
401 | b = kzalloc(sizeof(struct threshold_block), GFP_KERNEL); | 401 | b = kzalloc(sizeof(struct threshold_block), GFP_KERNEL); |
402 | if (!b) | 402 | if (!b) |
403 | return -ENOMEM; | 403 | return -ENOMEM; |
404 | memset(b, 0, sizeof(struct threshold_block)); | ||
405 | 404 | ||
406 | b->block = block; | 405 | b->block = block; |
407 | b->bank = bank; | 406 | b->bank = bank; |
@@ -490,7 +489,6 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank) | |||
490 | err = -ENOMEM; | 489 | err = -ENOMEM; |
491 | goto out; | 490 | goto out; |
492 | } | 491 | } |
493 | memset(b, 0, sizeof(struct threshold_bank)); | ||
494 | 492 | ||
495 | kobject_set_name(&b->kobj, "threshold_bank%i", bank); | 493 | kobject_set_name(&b->kobj, "threshold_bank%i", bank); |
496 | b->kobj.parent = &per_cpu(device_mce, cpu).kobj; | 494 | b->kobj.parent = &per_cpu(device_mce, cpu).kobj; |
diff --git a/drivers/input/gameport/ns558.c b/drivers/input/gameport/ns558.c index f68dbe6f7f04..7b7a546323cf 100644 --- a/drivers/input/gameport/ns558.c +++ b/drivers/input/gameport/ns558.c | |||
@@ -151,7 +151,6 @@ static int ns558_isa_probe(int io) | |||
151 | return -ENOMEM; | 151 | return -ENOMEM; |
152 | } | 152 | } |
153 | 153 | ||
154 | memset(ns558, 0, sizeof(struct ns558)); | ||
155 | ns558->io = io; | 154 | ns558->io = io; |
156 | ns558->size = 1 << i; | 155 | ns558->size = 1 << i; |
157 | ns558->gameport = port; | 156 | ns558->gameport = port; |
diff --git a/drivers/pnp/pnpbios/rsparser.c b/drivers/pnp/pnpbios/rsparser.c index 95b79685a9d1..3c2ab8394e3f 100644 --- a/drivers/pnp/pnpbios/rsparser.c +++ b/drivers/pnp/pnpbios/rsparser.c | |||
@@ -530,7 +530,6 @@ pnpbios_parse_compatible_ids(unsigned char *p, unsigned char *end, struct pnp_de | |||
530 | dev_id = kzalloc(sizeof (struct pnp_id), GFP_KERNEL); | 530 | dev_id = kzalloc(sizeof (struct pnp_id), GFP_KERNEL); |
531 | if (!dev_id) | 531 | if (!dev_id) |
532 | return NULL; | 532 | return NULL; |
533 | memset(dev_id, 0, sizeof(struct pnp_id)); | ||
534 | pnpid32_to_pnpid(p[1] | p[2] << 8 | p[3] << 16 | p[4] << 24,id); | 533 | pnpid32_to_pnpid(p[1] | p[2] << 8 | p[3] << 16 | p[4] << 24,id); |
535 | memcpy(&dev_id->id, id, 7); | 534 | memcpy(&dev_id->id, id, 7); |
536 | pnp_add_id(dev_id, dev); | 535 | pnp_add_id(dev_id, dev); |