aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2009-10-08 11:50:55 -0400
committerTrond Myklebust <Trond.Myklebust@netapp.com>2009-10-08 11:50:55 -0400
commit3050141bae57984dd660e6861632ccf9b8bca77e (patch)
tree01d0829c1f46885543f93785190d55a3d6ef3203
parent517be09def6cd7bc231222ee756fde8ea245a6fe (diff)
NFSv4: Kill nfs4_renewd_prepare_shutdown()
The NFSv4 renew daemon is shared between all active super blocks that refer to a particular NFS server, so it is wrong to be shutting it down in nfs4_kill_super every time a super block is destroyed. This patch therefore kills nfs4_renewd_prepare_shutdown altogether, and leaves it up to nfs4_shutdown_client() to also shut down the renew daemon by means of the existing call to nfs4_kill_renewd(). Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--fs/nfs/nfs4renewd.c6
-rw-r--r--fs/nfs/super.c1
2 files changed, 0 insertions, 7 deletions
diff --git a/fs/nfs/nfs4renewd.c b/fs/nfs/nfs4renewd.c
index e27c6cef18f2..0156c01c212c 100644
--- a/fs/nfs/nfs4renewd.c
+++ b/fs/nfs/nfs4renewd.c
@@ -127,12 +127,6 @@ nfs4_schedule_state_renewal(struct nfs_client *clp)
127} 127}
128 128
129void 129void
130nfs4_renewd_prepare_shutdown(struct nfs_server *server)
131{
132 cancel_delayed_work(&server->nfs_client->cl_renewd);
133}
134
135void
136nfs4_kill_renewd(struct nfs_client *clp) 130nfs4_kill_renewd(struct nfs_client *clp)
137{ 131{
138 cancel_delayed_work_sync(&clp->cl_renewd); 132 cancel_delayed_work_sync(&clp->cl_renewd);
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index fb3b280cacfe..6dabf6feec94 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2689,7 +2689,6 @@ static void nfs4_kill_super(struct super_block *sb)
2689 dprintk("--> %s\n", __func__); 2689 dprintk("--> %s\n", __func__);
2690 nfs_super_return_all_delegations(sb); 2690 nfs_super_return_all_delegations(sb);
2691 kill_anon_super(sb); 2691 kill_anon_super(sb);
2692 nfs4_renewd_prepare_shutdown(server);
2693 nfs_fscache_release_super_cookie(sb); 2692 nfs_fscache_release_super_cookie(sb);
2694 nfs_free_server(server); 2693 nfs_free_server(server);
2695 dprintk("<-- %s\n", __func__); 2694 dprintk("<-- %s\n", __func__);