aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVivek Goyal <vgoyal@in.ibm.com>2006-09-26 04:52:27 -0400
committerAndi Kleen <andi@basil.nowhere.org>2006-09-26 04:52:27 -0400
commit260d6790b6a2a0a048b7f96d154c2b49f1e6515a (patch)
tree7cea68eacc941a73afa452fc1fe22c0b52986e6d
parent3f22c5789eb76fd9aabe4be37ba609c793f046f9 (diff)
[PATCH] i386: Kdump i386 nmi event notification fix
After a crash we should wait for NMI IPI event and not for external NMI or NMI watchdog tick. Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andi Kleen <ak@suse.de> Cc: Don Zickus <dzickus@redhat.com> Cc: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org>
-rw-r--r--arch/i386/kernel/crash.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c
index 736c76d6b31d..67d297dc1003 100644
--- a/arch/i386/kernel/crash.c
+++ b/arch/i386/kernel/crash.c
@@ -102,7 +102,7 @@ static int crash_nmi_callback(struct notifier_block *self,
102 struct pt_regs fixed_regs; 102 struct pt_regs fixed_regs;
103 int cpu; 103 int cpu;
104 104
105 if (val != DIE_NMI) 105 if (val != DIE_NMI_IPI)
106 return NOTIFY_OK; 106 return NOTIFY_OK;
107 107
108 regs = ((struct die_args *)data)->regs; 108 regs = ((struct die_args *)data)->regs;
@@ -113,7 +113,7 @@ static int crash_nmi_callback(struct notifier_block *self,
113 * an NMI if system was initially booted with nmi_watchdog parameter. 113 * an NMI if system was initially booted with nmi_watchdog parameter.
114 */ 114 */
115 if (cpu == crashing_cpu) 115 if (cpu == crashing_cpu)
116 return 1; 116 return NOTIFY_STOP;
117 local_irq_disable(); 117 local_irq_disable();
118 118
119 if (!user_mode_vm(regs)) { 119 if (!user_mode_vm(regs)) {