diff options
author | Sam Ravnborg <sam@saturn.ravnborg.org> | 2007-12-09 02:55:13 -0500 |
---|---|---|
committer | Sam Ravnborg <sam@saturn.ravnborg.org> | 2007-12-09 02:55:13 -0500 |
commit | 18c32dac75b187d1a4e858f3cfdf03e844129f5e (patch) | |
tree | c41a33a7077356c0e75fcbe40ecb49890d506051 | |
parent | 1cacc9ab8bf10e60b3ed93d7a10b070c4cbc6c9f (diff) |
kbuild: fix building with O=.. options
The check introduced in commit:
4f1127e204377cbd2a56d112d323466f668e8334 "kbuild: fix
infinite make recursion"
caused certain external modules not to build and
also caused 'make targz-pkg' to fail.
This is a minimal fix so we revert to previous
behaviour - but we do not overwrite the Makefile
in the top-level directory.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Tested-by: Jay Cliburn <jacliburn@bellsouth.net>
Cc: Jay Cliburn <jacliburn@bellsouth.net>
-rw-r--r-- | Makefile | 3 | ||||
-rw-r--r-- | scripts/mkmakefile | 6 |
2 files changed, 6 insertions, 3 deletions
@@ -118,9 +118,6 @@ saved-output := $(KBUILD_OUTPUT) | |||
118 | KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd) | 118 | KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd) |
119 | $(if $(KBUILD_OUTPUT),, \ | 119 | $(if $(KBUILD_OUTPUT),, \ |
120 | $(error output directory "$(saved-output)" does not exist)) | 120 | $(error output directory "$(saved-output)" does not exist)) |
121 | # Check that OUTPUT directory is not the same as where we have kernel src | ||
122 | $(if $(filter-out $(KBUILD_OUTPUT),$(shell /bin/pwd)),, \ | ||
123 | $(error Output directory (O=...) specifies kernel src dir)) | ||
124 | 121 | ||
125 | PHONY += $(MAKECMDGOALS) sub-make | 122 | PHONY += $(MAKECMDGOALS) sub-make |
126 | 123 | ||
diff --git a/scripts/mkmakefile b/scripts/mkmakefile index ee39facee152..9ad1bd793252 100644 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile | |||
@@ -11,6 +11,12 @@ | |||
11 | 11 | ||
12 | 12 | ||
13 | test ! -r $2/Makefile -o -O $2/Makefile || exit 0 | 13 | test ! -r $2/Makefile -o -O $2/Makefile || exit 0 |
14 | # Only overwrite automatically generated Makefiles | ||
15 | # (so we do not overwrite kernel Makefile) | ||
16 | if ! grep -q Automatically $2/Makefile | ||
17 | then | ||
18 | exit 0 | ||
19 | fi | ||
14 | echo " GEN $2/Makefile" | 20 | echo " GEN $2/Makefile" |
15 | 21 | ||
16 | cat << EOF > $2/Makefile | 22 | cat << EOF > $2/Makefile |