diff options
author | Ivan Kokshaysky <ink@jurassic.park.msu.ru> | 2005-09-23 00:06:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-23 11:05:16 -0400 |
commit | 12f44f46bc9c6dc79255e661b085797af395d8da (patch) | |
tree | cec3ab7b0bfd7f90fba01b6fb6ecb896eed00079 | |
parent | bfab08c097df5f6a60dd07f0f8c78c54e725780b (diff) |
[PATCH] pci: fixup parent subordinate busnr
I believe the change that broke things is introduction of
pci_fixup_parent_subordinate_busnr().
The patch here does two things:
- hunk #1 should fix the problems you've seen when you boot without
additional "pci" kernel options;
- hunk #2 supposedly fixes boot with "pci=assign-busses" option which
otherwise hangs Acer TM81xx machines as reported.
Please try this with and without "pci=assign-busses". If it boots,
I'd like to see 'lspci -vvx' for both cases.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/pci/probe.c | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index c77d5b1bbff6..005786416bb5 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c | |||
@@ -402,6 +402,12 @@ static void pci_enable_crs(struct pci_dev *dev) | |||
402 | static void __devinit pci_fixup_parent_subordinate_busnr(struct pci_bus *child, int max) | 402 | static void __devinit pci_fixup_parent_subordinate_busnr(struct pci_bus *child, int max) |
403 | { | 403 | { |
404 | struct pci_bus *parent = child->parent; | 404 | struct pci_bus *parent = child->parent; |
405 | |||
406 | /* Attempts to fix that up are really dangerous unless | ||
407 | we're going to re-assign all bus numbers. */ | ||
408 | if (!pcibios_assign_all_busses()) | ||
409 | return; | ||
410 | |||
405 | while (parent->parent && parent->subordinate < max) { | 411 | while (parent->parent && parent->subordinate < max) { |
406 | parent->subordinate = max; | 412 | parent->subordinate = max; |
407 | pci_write_config_byte(parent->self, PCI_SUBORDINATE_BUS, max); | 413 | pci_write_config_byte(parent->self, PCI_SUBORDINATE_BUS, max); |
@@ -478,8 +484,18 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max | |||
478 | * We need to assign a number to this bus which we always | 484 | * We need to assign a number to this bus which we always |
479 | * do in the second pass. | 485 | * do in the second pass. |
480 | */ | 486 | */ |
481 | if (!pass) | 487 | if (!pass) { |
488 | if (pcibios_assign_all_busses()) | ||
489 | /* Temporarily disable forwarding of the | ||
490 | configuration cycles on all bridges in | ||
491 | this bus segment to avoid possible | ||
492 | conflicts in the second pass between two | ||
493 | bridges programmed with overlapping | ||
494 | bus ranges. */ | ||
495 | pci_write_config_dword(dev, PCI_PRIMARY_BUS, | ||
496 | buses & ~0xffffff); | ||
482 | return max; | 497 | return max; |
498 | } | ||
483 | 499 | ||
484 | /* Clear errors */ | 500 | /* Clear errors */ |
485 | pci_write_config_word(dev, PCI_STATUS, 0xffff); | 501 | pci_write_config_word(dev, PCI_STATUS, 0xffff); |