diff options
| author | Axel Lin <axel.lin@gmail.com> | 2010-07-04 21:35:47 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-05 16:53:34 -0400 |
| commit | e3ed249af8cb2f73fc6ef5494d2ddef43fb0ff19 (patch) | |
| tree | 929b78904d87e976beaad97fe11d85934b8322a7 | |
| parent | 5b232f753a842fa66eab86e51dc76e3929d853af (diff) | |
dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit
smi_data_buf_free is called twice in current implementation.
The second call simply return because smi_data_buf is set to NULL in first call.
This patch removes the second smi_data_buf_free call.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/firmware/dcdbas.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c index aa9bc9e980e1..69ad529d92fb 100644 --- a/drivers/firmware/dcdbas.c +++ b/drivers/firmware/dcdbas.c | |||
| @@ -634,9 +634,6 @@ static void __exit dcdbas_exit(void) | |||
| 634 | * before platform_device_unregister | 634 | * before platform_device_unregister |
| 635 | */ | 635 | */ |
| 636 | unregister_reboot_notifier(&dcdbas_reboot_nb); | 636 | unregister_reboot_notifier(&dcdbas_reboot_nb); |
| 637 | smi_data_buf_free(); | ||
| 638 | platform_device_unregister(dcdbas_pdev); | ||
| 639 | platform_driver_unregister(&dcdbas_driver); | ||
| 640 | 637 | ||
| 641 | /* | 638 | /* |
| 642 | * We have to free the buffer here instead of dcdbas_remove | 639 | * We have to free the buffer here instead of dcdbas_remove |
| @@ -645,6 +642,8 @@ static void __exit dcdbas_exit(void) | |||
| 645 | * released. | 642 | * released. |
| 646 | */ | 643 | */ |
| 647 | smi_data_buf_free(); | 644 | smi_data_buf_free(); |
| 645 | platform_device_unregister(dcdbas_pdev); | ||
| 646 | platform_driver_unregister(&dcdbas_driver); | ||
| 648 | } | 647 | } |
| 649 | 648 | ||
| 650 | module_init(dcdbas_init); | 649 | module_init(dcdbas_init); |
