aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@stusta.de>2006-02-28 02:40:51 -0500
committerMauro Carvalho Chehab <mchehab@infradead.org>2006-03-03 10:15:29 -0500
commit8cbe84f33a8d420d8c8228599bc042cb31c569fa (patch)
tree041885dcbcb6db099fcd442e8d0f2c3c7f9c0883
parentd15549acfedd70b2bd97a5876ecd59527fa97671 (diff)
V4L/DVB (3399a): cpia2/cpia2_v4l.c cleanups
- make 2 needlessly global functions static - remove cpia2_setup(): the driver already allows setting parameters through module_param(), and there's no reason for having two different ways for setting the same parameters Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r--Documentation/video4linux/README.cpia22
-rw-r--r--drivers/media/video/cpia2/cpia2_v4l.c29
2 files changed, 3 insertions, 28 deletions
diff --git a/Documentation/video4linux/README.cpia2 b/Documentation/video4linux/README.cpia2
index f3bd3439ad91..ce8213d28b67 100644
--- a/Documentation/video4linux/README.cpia2
+++ b/Documentation/video4linux/README.cpia2
@@ -70,7 +70,7 @@ line like this:
70 70
71 If the driver is compiled into the kernel, at boot time specify them 71 If the driver is compiled into the kernel, at boot time specify them
72like this: 72like this:
73 cpia2=num_buffers:3,buffer_size:65535 73 cpia2.num_buffers=3 cpia2.buffer_size=65535
74 74
75 What buffer size should I use? 75 What buffer size should I use?
76 ------------------------------ 76 ------------------------------
diff --git a/drivers/media/video/cpia2/cpia2_v4l.c b/drivers/media/video/cpia2/cpia2_v4l.c
index 3480a2ca7cdc..589283d5ddd1 100644
--- a/drivers/media/video/cpia2/cpia2_v4l.c
+++ b/drivers/media/video/cpia2/cpia2_v4l.c
@@ -2053,7 +2053,7 @@ static void __init check_parameters(void)
2053 * cpia2_init/module_init 2053 * cpia2_init/module_init
2054 * 2054 *
2055 *****************************************************************************/ 2055 *****************************************************************************/
2056int __init cpia2_init(void) 2056static int __init cpia2_init(void)
2057{ 2057{
2058 LOG("%s v%d.%d.%d\n", 2058 LOG("%s v%d.%d.%d\n",
2059 ABOUT, CPIA2_MAJ_VER, CPIA2_MIN_VER, CPIA2_PATCH_VER); 2059 ABOUT, CPIA2_MAJ_VER, CPIA2_MIN_VER, CPIA2_PATCH_VER);
@@ -2068,37 +2068,12 @@ int __init cpia2_init(void)
2068 * cpia2_exit/module_exit 2068 * cpia2_exit/module_exit
2069 * 2069 *
2070 *****************************************************************************/ 2070 *****************************************************************************/
2071void __exit cpia2_exit(void) 2071static void __exit cpia2_exit(void)
2072{ 2072{
2073 cpia2_usb_cleanup(); 2073 cpia2_usb_cleanup();
2074 schedule_timeout(2 * HZ); 2074 schedule_timeout(2 * HZ);
2075} 2075}
2076 2076
2077
2078int __init cpia2_setup(char *str)
2079{
2080 while(str) {
2081 if(!strncmp(str, "buffer_size:", 12)) {
2082 buffer_size = simple_strtoul(str + 13, &str, 10);
2083 } else if(!strncmp(str, "num_buffers:", 12)) {
2084 num_buffers = simple_strtoul(str + 13, &str, 10);
2085 } else if(!strncmp(str, "alternate:", 10)) {
2086 alternate = simple_strtoul(str + 11, &str, 10);
2087 } else if(!strncmp(str, "video_nr:", 9)) {
2088 video_nr = simple_strtoul(str + 10, &str, 10);
2089 } else if(!strncmp(str, "flicker_freq:",13)) {
2090 flicker_freq = simple_strtoul(str + 14, &str, 10);
2091 } else if(!strncmp(str, "flicker_mode:",13)) {
2092 flicker_mode = simple_strtoul(str + 14, &str, 10);
2093 } else {
2094 ++str;
2095 }
2096 }
2097 return 1;
2098}
2099
2100__setup("cpia2=", cpia2_setup);
2101
2102module_init(cpia2_init); 2077module_init(cpia2_init);
2103module_exit(cpia2_exit); 2078module_exit(cpia2_exit);
2104 2079