diff options
| author | Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> | 2010-03-04 22:25:21 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2010-03-04 22:25:21 -0500 |
| commit | 64e290ec69be39f1887fa0b403c1e417b6b038e7 (patch) | |
| tree | 8c7f87a2a4baa357e0cc04ab10b5af0b06273160 | |
| parent | c437b2733520599a2c6e0dbcdeae611319f84707 (diff) | |
ext4: fix up rb_root initializations to use RB_ROOT
ext4 uses rb_node = NULL; to zero rb_root at few places. Using
RB_ROOT as the initializer is more portable in case the underlying
implementation of rbtrees changes in the future.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Eric Paris <eparis@redhat.com>
| -rw-r--r-- | fs/ext4/block_validity.c | 4 | ||||
| -rw-r--r-- | fs/ext4/dir.c | 2 | ||||
| -rw-r--r-- | fs/ext4/mballoc.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index a60ab9aad57d..983f0e127493 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c | |||
| @@ -205,14 +205,14 @@ void ext4_release_system_zone(struct super_block *sb) | |||
| 205 | entry = rb_entry(n, struct ext4_system_zone, node); | 205 | entry = rb_entry(n, struct ext4_system_zone, node); |
| 206 | kmem_cache_free(ext4_system_zone_cachep, entry); | 206 | kmem_cache_free(ext4_system_zone_cachep, entry); |
| 207 | if (!parent) | 207 | if (!parent) |
| 208 | EXT4_SB(sb)->system_blks.rb_node = NULL; | 208 | EXT4_SB(sb)->system_blks = RB_ROOT; |
| 209 | else if (parent->rb_left == n) | 209 | else if (parent->rb_left == n) |
| 210 | parent->rb_left = NULL; | 210 | parent->rb_left = NULL; |
| 211 | else if (parent->rb_right == n) | 211 | else if (parent->rb_right == n) |
| 212 | parent->rb_right = NULL; | 212 | parent->rb_right = NULL; |
| 213 | n = parent; | 213 | n = parent; |
| 214 | } | 214 | } |
| 215 | EXT4_SB(sb)->system_blks.rb_node = NULL; | 215 | EXT4_SB(sb)->system_blks = RB_ROOT; |
| 216 | } | 216 | } |
| 217 | 217 | ||
| 218 | /* | 218 | /* |
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 29857ddd9e26..86cb6d86a048 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c | |||
| @@ -305,7 +305,7 @@ static void free_rb_tree_fname(struct rb_root *root) | |||
| 305 | kfree(old); | 305 | kfree(old); |
| 306 | } | 306 | } |
| 307 | if (!parent) | 307 | if (!parent) |
| 308 | root->rb_node = NULL; | 308 | *root = RB_ROOT; |
| 309 | else if (parent->rb_left == n) | 309 | else if (parent->rb_left == n) |
| 310 | parent->rb_left = NULL; | 310 | parent->rb_left = NULL; |
| 311 | else if (parent->rb_right == n) | 311 | else if (parent->rb_right == n) |
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 37d2438e0cb4..abb11e328b65 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
| @@ -2253,7 +2253,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, | |||
| 2253 | 2253 | ||
| 2254 | INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list); | 2254 | INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list); |
| 2255 | init_rwsem(&meta_group_info[i]->alloc_sem); | 2255 | init_rwsem(&meta_group_info[i]->alloc_sem); |
| 2256 | meta_group_info[i]->bb_free_root.rb_node = NULL; | 2256 | meta_group_info[i]->bb_free_root = RB_ROOT; |
| 2257 | 2257 | ||
| 2258 | #ifdef DOUBLE_CHECK | 2258 | #ifdef DOUBLE_CHECK |
| 2259 | { | 2259 | { |
