diff options
author | Roland Dreier <rolandd@cisco.com> | 2008-04-17 00:01:09 -0400 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2008-04-17 00:01:09 -0400 |
commit | 5bd8341ce2bb5ef575b3501a8c13f22ae9f0b2ad (patch) | |
tree | ad0c12081def59e22acf9aaccc1a70284ecf7444 | |
parent | a7dab9e887ce37391f004ffd6ce0ffed7272fd69 (diff) |
RDMA/nes: Remove redundant NULL check in nes_unregister_ofa_device()
nes_unregister_ofa_device() dereferences the nesibdev pointer before
testing if it's NULL. Also, the test is doubly redundant because the
only caller of nes_unregister_ofa_device() is nes_destroy_ofa_device(),
which already tests if nesibdev is NULL. Remove the unnecessary test.
This was spotted by the Coverity checker (CID 2190).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
-rw-r--r-- | drivers/infiniband/hw/nes/nes_verbs.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c index a651e9d9f0ef..90fa06e4c9f4 100644 --- a/drivers/infiniband/hw/nes/nes_verbs.c +++ b/drivers/infiniband/hw/nes/nes_verbs.c | |||
@@ -3900,9 +3900,6 @@ void nes_unregister_ofa_device(struct nes_ib_device *nesibdev) | |||
3900 | struct nes_vnic *nesvnic = nesibdev->nesvnic; | 3900 | struct nes_vnic *nesvnic = nesibdev->nesvnic; |
3901 | int i; | 3901 | int i; |
3902 | 3902 | ||
3903 | if (nesibdev == NULL) | ||
3904 | return; | ||
3905 | |||
3906 | for (i = 0; i < ARRAY_SIZE(nes_class_attributes); ++i) { | 3903 | for (i = 0; i < ARRAY_SIZE(nes_class_attributes); ++i) { |
3907 | class_device_remove_file(&nesibdev->ibdev.class_dev, nes_class_attributes[i]); | 3904 | class_device_remove_file(&nesibdev->ibdev.class_dev, nes_class_attributes[i]); |
3908 | } | 3905 | } |