diff options
author | Oleg Nesterov <oleg@redhat.com> | 2009-06-17 19:27:39 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-06-18 16:03:52 -0400 |
commit | 47918025efdabd34e96b13b26eb2cf2fd6fd1f7c (patch) | |
tree | bae081deabe6e955e94c5510ae408b50b930c225 | |
parent | 3b34fc5880a2dcc7e5ed9837ef8d6bae051ab266 (diff) |
shift "ptrace implies WUNTRACED" from ptrace_do_wait() to wait_task_stopped()
No functional changes, preparation for the next patch.
ptrace_do_wait() adds WUNTRACED to options for wait_task_stopped() which
should always accept the stopped tracee, even if do_wait() was called
without WUNTRACED.
Change wait_task_stopped() to check "ptrace || WUNTRACED" instead. This
makes the code more explicit, and "int options" argument becomes const in
do_wait() pathes.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | kernel/exit.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/kernel/exit.c b/kernel/exit.c index 94a9992e6fd9..fd781b56401d 100644 --- a/kernel/exit.c +++ b/kernel/exit.c | |||
@@ -1330,7 +1330,10 @@ static int wait_task_stopped(int ptrace, struct task_struct *p, | |||
1330 | uid_t uid = 0; /* unneeded, required by compiler */ | 1330 | uid_t uid = 0; /* unneeded, required by compiler */ |
1331 | pid_t pid; | 1331 | pid_t pid; |
1332 | 1332 | ||
1333 | if (!(options & WUNTRACED)) | 1333 | /* |
1334 | * Traditionally we see ptrace'd stopped tasks regardless of options. | ||
1335 | */ | ||
1336 | if (!ptrace && !(options & WUNTRACED)) | ||
1334 | return 0; | 1337 | return 0; |
1335 | 1338 | ||
1336 | exit_code = 0; | 1339 | exit_code = 0; |
@@ -1548,11 +1551,6 @@ static int ptrace_do_wait(struct task_struct *tsk, int *notask_error, | |||
1548 | { | 1551 | { |
1549 | struct task_struct *p; | 1552 | struct task_struct *p; |
1550 | 1553 | ||
1551 | /* | ||
1552 | * Traditionally we see ptrace'd stopped tasks regardless of options. | ||
1553 | */ | ||
1554 | options |= WUNTRACED; | ||
1555 | |||
1556 | list_for_each_entry(p, &tsk->ptraced, ptrace_entry) { | 1554 | list_for_each_entry(p, &tsk->ptraced, ptrace_entry) { |
1557 | int ret = wait_consider_task(tsk, 1, p, notask_error, | 1555 | int ret = wait_consider_task(tsk, 1, p, notask_error, |
1558 | type, pid, options, | 1556 | type, pid, options, |