diff options
author | John W. Linville <linville@tuxdriver.com> | 2008-09-15 17:25:54 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-09-15 17:25:54 -0400 |
commit | 375da53b8e5e3ff2330b66b377e07a6151a93fe5 (patch) | |
tree | cd269946dbfe5bc391254877130f9c8c6f9e4166 | |
parent | 75d31cf19fe8f86b4612561c94dfbb6d8a472ba3 (diff) |
libertas: correct "limited range of data type" warning
CC [M] drivers/net/wireless/libertas/wext.o
drivers/net/wireless/libertas/wext.c: In function ‘lbs_get_rts’:
drivers/net/wireless/libertas/wext.c:307: warning: comparison is always
false due to limited range of data type
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/libertas/wext.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c index 1156be53df3f..11297dcf9fc3 100644 --- a/drivers/net/wireless/libertas/wext.c +++ b/drivers/net/wireless/libertas/wext.c | |||
@@ -281,7 +281,7 @@ static int lbs_set_rts(struct net_device *dev, struct iw_request_info *info, | |||
281 | if (vwrq->disabled) | 281 | if (vwrq->disabled) |
282 | val = MRVDRV_RTS_MAX_VALUE; | 282 | val = MRVDRV_RTS_MAX_VALUE; |
283 | 283 | ||
284 | if (val < MRVDRV_RTS_MIN_VALUE || val > MRVDRV_RTS_MAX_VALUE) | 284 | if (val > MRVDRV_RTS_MAX_VALUE) /* min rts value is 0 */ |
285 | return -EINVAL; | 285 | return -EINVAL; |
286 | 286 | ||
287 | ret = lbs_set_snmp_mib(priv, SNMP_MIB_OID_RTS_THRESHOLD, (u16) val); | 287 | ret = lbs_set_snmp_mib(priv, SNMP_MIB_OID_RTS_THRESHOLD, (u16) val); |
@@ -304,8 +304,7 @@ static int lbs_get_rts(struct net_device *dev, struct iw_request_info *info, | |||
304 | goto out; | 304 | goto out; |
305 | 305 | ||
306 | vwrq->value = val; | 306 | vwrq->value = val; |
307 | vwrq->disabled = ((val < MRVDRV_RTS_MIN_VALUE) | 307 | vwrq->disabled = val > MRVDRV_RTS_MAX_VALUE; /* min rts value is 0 */ |
308 | || (val > MRVDRV_RTS_MAX_VALUE)); | ||
309 | vwrq->fixed = 1; | 308 | vwrq->fixed = 1; |
310 | 309 | ||
311 | out: | 310 | out: |