diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-11-09 12:51:42 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-11-09 12:51:42 -0500 |
| commit | 1ce55238e2dd46b978b098a85cb3d3ea494e4a93 (patch) | |
| tree | 523254dbb402b1850d693f0c1f1a1db6e865456d | |
| parent | aa907639f1d9fe0e3274b4f6c1088542f750a539 (diff) | |
| parent | 2606289779cb297320a185db5997729d29b6700b (diff) | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (34 commits)
net/fsl_pq_mdio: add module license GPL
can: fix WARN_ON dump in net/core/rtnetlink.c:rtmsg_ifinfo()
can: should not use __dev_get_by_index() without locks
hisax: remove bad udelay call to fix build error on ARM
ipip: Fix handling of DF packets when pmtudisc is OFF
qlge: Set PCIe reset type for EEH to fundamental.
qlge: Fix early exit from mbox cmd complete wait.
ixgbe: fix traffic hangs on Tx with ioatdma loaded
ixgbe: Fix checking TFCS register for TXOFF status when DCB is enabled
ixgbe: Fix gso_max_size for 82599 when DCB is enabled
macsonic: fix crash on PowerBook 520
NET: cassini, fix lock imbalance
ems_usb: Fix byte order issues on big endian machines
be2net: Bug fix to send config commands to hardware after netdev_register
be2net: fix to set proper flow control on resume
netfilter: xt_connlimit: fix regression caused by zero family value
rt2x00: Don't queue ieee80211 work after USB removal
Revert "ipw2200: fix oops on missing firmware"
decnet: netdevice refcount leak
netfilter: nf_nat: fix NAT issue in 2.6.30.4+
...
46 files changed, 407 insertions, 237 deletions
diff --git a/MAINTAINERS b/MAINTAINERS index a1a2aceca5bd..8264e6bddaa1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
| @@ -3665,6 +3665,7 @@ L: netdev@vger.kernel.org | |||
| 3665 | W: http://www.linuxfoundation.org/en/Net | 3665 | W: http://www.linuxfoundation.org/en/Net |
| 3666 | W: http://patchwork.ozlabs.org/project/netdev/list/ | 3666 | W: http://patchwork.ozlabs.org/project/netdev/list/ |
| 3667 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git | 3667 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git |
| 3668 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6.git | ||
| 3668 | S: Maintained | 3669 | S: Maintained |
| 3669 | F: net/ | 3670 | F: net/ |
| 3670 | F: include/net/ | 3671 | F: include/net/ |
diff --git a/drivers/isdn/hardware/eicon/maintidi.c b/drivers/isdn/hardware/eicon/maintidi.c index 23960cb6eaab..41c26e756452 100644 --- a/drivers/isdn/hardware/eicon/maintidi.c +++ b/drivers/isdn/hardware/eicon/maintidi.c | |||
| @@ -959,8 +959,9 @@ static int process_idi_event (diva_strace_context_t* pLib, | |||
| 959 | } | 959 | } |
| 960 | if (!strncmp("State\\Layer2 No1", path, pVar->path_length)) { | 960 | if (!strncmp("State\\Layer2 No1", path, pVar->path_length)) { |
| 961 | char* tmp = &pLib->lines[0].pInterface->Layer2[0]; | 961 | char* tmp = &pLib->lines[0].pInterface->Layer2[0]; |
| 962 | dword l2_state; | 962 | dword l2_state; |
| 963 | diva_strace_read_uint (pVar, &l2_state); | 963 | if (diva_strace_read_uint(pVar, &l2_state)) |
| 964 | return -1; | ||
| 964 | 965 | ||
| 965 | switch (l2_state) { | 966 | switch (l2_state) { |
| 966 | case 0: | 967 | case 0: |
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c index 27d5dd68f4fb..ae89fb89da64 100644 --- a/drivers/isdn/hardware/eicon/message.c +++ b/drivers/isdn/hardware/eicon/message.c | |||
| @@ -2692,7 +2692,7 @@ static byte connect_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a, | |||
| 2692 | if (!(fax_control_bits & T30_CONTROL_BIT_MORE_DOCUMENTS) | 2692 | if (!(fax_control_bits & T30_CONTROL_BIT_MORE_DOCUMENTS) |
| 2693 | || (fax_feature_bits & T30_FEATURE_BIT_MORE_DOCUMENTS)) | 2693 | || (fax_feature_bits & T30_FEATURE_BIT_MORE_DOCUMENTS)) |
| 2694 | { | 2694 | { |
| 2695 | len = (byte)(&(((T30_INFO *) 0)->universal_6)); | 2695 | len = offsetof(T30_INFO, universal_6); |
| 2696 | fax_info_change = false; | 2696 | fax_info_change = false; |
| 2697 | if (ncpi->length >= 4) | 2697 | if (ncpi->length >= 4) |
| 2698 | { | 2698 | { |
| @@ -2754,7 +2754,7 @@ static byte connect_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a, | |||
| 2754 | for (i = 0; i < w; i++) | 2754 | for (i = 0; i < w; i++) |
| 2755 | ((T30_INFO *)(plci->fax_connect_info_buffer))->station_id[i] = fax_parms[4].info[1+i]; | 2755 | ((T30_INFO *)(plci->fax_connect_info_buffer))->station_id[i] = fax_parms[4].info[1+i]; |
| 2756 | ((T30_INFO *)(plci->fax_connect_info_buffer))->head_line_len = 0; | 2756 | ((T30_INFO *)(plci->fax_connect_info_buffer))->head_line_len = 0; |
| 2757 | len = (byte)(((T30_INFO *) 0)->station_id + 20); | 2757 | len = offsetof(T30_INFO, station_id) + 20; |
| 2758 | w = fax_parms[5].length; | 2758 | w = fax_parms[5].length; |
| 2759 | if (w > 20) | 2759 | if (w > 20) |
| 2760 | w = 20; | 2760 | w = 20; |
| @@ -2788,7 +2788,7 @@ static byte connect_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a, | |||
| 2788 | } | 2788 | } |
| 2789 | else | 2789 | else |
| 2790 | { | 2790 | { |
| 2791 | len = (byte)(&(((T30_INFO *) 0)->universal_6)); | 2791 | len = offsetof(T30_INFO, universal_6); |
| 2792 | } | 2792 | } |
| 2793 | fax_info_change = true; | 2793 | fax_info_change = true; |
| 2794 | 2794 | ||
| @@ -2892,7 +2892,7 @@ static byte connect_b3_res(dword Id, word Number, DIVA_CAPI_ADAPTER *a, | |||
| 2892 | && (plci->nsf_control_bits & T30_NSF_CONTROL_BIT_ENABLE_NSF) | 2892 | && (plci->nsf_control_bits & T30_NSF_CONTROL_BIT_ENABLE_NSF) |
| 2893 | && (plci->nsf_control_bits & T30_NSF_CONTROL_BIT_NEGOTIATE_RESP)) | 2893 | && (plci->nsf_control_bits & T30_NSF_CONTROL_BIT_NEGOTIATE_RESP)) |
| 2894 | { | 2894 | { |
| 2895 | len = ((byte)(((T30_INFO *) 0)->station_id + 20)); | 2895 | len = offsetof(T30_INFO, station_id) + 20; |
| 2896 | if (plci->fax_connect_info_length < len) | 2896 | if (plci->fax_connect_info_length < len) |
| 2897 | { | 2897 | { |
| 2898 | ((T30_INFO *)(plci->fax_connect_info_buffer))->station_id_len = 0; | 2898 | ((T30_INFO *)(plci->fax_connect_info_buffer))->station_id_len = 0; |
| @@ -3802,7 +3802,7 @@ static byte manufacturer_res(dword Id, word Number, DIVA_CAPI_ADAPTER *a, | |||
| 3802 | break; | 3802 | break; |
| 3803 | } | 3803 | } |
| 3804 | ncpi = &m_parms[1]; | 3804 | ncpi = &m_parms[1]; |
| 3805 | len = ((byte)(((T30_INFO *) 0)->station_id + 20)); | 3805 | len = offsetof(T30_INFO, station_id) + 20; |
| 3806 | if (plci->fax_connect_info_length < len) | 3806 | if (plci->fax_connect_info_length < len) |
| 3807 | { | 3807 | { |
| 3808 | ((T30_INFO *)(plci->fax_connect_info_buffer))->station_id_len = 0; | 3808 | ((T30_INFO *)(plci->fax_connect_info_buffer))->station_id_len = 0; |
| @@ -6844,7 +6844,7 @@ static void nl_ind(PLCI *plci) | |||
| 6844 | if ((plci->requested_options_conn | plci->requested_options | a->requested_options_table[plci->appl->Id-1]) | 6844 | if ((plci->requested_options_conn | plci->requested_options | a->requested_options_table[plci->appl->Id-1]) |
| 6845 | & ((1L << PRIVATE_FAX_SUB_SEP_PWD) | (1L << PRIVATE_FAX_NONSTANDARD))) | 6845 | & ((1L << PRIVATE_FAX_SUB_SEP_PWD) | (1L << PRIVATE_FAX_NONSTANDARD))) |
| 6846 | { | 6846 | { |
| 6847 | i = ((word)(((T30_INFO *) 0)->station_id + 20)) + ((T30_INFO *)plci->NL.RBuffer->P)->head_line_len; | 6847 | i = offsetof(T30_INFO, station_id) + 20 + ((T30_INFO *)plci->NL.RBuffer->P)->head_line_len; |
| 6848 | while (i < plci->NL.RBuffer->length) | 6848 | while (i < plci->NL.RBuffer->length) |
| 6849 | plci->ncpi_buffer[++len] = plci->NL.RBuffer->P[i++]; | 6849 | plci->ncpi_buffer[++len] = plci->NL.RBuffer->P[i++]; |
| 6850 | } | 6850 | } |
| @@ -7236,7 +7236,7 @@ static void nl_ind(PLCI *plci) | |||
| 7236 | { | 7236 | { |
| 7237 | plci->RData[1].P = plci->RData[0].P; | 7237 | plci->RData[1].P = plci->RData[0].P; |
| 7238 | plci->RData[1].PLength = plci->RData[0].PLength; | 7238 | plci->RData[1].PLength = plci->RData[0].PLength; |
| 7239 | plci->RData[0].P = v120_header_buffer + (-((int) v120_header_buffer) & 3); | 7239 | plci->RData[0].P = v120_header_buffer + (-((unsigned long)v120_header_buffer) & 3); |
| 7240 | if ((plci->NL.RBuffer->P[0] & V120_HEADER_EXTEND_BIT) || (plci->NL.RLength == 1)) | 7240 | if ((plci->NL.RBuffer->P[0] & V120_HEADER_EXTEND_BIT) || (plci->NL.RLength == 1)) |
| 7241 | plci->RData[0].PLength = 1; | 7241 | plci->RData[0].PLength = 1; |
| 7242 | else | 7242 | else |
| @@ -8473,7 +8473,7 @@ static word add_b23(PLCI *plci, API_PARSE *bp) | |||
| 8473 | fax_control_bits |= T30_CONTROL_BIT_ACCEPT_SEL_POLLING; | 8473 | fax_control_bits |= T30_CONTROL_BIT_ACCEPT_SEL_POLLING; |
| 8474 | } | 8474 | } |
| 8475 | len = nlc[0]; | 8475 | len = nlc[0]; |
| 8476 | pos = ((byte)(((T30_INFO *) 0)->station_id + 20)); | 8476 | pos = offsetof(T30_INFO, station_id) + 20; |
| 8477 | if (pos < plci->fax_connect_info_length) | 8477 | if (pos < plci->fax_connect_info_length) |
| 8478 | { | 8478 | { |
| 8479 | for (i = 1 + plci->fax_connect_info_buffer[pos]; i != 0; i--) | 8479 | for (i = 1 + plci->fax_connect_info_buffer[pos]; i != 0; i--) |
| @@ -8525,7 +8525,7 @@ static word add_b23(PLCI *plci, API_PARSE *bp) | |||
| 8525 | } | 8525 | } |
| 8526 | 8526 | ||
| 8527 | PUT_WORD(&(((T30_INFO *)&nlc[1])->control_bits_low), fax_control_bits); | 8527 | PUT_WORD(&(((T30_INFO *)&nlc[1])->control_bits_low), fax_control_bits); |
| 8528 | len = ((byte)(((T30_INFO *) 0)->station_id + 20)); | 8528 | len = offsetof(T30_INFO, station_id) + 20; |
| 8529 | for (i = 0; i < len; i++) | 8529 | for (i = 0; i < len; i++) |
| 8530 | plci->fax_connect_info_buffer[i] = nlc[1+i]; | 8530 | plci->fax_connect_info_buffer[i] = nlc[1+i]; |
| 8531 | ((T30_INFO *) plci->fax_connect_info_buffer)->head_line_len = 0; | 8531 | ((T30_INFO *) plci->fax_connect_info_buffer)->head_line_len = 0; |
diff --git a/drivers/isdn/hisax/amd7930_fn.c b/drivers/isdn/hisax/amd7930_fn.c index bf526a7a63af..d6fdf1f66754 100644 --- a/drivers/isdn/hisax/amd7930_fn.c +++ b/drivers/isdn/hisax/amd7930_fn.c | |||
| @@ -594,6 +594,7 @@ Amd7930_l1hw(struct PStack *st, int pr, void *arg) | |||
| 594 | if (cs->debug & L1_DEB_WARN) | 594 | if (cs->debug & L1_DEB_WARN) |
| 595 | debugl1(cs, "Amd7930: l1hw: l2l1 tx_skb exist this shouldn't happen"); | 595 | debugl1(cs, "Amd7930: l1hw: l2l1 tx_skb exist this shouldn't happen"); |
| 596 | skb_queue_tail(&cs->sq, skb); | 596 | skb_queue_tail(&cs->sq, skb); |
| 597 | spin_unlock_irqrestore(&cs->lock, flags); | ||
| 597 | break; | 598 | break; |
| 598 | } | 599 | } |
| 599 | if (cs->debug & DEB_DLOG_HEX) | 600 | if (cs->debug & DEB_DLOG_HEX) |
diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c index 018bd293e580..0b0c2e5d806b 100644 --- a/drivers/isdn/hisax/diva.c +++ b/drivers/isdn/hisax/diva.c | |||
| @@ -382,7 +382,7 @@ MemwaitforXFW(struct IsdnCardState *cs, int hscx) | |||
| 382 | { | 382 | { |
| 383 | int to = 50; | 383 | int to = 50; |
| 384 | 384 | ||
| 385 | while ((!(MemReadHSCX(cs, hscx, HSCX_STAR) & 0x44) == 0x40) && to) { | 385 | while (((MemReadHSCX(cs, hscx, HSCX_STAR) & 0x44) != 0x40) && to) { |
| 386 | udelay(1); | 386 | udelay(1); |
| 387 | to--; | 387 | to--; |
| 388 | } | 388 | } |
diff --git a/drivers/isdn/hisax/elsa_ser.c b/drivers/isdn/hisax/elsa_ser.c index f181db464392..1657bba7879e 100644 --- a/drivers/isdn/hisax/elsa_ser.c +++ b/drivers/isdn/hisax/elsa_ser.c | |||
| @@ -477,62 +477,62 @@ static void | |||
| 477 | modem_set_init(struct IsdnCardState *cs) { | 477 | modem_set_init(struct IsdnCardState *cs) { |
| 478 | int timeout; | 478 | int timeout; |
| 479 | 479 | ||
| 480 | #define RCV_DELAY 20000 | 480 | #define RCV_DELAY 20 |
| 481 | modem_write_cmd(cs, MInit_1, strlen(MInit_1)); | 481 | modem_write_cmd(cs, MInit_1, strlen(MInit_1)); |
| 482 | timeout = 1000; | 482 | timeout = 1000; |
| 483 | while(timeout-- && cs->hw.elsa.transcnt) | 483 | while(timeout-- && cs->hw.elsa.transcnt) |
| 484 | udelay(1000); | 484 | udelay(1000); |
| 485 | debugl1(cs, "msi tout=%d", timeout); | 485 | debugl1(cs, "msi tout=%d", timeout); |
| 486 | udelay(RCV_DELAY); | 486 | mdelay(RCV_DELAY); |
| 487 | modem_write_cmd(cs, MInit_2, strlen(MInit_2)); | 487 | modem_write_cmd(cs, MInit_2, strlen(MInit_2)); |
| 488 | timeout = 1000; | 488 | timeout = 1000; |
| 489 | while(timeout-- && cs->hw.elsa.transcnt) | 489 | while(timeout-- && cs->hw.elsa.transcnt) |
| 490 | udelay(1000); | 490 | udelay(1000); |
| 491 | debugl1(cs, "msi tout=%d", timeout); | 491 | debugl1(cs, "msi tout=%d", timeout); |
| 492 | udelay(RCV_DELAY); | 492 | mdelay(RCV_DELAY); |
| 493 | modem_write_cmd(cs, MInit_3, strlen(MInit_3)); | 493 | modem_write_cmd(cs, MInit_3, strlen(MInit_3)); |
| 494 | timeout = 1000; | 494 | timeout = 1000; |
| 495 | while(timeout-- && cs->hw.elsa.transcnt) | 495 | while(timeout-- && cs->hw.elsa.transcnt) |
| 496 | udelay(1000); | 496 | udelay(1000); |
| 497 | debugl1(cs, "msi tout=%d", timeout); | 497 | debugl1(cs, "msi tout=%d", timeout); |
| 498 | udelay(RCV_DELAY); | 498 | mdelay(RCV_DELAY); |
| 499 | modem_write_cmd(cs, MInit_4, strlen(MInit_4)); | 499 | modem_write_cmd(cs, MInit_4, strlen(MInit_4)); |
| 500 | timeout = 1000; | 500 | timeout = 1000; |
| 501 | while(timeout-- && cs->hw.elsa.transcnt) | 501 | while(timeout-- && cs->hw.elsa.transcnt) |
| 502 | udelay(1000); | 502 | udelay(1000); |
| 503 | debugl1(cs, "msi tout=%d", timeout); | 503 | debugl1(cs, "msi tout=%d", timeout); |
| 504 | udelay(RCV_DELAY ); | 504 | mdelay(RCV_DELAY); |
| 505 | modem_write_cmd(cs, MInit_5, strlen(MInit_5)); | 505 | modem_write_cmd(cs, MInit_5, strlen(MInit_5)); |
| 506 | timeout = 1000; | 506 | timeout = 1000; |
| 507 | while(timeout-- && cs->hw.elsa.transcnt) | 507 | while(timeout-- && cs->hw.elsa.transcnt) |
| 508 | udelay(1000); | 508 | udelay(1000); |
| 509 | debugl1(cs, "msi tout=%d", timeout); | 509 | debugl1(cs, "msi tout=%d", timeout); |
| 510 | udelay(RCV_DELAY); | 510 | mdelay(RCV_DELAY); |
| 511 | modem_write_cmd(cs, MInit_6, strlen(MInit_6)); | 511 | modem_write_cmd(cs, MInit_6, strlen(MInit_6)); |
| 512 | timeout = 1000; | 512 | timeout = 1000; |
| 513 | while(timeout-- && cs->hw.elsa.transcnt) | 513 | while(timeout-- && cs->hw.elsa.transcnt) |
| 514 | udelay(1000); | 514 | udelay(1000); |
| 515 | debugl1(cs, "msi tout=%d", timeout); | 515 | debugl1(cs, "msi tout=%d", timeout); |
| 516 | udelay(RCV_DELAY); | 516 | mdelay(RCV_DELAY); |
| 517 | modem_write_cmd(cs, MInit_7, strlen(MInit_7)); | 517 | modem_write_cmd(cs, MInit_7, strlen(MInit_7)); |
| 518 | timeout = 1000; | 518 | timeout = 1000; |
| 519 | while(timeout-- && cs->hw.elsa.transcnt) | 519 | while(timeout-- && cs->hw.elsa.transcnt) |
| 520 | udelay(1000); | 520 | udelay(1000); |
| 521 | debugl1(cs, "msi tout=%d", timeout); | 521 | debugl1(cs, "msi tout=%d", timeout); |
| 522 | udelay(RCV_DELAY); | 522 | mdelay(RCV_DELAY); |
| 523 | } | 523 | } |
| 524 | 524 | ||
| 525 | static void | 525 | static void |
| 526 | modem_set_dial(struct IsdnCardState *cs, int outgoing) { | 526 | modem_set_dial(struct IsdnCardState *cs, int outgoing) { |
| 527 | int timeout; | 527 | int timeout; |
| 528 | #define RCV_DELAY 20000 | 528 | #define RCV_DELAY 20 |
| 529 | 529 | ||
| 530 | modem_write_cmd(cs, MInit_speed28800, strlen(MInit_speed28800)); | 530 | modem_write_cmd(cs, MInit_speed28800, strlen(MInit_speed28800)); |
| 531 | timeout = 1000; | 531 | timeout = 1000; |
| 532 | while(timeout-- && cs->hw.elsa.transcnt) | 532 | while(timeout-- && cs->hw.elsa.transcnt) |
| 533 | udelay(1000); | 533 | udelay(1000); |
| 534 | debugl1(cs, "msi tout=%d", timeout); | 534 | debugl1(cs, "msi tout=%d", timeout); |
| 535 | udelay(RCV_DELAY); | 535 | mdelay(RCV_DELAY); |
| 536 | if (outgoing) | 536 | if (outgoing) |
| 537 | modem_write_cmd(cs, MInit_dialout, strlen(MInit_dialout)); | 537 | modem_write_cmd(cs, MInit_dialout, strlen(MInit_dialout)); |
| 538 | else | 538 | else |
| @@ -541,7 +541,7 @@ modem_set_dial(struct IsdnCardState *cs, int outgoing) { | |||
| 541 | while(timeout-- && cs->hw.elsa.transcnt) | 541 | while(timeout-- && cs->hw.elsa.transcnt) |
| 542 | udelay(1000); | 542 | udelay(1000); |
| 543 | debugl1(cs, "msi tout=%d", timeout); | 543 | debugl1(cs, "msi tout=%d", timeout); |
| 544 | udelay(RCV_DELAY); | 544 | mdelay(RCV_DELAY); |
| 545 | } | 545 | } |
| 546 | 546 | ||
| 547 | static void | 547 | static void |
diff --git a/drivers/isdn/hisax/hfc_usb.c b/drivers/isdn/hisax/hfc_usb.c index 9de54202c90c..a420b64472e3 100644 --- a/drivers/isdn/hisax/hfc_usb.c +++ b/drivers/isdn/hisax/hfc_usb.c | |||
| @@ -817,8 +817,8 @@ collect_rx_frame(usb_fifo * fifo, __u8 * data, int len, int finish) | |||
| 817 | } | 817 | } |
| 818 | /* we have a complete hdlc packet */ | 818 | /* we have a complete hdlc packet */ |
| 819 | if (finish) { | 819 | if (finish) { |
| 820 | if ((!fifo->skbuff->data[fifo->skbuff->len - 1]) | 820 | if (fifo->skbuff->len > 3 && |
| 821 | && (fifo->skbuff->len > 3)) { | 821 | !fifo->skbuff->data[fifo->skbuff->len - 1]) { |
| 822 | 822 | ||
| 823 | if (fifon == HFCUSB_D_RX) { | 823 | if (fifon == HFCUSB_D_RX) { |
| 824 | DBG(HFCUSB_DBG_DCHANNEL, | 824 | DBG(HFCUSB_DBG_DCHANNEL, |
diff --git a/drivers/isdn/hisax/hscx_irq.c b/drivers/isdn/hisax/hscx_irq.c index 7b1ad5e4ecda..2387d76c721a 100644 --- a/drivers/isdn/hisax/hscx_irq.c +++ b/drivers/isdn/hisax/hscx_irq.c | |||
| @@ -32,7 +32,7 @@ waitforXFW(struct IsdnCardState *cs, int hscx) | |||
| 32 | { | 32 | { |
| 33 | int to = 50; | 33 | int to = 50; |
| 34 | 34 | ||
| 35 | while ((!(READHSCX(cs, hscx, HSCX_STAR) & 0x44) == 0x40) && to) { | 35 | while (((READHSCX(cs, hscx, HSCX_STAR) & 0x44) != 0x40) && to) { |
| 36 | udelay(1); | 36 | udelay(1); |
| 37 | to--; | 37 | to--; |
| 38 | } | 38 | } |
diff --git a/drivers/isdn/hisax/icc.c b/drivers/isdn/hisax/icc.c index 9aba646ba221..c80cbb8a2ef9 100644 --- a/drivers/isdn/hisax/icc.c +++ b/drivers/isdn/hisax/icc.c | |||
| @@ -468,6 +468,7 @@ ICC_l1hw(struct PStack *st, int pr, void *arg) | |||
| 468 | if (cs->debug & L1_DEB_WARN) | 468 | if (cs->debug & L1_DEB_WARN) |
| 469 | debugl1(cs, " l2l1 tx_skb exist this shouldn't happen"); | 469 | debugl1(cs, " l2l1 tx_skb exist this shouldn't happen"); |
| 470 | skb_queue_tail(&cs->sq, skb); | 470 | skb_queue_tail(&cs->sq, skb); |
| 471 | spin_unlock_irqrestore(&cs->lock, flags); | ||
| 471 | break; | 472 | break; |
| 472 | } | 473 | } |
| 473 | if (cs->debug & DEB_DLOG_HEX) | 474 | if (cs->debug & DEB_DLOG_HEX) |
diff --git a/drivers/isdn/mISDN/stack.c b/drivers/isdn/mISDN/stack.c index 3e1532a180ff..0d05ec43012c 100644 --- a/drivers/isdn/mISDN/stack.c +++ b/drivers/isdn/mISDN/stack.c | |||
| @@ -364,7 +364,7 @@ add_layer2(struct mISDNchannel *ch, struct mISDNstack *st) | |||
| 364 | static int | 364 | static int |
| 365 | st_own_ctrl(struct mISDNchannel *ch, u_int cmd, void *arg) | 365 | st_own_ctrl(struct mISDNchannel *ch, u_int cmd, void *arg) |
| 366 | { | 366 | { |
| 367 | if (!ch->st || ch->st->layer1) | 367 | if (!ch->st || !ch->st->layer1) |
| 368 | return -EINVAL; | 368 | return -EINVAL; |
| 369 | return ch->st->layer1->ctrl(ch->st->layer1, cmd, arg); | 369 | return ch->st->layer1->ctrl(ch->st->layer1, cmd, arg); |
| 370 | } | 370 | } |
diff --git a/drivers/net/benet/be.h b/drivers/net/benet/be.h index a80da0e14a52..3b79a225628a 100644 --- a/drivers/net/benet/be.h +++ b/drivers/net/benet/be.h | |||
| @@ -259,6 +259,8 @@ struct be_adapter { | |||
| 259 | u32 port_num; | 259 | u32 port_num; |
| 260 | bool promiscuous; | 260 | bool promiscuous; |
| 261 | u32 cap; | 261 | u32 cap; |
| 262 | u32 rx_fc; /* Rx flow control */ | ||
| 263 | u32 tx_fc; /* Tx flow control */ | ||
| 262 | }; | 264 | }; |
| 263 | 265 | ||
| 264 | extern const struct ethtool_ops be_ethtool_ops; | 266 | extern const struct ethtool_ops be_ethtool_ops; |
diff --git a/drivers/net/benet/be_cmds.h b/drivers/net/benet/be_cmds.h index 49953787e41c..e5f9676cf1bc 100644 --- a/drivers/net/benet/be_cmds.h +++ b/drivers/net/benet/be_cmds.h | |||
| @@ -68,7 +68,7 @@ enum { | |||
| 68 | #define CQE_STATUS_COMPL_MASK 0xFFFF | 68 | #define CQE_STATUS_COMPL_MASK 0xFFFF |
| 69 | #define CQE_STATUS_COMPL_SHIFT 0 /* bits 0 - 15 */ | 69 | #define CQE_STATUS_COMPL_SHIFT 0 /* bits 0 - 15 */ |
| 70 | #define CQE_STATUS_EXTD_MASK 0xFFFF | 70 | #define CQE_STATUS_EXTD_MASK 0xFFFF |
| 71 | #define CQE_STATUS_EXTD_SHIFT 0 /* bits 0 - 15 */ | 71 | #define CQE_STATUS_EXTD_SHIFT 16 /* bits 16 - 31 */ |
| 72 | 72 | ||
| 73 | struct be_mcc_compl { | 73 | struct be_mcc_compl { |
| 74 | u32 status; /* dword 0 */ | 74 | u32 status; /* dword 0 */ |
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c index cda5bf2fc50a..f0fd95b43c07 100644 --- a/drivers/net/benet/be_ethtool.c +++ b/drivers/net/benet/be_ethtool.c | |||
| @@ -323,10 +323,12 @@ be_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd) | |||
| 323 | 323 | ||
| 324 | if (ecmd->autoneg != 0) | 324 | if (ecmd->autoneg != 0) |
| 325 | return -EINVAL; | 325 | return -EINVAL; |
| 326 | adapter->tx_fc = ecmd->tx_pause; | ||
| 327 | adapter->rx_fc = ecmd->rx_pause; | ||
| 326 | 328 | ||
| 327 | status = be_cmd_set_flow_control(adapter, ecmd->tx_pause, | 329 | status = be_cmd_set_flow_control(adapter, |
| 328 | ecmd->rx_pause); | 330 | adapter->tx_fc, adapter->rx_fc); |
| 329 | if (!status) | 331 | if (status) |
| 330 | dev_warn(&adapter->pdev->dev, "Pause param set failed.\n"); | 332 | dev_warn(&adapter->pdev->dev, "Pause param set failed.\n"); |
| 331 | 333 | ||
| 332 | return status; | 334 | return status; |
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index 1f941f027718..876b357101fa 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c | |||
| @@ -1610,11 +1610,21 @@ static int be_open(struct net_device *netdev) | |||
| 1610 | 1610 | ||
| 1611 | status = be_cmd_link_status_query(adapter, &link_up); | 1611 | status = be_cmd_link_status_query(adapter, &link_up); |
| 1612 | if (status) | 1612 | if (status) |
| 1613 | return status; | 1613 | goto ret_sts; |
| 1614 | be_link_status_update(adapter, link_up); | 1614 | be_link_status_update(adapter, link_up); |
| 1615 | 1615 | ||
| 1616 | status = be_vid_config(adapter); | ||
| 1617 | if (status) | ||
| 1618 | goto ret_sts; | ||
| 1619 | |||
| 1620 | status = be_cmd_set_flow_control(adapter, | ||
| 1621 | adapter->tx_fc, adapter->rx_fc); | ||
| 1622 | if (status) | ||
| 1623 | goto ret_sts; | ||
| 1624 | |||
| 1616 | schedule_delayed_work(&adapter->work, msecs_to_jiffies(100)); | 1625 | schedule_delayed_work(&adapter->work, msecs_to_jiffies(100)); |
| 1617 | return 0; | 1626 | ret_sts: |
| 1627 | return status; | ||
| 1618 | } | 1628 | } |
| 1619 | 1629 | ||
| 1620 | static int be_setup(struct be_adapter *adapter) | 1630 | static int be_setup(struct be_adapter *adapter) |
| @@ -1648,17 +1658,8 @@ static int be_setup(struct be_adapter *adapter) | |||
| 1648 | if (status != 0) | 1658 | if (status != 0) |
| 1649 | goto rx_qs_destroy; | 1659 | goto rx_qs_destroy; |
| 1650 | 1660 | ||
| 1651 | status = be_vid_config(adapter); | ||
| 1652 | if (status != 0) | ||
| 1653 | goto mccqs_destroy; | ||
| 1654 | |||
| 1655 | status = be_cmd_set_flow_control(adapter, true, true); | ||
| 1656 | if (status != 0) | ||
| 1657 | goto mccqs_destroy; | ||
| 1658 | return 0; | 1661 | return 0; |
| 1659 | 1662 | ||
| 1660 | mccqs_destroy: | ||
| 1661 | be_mcc_queues_destroy(adapter); | ||
| 1662 | rx_qs_destroy: | 1663 | rx_qs_destroy: |
| 1663 | be_rx_queues_destroy(adapter); | 1664 | be_rx_queues_destroy(adapter); |
| 1664 | tx_qs_destroy: | 1665 | tx_qs_destroy: |
| @@ -1909,6 +1910,10 @@ static void be_netdev_init(struct net_device *netdev) | |||
| 1909 | 1910 | ||
| 1910 | adapter->rx_csum = true; | 1911 | adapter->rx_csum = true; |
| 1911 | 1912 | ||
| 1913 | /* Default settings for Rx and Tx flow control */ | ||
| 1914 | adapter->rx_fc = true; | ||
| 1915 | adapter->tx_fc = true; | ||
| 1916 | |||
| 1912 | netif_set_gso_max_size(netdev, 65535); | 1917 | netif_set_gso_max_size(netdev, 65535); |
| 1913 | 1918 | ||
| 1914 | BE_SET_NETDEV_OPS(netdev, &be_netdev_ops); | 1919 | BE_SET_NETDEV_OPS(netdev, &be_netdev_ops); |
| @@ -2171,6 +2176,7 @@ static int be_suspend(struct pci_dev *pdev, pm_message_t state) | |||
| 2171 | be_close(netdev); | 2176 | be_close(netdev); |
| 2172 | rtnl_unlock(); | 2177 | rtnl_unlock(); |
| 2173 | } | 2178 | } |
| 2179 | be_cmd_get_flow_control(adapter, &adapter->tx_fc, &adapter->rx_fc); | ||
| 2174 | be_clear(adapter); | 2180 | be_clear(adapter); |
| 2175 | 2181 | ||
| 2176 | pci_save_state(pdev); | 2182 | pci_save_state(pdev); |
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index f0b9a1e1db46..564e31c9fee4 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c | |||
| @@ -589,6 +589,22 @@ static int can_changelink(struct net_device *dev, | |||
| 589 | return 0; | 589 | return 0; |
| 590 | } | 590 | } |
| 591 | 591 | ||
| 592 | static size_t can_get_size(const struct net_device *dev) | ||
| 593 | { | ||
| 594 | struct can_priv *priv = netdev_priv(dev); | ||
| 595 | size_t size; | ||
| 596 | |||
| 597 | size = nla_total_size(sizeof(u32)); /* IFLA_CAN_STATE */ | ||
| 598 | size += sizeof(struct can_ctrlmode); /* IFLA_CAN_CTRLMODE */ | ||
| 599 | size += nla_total_size(sizeof(u32)); /* IFLA_CAN_RESTART_MS */ | ||
| 600 | size += sizeof(struct can_bittiming); /* IFLA_CAN_BITTIMING */ | ||
| 601 | size += sizeof(struct can_clock); /* IFLA_CAN_CLOCK */ | ||
| 602 | if (priv->bittiming_const) /* IFLA_CAN_BITTIMING_CONST */ | ||
| 603 | size += sizeof(struct can_bittiming_const); | ||
| 604 | |||
| 605 | return size; | ||
| 606 | } | ||
| 607 | |||
| 592 | static int can_fill_info(struct sk_buff *skb, const struct net_device *dev) | 608 | static int can_fill_info(struct sk_buff *skb, const struct net_device *dev) |
| 593 | { | 609 | { |
| 594 | struct can_priv *priv = netdev_priv(dev); | 610 | struct can_priv *priv = netdev_priv(dev); |
| @@ -639,6 +655,7 @@ static struct rtnl_link_ops can_link_ops __read_mostly = { | |||
| 639 | .setup = can_setup, | 655 | .setup = can_setup, |
| 640 | .newlink = can_newlink, | 656 | .newlink = can_newlink, |
| 641 | .changelink = can_changelink, | 657 | .changelink = can_changelink, |
| 658 | .get_size = can_get_size, | ||
| 642 | .fill_info = can_fill_info, | 659 | .fill_info = can_fill_info, |
| 643 | .fill_xstats = can_fill_xstats, | 660 | .fill_xstats = can_fill_xstats, |
| 644 | }; | 661 | }; |
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c index 9012e0abc626..abdbd9c2b788 100644 --- a/drivers/net/can/usb/ems_usb.c +++ b/drivers/net/can/usb/ems_usb.c | |||
| @@ -319,7 +319,7 @@ static void ems_usb_rx_can_msg(struct ems_usb *dev, struct ems_cpc_msg *msg) | |||
| 319 | 319 | ||
| 320 | cf = (struct can_frame *)skb_put(skb, sizeof(struct can_frame)); | 320 | cf = (struct can_frame *)skb_put(skb, sizeof(struct can_frame)); |
| 321 | 321 | ||
| 322 | cf->can_id = msg->msg.can_msg.id; | 322 | cf->can_id = le32_to_cpu(msg->msg.can_msg.id); |
| 323 | cf->can_dlc = min_t(u8, msg->msg.can_msg.length, 8); | 323 | cf->can_dlc = min_t(u8, msg->msg.can_msg.length, 8); |
| 324 | 324 | ||
| 325 | if (msg->type == CPC_MSG_TYPE_EXT_CAN_FRAME | 325 | if (msg->type == CPC_MSG_TYPE_EXT_CAN_FRAME |
| @@ -813,6 +813,9 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne | |||
| 813 | msg->length = CPC_CAN_MSG_MIN_SIZE + cf->can_dlc; | 813 | msg->length = CPC_CAN_MSG_MIN_SIZE + cf->can_dlc; |
| 814 | } | 814 | } |
| 815 | 815 | ||
| 816 | /* Respect byte order */ | ||
| 817 | msg->msg.can_msg.id = cpu_to_le32(msg->msg.can_msg.id); | ||
| 818 | |||
| 816 | for (i = 0; i < MAX_TX_URBS; i++) { | 819 | for (i = 0; i < MAX_TX_URBS; i++) { |
| 817 | if (dev->tx_contexts[i].echo_index == MAX_TX_URBS) { | 820 | if (dev->tx_contexts[i].echo_index == MAX_TX_URBS) { |
| 818 | context = &dev->tx_contexts[i]; | 821 | context = &dev->tx_contexts[i]; |
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c index 05916aafa4f1..f857afe8e488 100644 --- a/drivers/net/cassini.c +++ b/drivers/net/cassini.c | |||
| @@ -4342,11 +4342,11 @@ static int cas_open(struct net_device *dev) | |||
| 4342 | cas_unlock_all_restore(cp, flags); | 4342 | cas_unlock_all_restore(cp, flags); |
| 4343 | } | 4343 | } |
| 4344 | 4344 | ||
| 4345 | err = -ENOMEM; | ||
| 4345 | if (cas_tx_tiny_alloc(cp) < 0) | 4346 | if (cas_tx_tiny_alloc(cp) < 0) |
| 4346 | return -ENOMEM; | 4347 | goto err_unlock; |
| 4347 | 4348 | ||
| 4348 | /* alloc rx descriptors */ | 4349 | /* alloc rx descriptors */ |
| 4349 | err = -ENOMEM; | ||
| 4350 | if (cas_alloc_rxds(cp) < 0) | 4350 | if (cas_alloc_rxds(cp) < 0) |
| 4351 | goto err_tx_tiny; | 4351 | goto err_tx_tiny; |
| 4352 | 4352 | ||
| @@ -4386,6 +4386,7 @@ err_spare: | |||
| 4386 | cas_free_rxds(cp); | 4386 | cas_free_rxds(cp); |
| 4387 | err_tx_tiny: | 4387 | err_tx_tiny: |
| 4388 | cas_tx_tiny_free(cp); | 4388 | cas_tx_tiny_free(cp); |
| 4389 | err_unlock: | ||
| 4389 | mutex_unlock(&cp->pm_mutex); | 4390 | mutex_unlock(&cp->pm_mutex); |
| 4390 | return err; | 4391 | return err; |
| 4391 | } | 4392 | } |
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index f72c56dec33c..3179521aee90 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c | |||
| @@ -2221,7 +2221,7 @@ void emac_poll_controller(struct net_device *ndev) | |||
| 2221 | struct emac_priv *priv = netdev_priv(ndev); | 2221 | struct emac_priv *priv = netdev_priv(ndev); |
| 2222 | 2222 | ||
| 2223 | emac_int_disable(priv); | 2223 | emac_int_disable(priv); |
| 2224 | emac_irq(ndev->irq, priv); | 2224 | emac_irq(ndev->irq, ndev); |
| 2225 | emac_int_enable(priv); | 2225 | emac_int_enable(priv); |
| 2226 | } | 2226 | } |
| 2227 | #endif | 2227 | #endif |
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c index 6ac464866972..efbf67689eca 100644 --- a/drivers/net/fsl_pq_mdio.c +++ b/drivers/net/fsl_pq_mdio.c | |||
| @@ -427,3 +427,4 @@ void fsl_pq_mdio_exit(void) | |||
| 427 | of_unregister_platform_driver(&fsl_pq_mdio_driver); | 427 | of_unregister_platform_driver(&fsl_pq_mdio_driver); |
| 428 | } | 428 | } |
| 429 | module_exit(fsl_pq_mdio_exit); | 429 | module_exit(fsl_pq_mdio_exit); |
| 430 | MODULE_LICENSE("GPL"); | ||
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index cbb143ca1eb8..5bd9e6bf6f2f 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c | |||
| @@ -44,6 +44,7 @@ | |||
| 44 | 44 | ||
| 45 | #include "ixgbe.h" | 45 | #include "ixgbe.h" |
| 46 | #include "ixgbe_common.h" | 46 | #include "ixgbe_common.h" |
| 47 | #include "ixgbe_dcb_82599.h" | ||
| 47 | 48 | ||
| 48 | char ixgbe_driver_name[] = "ixgbe"; | 49 | char ixgbe_driver_name[] = "ixgbe"; |
| 49 | static const char ixgbe_driver_string[] = | 50 | static const char ixgbe_driver_string[] = |
| @@ -226,6 +227,56 @@ static void ixgbe_unmap_and_free_tx_resource(struct ixgbe_adapter *adapter, | |||
| 226 | /* tx_buffer_info must be completely set up in the transmit path */ | 227 | /* tx_buffer_info must be completely set up in the transmit path */ |
| 227 | } | 228 | } |
| 228 | 229 | ||
| 230 | /** | ||
| 231 | * ixgbe_tx_is_paused - check if the tx ring is paused | ||
| 232 | * @adapter: the ixgbe adapter | ||
| 233 | * @tx_ring: the corresponding tx_ring | ||
| 234 | * | ||
| 235 | * If not in DCB mode, checks TFCS.TXOFF, otherwise, find out the | ||
| 236 | * corresponding TC of this tx_ring when checking TFCS. | ||
| 237 | * | ||
| 238 | * Returns : true if paused | ||
| 239 | */ | ||
| 240 | static inline bool ixgbe_tx_is_paused(struct ixgbe_adapter *adapter, | ||
| 241 | struct ixgbe_ring *tx_ring) | ||
| 242 | { | ||
| 243 | int tc; | ||
| 244 | u32 txoff = IXGBE_TFCS_TXOFF; | ||
| 245 | |||
| 246 | #ifdef CONFIG_IXGBE_DCB | ||
| 247 | if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) { | ||
| 248 | int reg_idx = tx_ring->reg_idx; | ||
| 249 | int dcb_i = adapter->ring_feature[RING_F_DCB].indices; | ||
| 250 | |||
| 251 | if (adapter->hw.mac.type == ixgbe_mac_82598EB) { | ||
| 252 | tc = reg_idx >> 2; | ||
| 253 | txoff = IXGBE_TFCS_TXOFF0; | ||
| 254 | } else if (adapter->hw.mac.type == ixgbe_mac_82599EB) { | ||
| 255 | tc = 0; | ||
| 256 | txoff = IXGBE_TFCS_TXOFF; | ||
| 257 | if (dcb_i == 8) { | ||
| 258 | /* TC0, TC1 */ | ||
| 259 | tc = reg_idx >> 5; | ||
| 260 | if (tc == 2) /* TC2, TC3 */ | ||
| 261 | tc += (reg_idx - 64) >> 4; | ||
| 262 | else if (tc == 3) /* TC4, TC5, TC6, TC7 */ | ||
| 263 | tc += 1 + ((reg_idx - 96) >> 3); | ||
| 264 | } else if (dcb_i == 4) { | ||
| 265 | /* TC0, TC1 */ | ||
| 266 | tc = reg_idx >> 6; | ||
| 267 | if (tc == 1) { | ||
| 268 | tc += (reg_idx - 64) >> 5; | ||
| 269 | if (tc == 2) /* TC2, TC3 */ | ||
| 270 | tc += (reg_idx - 96) >> 4; | ||
| 271 | } | ||
| 272 | } | ||
| 273 | } | ||
| 274 | txoff <<= tc; | ||
| 275 | } | ||
| 276 | #endif | ||
| 277 | return IXGBE_READ_REG(&adapter->hw, IXGBE_TFCS) & txoff; | ||
| 278 | } | ||
| 279 | |||
| 229 | static inline bool ixgbe_check_tx_hang(struct ixgbe_adapter *adapter, | 280 | static inline bool ixgbe_check_tx_hang(struct ixgbe_adapter *adapter, |
| 230 | struct ixgbe_ring *tx_ring, | 281 | struct ixgbe_ring *tx_ring, |
| 231 | unsigned int eop) | 282 | unsigned int eop) |
| @@ -237,7 +288,7 @@ static inline bool ixgbe_check_tx_hang(struct ixgbe_adapter *adapter, | |||
| 237 | adapter->detect_tx_hung = false; | 288 | adapter->detect_tx_hung = false; |
| 238 | if (tx_ring->tx_buffer_info[eop].time_stamp && | 289 | if (tx_ring->tx_buffer_info[eop].time_stamp && |
| 239 | time_after(jiffies, tx_ring->tx_buffer_info[eop].time_stamp + HZ) && | 290 | time_after(jiffies, tx_ring->tx_buffer_info[eop].time_stamp + HZ) && |
| 240 | !(IXGBE_READ_REG(&adapter->hw, IXGBE_TFCS) & IXGBE_TFCS_TXOFF)) { | 291 | !ixgbe_tx_is_paused(adapter, tx_ring)) { |
| 241 | /* detected Tx unit hang */ | 292 | /* detected Tx unit hang */ |
| 242 | union ixgbe_adv_tx_desc *tx_desc; | 293 | union ixgbe_adv_tx_desc *tx_desc; |
| 243 | tx_desc = IXGBE_TX_DESC_ADV(*tx_ring, eop); | 294 | tx_desc = IXGBE_TX_DESC_ADV(*tx_ring, eop); |
| @@ -412,19 +463,23 @@ static void ixgbe_update_tx_dca(struct ixgbe_adapter *adapter, | |||
| 412 | u32 txctrl; | 463 | u32 txctrl; |
| 413 | int cpu = get_cpu(); | 464 | int cpu = get_cpu(); |
| 414 | int q = tx_ring - adapter->tx_ring; | 465 | int q = tx_ring - adapter->tx_ring; |
| 466 | struct ixgbe_hw *hw = &adapter->hw; | ||
| 415 | 467 | ||
| 416 | if (tx_ring->cpu != cpu) { | 468 | if (tx_ring->cpu != cpu) { |
| 417 | txctrl = IXGBE_READ_REG(&adapter->hw, IXGBE_DCA_TXCTRL(q)); | ||
| 418 | if (adapter->hw.mac.type == ixgbe_mac_82598EB) { | 469 | if (adapter->hw.mac.type == ixgbe_mac_82598EB) { |
| 470 | txctrl = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL(q)); | ||
| 419 | txctrl &= ~IXGBE_DCA_TXCTRL_CPUID_MASK; | 471 | txctrl &= ~IXGBE_DCA_TXCTRL_CPUID_MASK; |
| 420 | txctrl |= dca3_get_tag(&adapter->pdev->dev, cpu); | 472 | txctrl |= dca3_get_tag(&adapter->pdev->dev, cpu); |
| 473 | txctrl |= IXGBE_DCA_TXCTRL_DESC_DCA_EN; | ||
| 474 | IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL(q), txctrl); | ||
| 421 | } else if (adapter->hw.mac.type == ixgbe_mac_82599EB) { | 475 | } else if (adapter->hw.mac.type == ixgbe_mac_82599EB) { |
| 476 | txctrl = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL_82599(q)); | ||
| 422 | txctrl &= ~IXGBE_DCA_TXCTRL_CPUID_MASK_82599; | 477 | txctrl &= ~IXGBE_DCA_TXCTRL_CPUID_MASK_82599; |
| 423 | txctrl |= (dca3_get_tag(&adapter->pdev->dev, cpu) << | 478 | txctrl |= (dca3_get_tag(&adapter->pdev->dev, cpu) << |
| 424 | IXGBE_DCA_TXCTRL_CPUID_SHIFT_82599); | 479 | IXGBE_DCA_TXCTRL_CPUID_SHIFT_82599); |
| 480 | txctrl |= IXGBE_DCA_TXCTRL_DESC_DCA_EN; | ||
| 481 | IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(q), txctrl); | ||
| 425 | } | 482 | } |
| 426 | txctrl |= IXGBE_DCA_TXCTRL_DESC_DCA_EN; | ||
| 427 | IXGBE_WRITE_REG(&adapter->hw, IXGBE_DCA_TXCTRL(q), txctrl); | ||
| 428 | tx_ring->cpu = cpu; | 483 | tx_ring->cpu = cpu; |
| 429 | } | 484 | } |
| 430 | put_cpu(); | 485 | put_cpu(); |
| @@ -1913,11 +1968,25 @@ static void ixgbe_configure_tx(struct ixgbe_adapter *adapter) | |||
| 1913 | break; | 1968 | break; |
| 1914 | } | 1969 | } |
| 1915 | } | 1970 | } |
| 1971 | |||
| 1916 | if (hw->mac.type == ixgbe_mac_82599EB) { | 1972 | if (hw->mac.type == ixgbe_mac_82599EB) { |
| 1973 | u32 rttdcs; | ||
| 1974 | |||
| 1975 | /* disable the arbiter while setting MTQC */ | ||
| 1976 | rttdcs = IXGBE_READ_REG(hw, IXGBE_RTTDCS); | ||
| 1977 | rttdcs |= IXGBE_RTTDCS_ARBDIS; | ||
| 1978 | IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs); | ||
| 1979 | |||
| 1917 | /* We enable 8 traffic classes, DCB only */ | 1980 | /* We enable 8 traffic classes, DCB only */ |
| 1918 | if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) | 1981 | if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) |
| 1919 | IXGBE_WRITE_REG(hw, IXGBE_MTQC, (IXGBE_MTQC_RT_ENA | | 1982 | IXGBE_WRITE_REG(hw, IXGBE_MTQC, (IXGBE_MTQC_RT_ENA | |
| 1920 | IXGBE_MTQC_8TC_8TQ)); | 1983 | IXGBE_MTQC_8TC_8TQ)); |
| 1984 | else | ||
| 1985 | IXGBE_WRITE_REG(hw, IXGBE_MTQC, IXGBE_MTQC_64Q_1PB); | ||
| 1986 | |||
| 1987 | /* re-eable the arbiter */ | ||
| 1988 | rttdcs &= ~IXGBE_RTTDCS_ARBDIS; | ||
| 1989 | IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs); | ||
| 1921 | } | 1990 | } |
| 1922 | } | 1991 | } |
| 1923 | 1992 | ||
| @@ -2471,7 +2540,10 @@ static void ixgbe_configure(struct ixgbe_adapter *adapter) | |||
| 2471 | ixgbe_restore_vlan(adapter); | 2540 | ixgbe_restore_vlan(adapter); |
| 2472 | #ifdef CONFIG_IXGBE_DCB | 2541 | #ifdef CONFIG_IXGBE_DCB |
| 2473 | if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) { | 2542 | if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) { |
| 2474 | netif_set_gso_max_size(netdev, 32768); | 2543 | if (hw->mac.type == ixgbe_mac_82598EB) |
| 2544 | netif_set_gso_max_size(netdev, 32768); | ||
| 2545 | else | ||
| 2546 | netif_set_gso_max_size(netdev, 65536); | ||
| 2475 | ixgbe_configure_dcb(adapter); | 2547 | ixgbe_configure_dcb(adapter); |
| 2476 | } else { | 2548 | } else { |
| 2477 | netif_set_gso_max_size(netdev, 65536); | 2549 | netif_set_gso_max_size(netdev, 65536); |
diff --git a/drivers/net/macsonic.c b/drivers/net/macsonic.c index 61eabcac734c..b3d7d8d77f46 100644 --- a/drivers/net/macsonic.c +++ b/drivers/net/macsonic.c | |||
| @@ -223,69 +223,73 @@ static int __devinit macsonic_init(struct net_device *dev) | |||
| 223 | return 0; | 223 | return 0; |
| 224 | } | 224 | } |
| 225 | 225 | ||
| 226 | static int __devinit mac_onboard_sonic_ethernet_addr(struct net_device *dev) | 226 | #define INVALID_MAC(mac) (memcmp(mac, "\x08\x00\x07", 3) && \ |
| 227 | memcmp(mac, "\x00\xA0\x40", 3) && \ | ||
| 228 | memcmp(mac, "\x00\x80\x19", 3) && \ | ||
| 229 | memcmp(mac, "\x00\x05\x02", 3)) | ||
| 230 | |||
| 231 | static void __devinit mac_onboard_sonic_ethernet_addr(struct net_device *dev) | ||
| 227 | { | 232 | { |
| 228 | struct sonic_local *lp = netdev_priv(dev); | 233 | struct sonic_local *lp = netdev_priv(dev); |
| 229 | const int prom_addr = ONBOARD_SONIC_PROM_BASE; | 234 | const int prom_addr = ONBOARD_SONIC_PROM_BASE; |
| 230 | int i; | 235 | unsigned short val; |
| 231 | 236 | ||
| 232 | /* On NuBus boards we can sometimes look in the ROM resources. | 237 | /* |
| 233 | No such luck for comm-slot/onboard. */ | 238 | * On NuBus boards we can sometimes look in the ROM resources. |
| 234 | for(i = 0; i < 6; i++) | 239 | * No such luck for comm-slot/onboard. |
| 235 | dev->dev_addr[i] = SONIC_READ_PROM(i); | 240 | * On the PowerBook 520, the PROM base address is a mystery. |
| 241 | */ | ||
| 242 | if (hwreg_present((void *)prom_addr)) { | ||
| 243 | int i; | ||
| 244 | |||
| 245 | for (i = 0; i < 6; i++) | ||
| 246 | dev->dev_addr[i] = SONIC_READ_PROM(i); | ||
| 247 | if (!INVALID_MAC(dev->dev_addr)) | ||
| 248 | return; | ||
| 236 | 249 | ||
| 237 | /* Most of the time, the address is bit-reversed. The NetBSD | 250 | /* |
| 238 | source has a rather long and detailed historical account of | 251 | * Most of the time, the address is bit-reversed. The NetBSD |
| 239 | why this is so. */ | 252 | * source has a rather long and detailed historical account of |
| 240 | if (memcmp(dev->dev_addr, "\x08\x00\x07", 3) && | 253 | * why this is so. |
| 241 | memcmp(dev->dev_addr, "\x00\xA0\x40", 3) && | 254 | */ |
| 242 | memcmp(dev->dev_addr, "\x00\x80\x19", 3) && | ||
| 243 | memcmp(dev->dev_addr, "\x00\x05\x02", 3)) | ||
| 244 | bit_reverse_addr(dev->dev_addr); | 255 | bit_reverse_addr(dev->dev_addr); |
| 245 | else | 256 | if (!INVALID_MAC(dev->dev_addr)) |
| 246 | return 0; | 257 | return; |
| 247 | 258 | ||
| 248 | /* If we still have what seems to be a bogus address, we'll | ||
| 249 | look in the CAM. The top entry should be ours. */ | ||
| 250 | /* Danger! This only works if MacOS has already initialized | ||
| 251 | the card... */ | ||
| 252 | if (memcmp(dev->dev_addr, "\x08\x00\x07", 3) && | ||
| 253 | memcmp(dev->dev_addr, "\x00\xA0\x40", 3) && | ||
| 254 | memcmp(dev->dev_addr, "\x00\x80\x19", 3) && | ||
| 255 | memcmp(dev->dev_addr, "\x00\x05\x02", 3)) | ||
| 256 | { | ||
| 257 | unsigned short val; | ||
| 258 | |||
| 259 | printk(KERN_INFO "macsonic: PROM seems to be wrong, trying CAM entry 15\n"); | ||
| 260 | |||
| 261 | SONIC_WRITE(SONIC_CMD, SONIC_CR_RST); | ||
| 262 | SONIC_WRITE(SONIC_CEP, 15); | ||
| 263 | |||
| 264 | val = SONIC_READ(SONIC_CAP2); | ||
| 265 | dev->dev_addr[5] = val >> 8; | ||
| 266 | dev->dev_addr[4] = val & 0xff; | ||
| 267 | val = SONIC_READ(SONIC_CAP1); | ||
| 268 | dev->dev_addr[3] = val >> 8; | ||
| 269 | dev->dev_addr[2] = val & 0xff; | ||
| 270 | val = SONIC_READ(SONIC_CAP0); | ||
| 271 | dev->dev_addr[1] = val >> 8; | ||
| 272 | dev->dev_addr[0] = val & 0xff; | ||
| 273 | |||
| 274 | printk(KERN_INFO "HW Address from CAM 15: %pM\n", | ||
| 275 | dev->dev_addr); | ||
| 276 | } else return 0; | ||
| 277 | |||
| 278 | if (memcmp(dev->dev_addr, "\x08\x00\x07", 3) && | ||
| 279 | memcmp(dev->dev_addr, "\x00\xA0\x40", 3) && | ||
| 280 | memcmp(dev->dev_addr, "\x00\x80\x19", 3) && | ||
| 281 | memcmp(dev->dev_addr, "\x00\x05\x02", 3)) | ||
| 282 | { | ||
| 283 | /* | 259 | /* |
| 284 | * Still nonsense ... messed up someplace! | 260 | * If we still have what seems to be a bogus address, we'll |
| 261 | * look in the CAM. The top entry should be ours. | ||
| 285 | */ | 262 | */ |
| 286 | printk(KERN_ERR "macsonic: ERROR (INVALID MAC)\n"); | 263 | printk(KERN_WARNING "macsonic: MAC address in PROM seems " |
| 287 | return -EIO; | 264 | "to be invalid, trying CAM\n"); |
| 288 | } else return 0; | 265 | } else { |
| 266 | printk(KERN_WARNING "macsonic: cannot read MAC address from " | ||
| 267 | "PROM, trying CAM\n"); | ||
| 268 | } | ||
| 269 | |||
| 270 | /* This only works if MacOS has already initialized the card. */ | ||
| 271 | |||
| 272 | SONIC_WRITE(SONIC_CMD, SONIC_CR_RST); | ||
| 273 | SONIC_WRITE(SONIC_CEP, 15); | ||
| 274 | |||
| 275 | val = SONIC_READ(SONIC_CAP2); | ||
| 276 | dev->dev_addr[5] = val >> 8; | ||
| 277 | dev->dev_addr[4] = val & 0xff; | ||
| 278 | val = SONIC_READ(SONIC_CAP1); | ||
| 279 | dev->dev_addr[3] = val >> 8; | ||
| 280 | dev->dev_addr[2] = val & 0xff; | ||
| 281 | val = SONIC_READ(SONIC_CAP0); | ||
| 282 | dev->dev_addr[1] = val >> 8; | ||
| 283 | dev->dev_addr[0] = val & 0xff; | ||
| 284 | |||
| 285 | if (!INVALID_MAC(dev->dev_addr)) | ||
| 286 | return; | ||
| 287 | |||
| 288 | /* Still nonsense ... messed up someplace! */ | ||
| 289 | |||
| 290 | printk(KERN_WARNING "macsonic: MAC address in CAM entry 15 " | ||
| 291 | "seems invalid, will use a random MAC\n"); | ||
| 292 | random_ether_addr(dev->dev_addr); | ||
| 289 | } | 293 | } |
| 290 | 294 | ||
| 291 | static int __devinit mac_onboard_sonic_probe(struct net_device *dev) | 295 | static int __devinit mac_onboard_sonic_probe(struct net_device *dev) |
| @@ -402,8 +406,7 @@ static int __devinit mac_onboard_sonic_probe(struct net_device *dev) | |||
| 402 | SONIC_WRITE(SONIC_ISR, 0x7fff); | 406 | SONIC_WRITE(SONIC_ISR, 0x7fff); |
| 403 | 407 | ||
| 404 | /* Now look for the MAC address. */ | 408 | /* Now look for the MAC address. */ |
| 405 | if (mac_onboard_sonic_ethernet_addr(dev) != 0) | 409 | mac_onboard_sonic_ethernet_addr(dev); |
| 406 | return -ENODEV; | ||
| 407 | 410 | ||
| 408 | /* Shared init code */ | 411 | /* Shared init code */ |
| 409 | return macsonic_init(dev); | 412 | return macsonic_init(dev); |
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c index cea7531f4f40..a2fc70a0d0cc 100644 --- a/drivers/net/qlge/qlge_main.c +++ b/drivers/net/qlge/qlge_main.c | |||
| @@ -3916,6 +3916,8 @@ static int __devinit ql_init_device(struct pci_dev *pdev, | |||
| 3916 | goto err_out; | 3916 | goto err_out; |
| 3917 | } | 3917 | } |
| 3918 | 3918 | ||
| 3919 | /* Set PCIe reset type for EEH to fundamental. */ | ||
| 3920 | pdev->needs_freset = 1; | ||
| 3919 | pci_save_state(pdev); | 3921 | pci_save_state(pdev); |
| 3920 | qdev->reg_base = | 3922 | qdev->reg_base = |
| 3921 | ioremap_nocache(pci_resource_start(pdev, 1), | 3923 | ioremap_nocache(pci_resource_start(pdev, 1), |
diff --git a/drivers/net/qlge/qlge_mpi.c b/drivers/net/qlge/qlge_mpi.c index bcf13c96f73f..aec05f266107 100644 --- a/drivers/net/qlge/qlge_mpi.c +++ b/drivers/net/qlge/qlge_mpi.c | |||
| @@ -499,7 +499,7 @@ static int ql_mailbox_command(struct ql_adapter *qdev, struct mbox_params *mbcp) | |||
| 499 | /* Wait for the interrupt to come in. */ | 499 | /* Wait for the interrupt to come in. */ |
| 500 | status = ql_wait_mbx_cmd_cmplt(qdev); | 500 | status = ql_wait_mbx_cmd_cmplt(qdev); |
| 501 | if (status) | 501 | if (status) |
| 502 | goto end; | 502 | continue; |
| 503 | 503 | ||
| 504 | /* Process the event. If it's an AEN, it | 504 | /* Process the event. If it's an AEN, it |
| 505 | * will be handled in-line or a worker | 505 | * will be handled in-line or a worker |
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index c47237c2d638..32d93564a74d 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig | |||
| @@ -174,7 +174,7 @@ config USB_NET_CDCETHER | |||
| 174 | * Ericsson Mobile Broadband Module (all variants) | 174 | * Ericsson Mobile Broadband Module (all variants) |
| 175 | * Motorola (DM100 and SB4100) | 175 | * Motorola (DM100 and SB4100) |
| 176 | * Broadcom Cable Modem (reference design) | 176 | * Broadcom Cable Modem (reference design) |
| 177 | * Toshiba (PCX1100U and F3507g) | 177 | * Toshiba (PCX1100U and F3507g/F3607gw) |
| 178 | * ... | 178 | * ... |
| 179 | 179 | ||
| 180 | This driver creates an interface named "ethX", where X depends on | 180 | This driver creates an interface named "ethX", where X depends on |
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 4a6aff579403..21e1ba160008 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c | |||
| @@ -544,20 +544,60 @@ static const struct usb_device_id products [] = { | |||
| 544 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | 544 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), |
| 545 | .driver_info = (unsigned long) &cdc_info, | 545 | .driver_info = (unsigned long) &cdc_info, |
| 546 | }, { | 546 | }, { |
| 547 | /* Ericsson F3307 */ | 547 | /* Ericsson F3607gw ver 2 */ |
| 548 | USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1905, USB_CLASS_COMM, | ||
| 549 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 550 | .driver_info = (unsigned long) &cdc_info, | ||
| 551 | }, { | ||
| 552 | /* Ericsson F3607gw ver 3 */ | ||
| 548 | USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1906, USB_CLASS_COMM, | 553 | USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1906, USB_CLASS_COMM, |
| 549 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | 554 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), |
| 550 | .driver_info = (unsigned long) &cdc_info, | 555 | .driver_info = (unsigned long) &cdc_info, |
| 551 | }, { | 556 | }, { |
| 557 | /* Ericsson F3307 */ | ||
| 558 | USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x190a, USB_CLASS_COMM, | ||
| 559 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 560 | .driver_info = (unsigned long) &cdc_info, | ||
| 561 | }, { | ||
| 562 | /* Ericsson F3307 ver 2 */ | ||
| 563 | USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1909, USB_CLASS_COMM, | ||
| 564 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 565 | .driver_info = (unsigned long) &cdc_info, | ||
| 566 | }, { | ||
| 567 | /* Ericsson C3607w */ | ||
| 568 | USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1049, USB_CLASS_COMM, | ||
| 569 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 570 | .driver_info = (unsigned long) &cdc_info, | ||
| 571 | }, { | ||
| 552 | /* Toshiba F3507g */ | 572 | /* Toshiba F3507g */ |
| 553 | USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x130b, USB_CLASS_COMM, | 573 | USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x130b, USB_CLASS_COMM, |
| 554 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | 574 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), |
| 555 | .driver_info = (unsigned long) &cdc_info, | 575 | .driver_info = (unsigned long) &cdc_info, |
| 556 | }, { | 576 | }, { |
| 577 | /* Toshiba F3607gw */ | ||
| 578 | USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x130c, USB_CLASS_COMM, | ||
| 579 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 580 | .driver_info = (unsigned long) &cdc_info, | ||
| 581 | }, { | ||
| 582 | /* Toshiba F3607gw ver 2 */ | ||
| 583 | USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x1311, USB_CLASS_COMM, | ||
| 584 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 585 | .driver_info = (unsigned long) &cdc_info, | ||
| 586 | }, { | ||
| 557 | /* Dell F3507g */ | 587 | /* Dell F3507g */ |
| 558 | USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8147, USB_CLASS_COMM, | 588 | USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8147, USB_CLASS_COMM, |
| 559 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | 589 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), |
| 560 | .driver_info = (unsigned long) &cdc_info, | 590 | .driver_info = (unsigned long) &cdc_info, |
| 591 | }, { | ||
| 592 | /* Dell F3607gw */ | ||
| 593 | USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8183, USB_CLASS_COMM, | ||
| 594 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 595 | .driver_info = (unsigned long) &cdc_info, | ||
| 596 | }, { | ||
| 597 | /* Dell F3607gw ver 2 */ | ||
| 598 | USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8184, USB_CLASS_COMM, | ||
| 599 | USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), | ||
| 600 | .driver_info = (unsigned long) &cdc_info, | ||
| 561 | }, | 601 | }, |
| 562 | { }, // END | 602 | { }, // END |
| 563 | }; | 603 | }; |
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 05630f2f6930..b9e002fccbca 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c | |||
| @@ -998,7 +998,7 @@ static unsigned int features[] = { | |||
| 998 | VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, | 998 | VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, |
| 999 | }; | 999 | }; |
| 1000 | 1000 | ||
| 1001 | static struct virtio_driver virtio_net = { | 1001 | static struct virtio_driver virtio_net_driver = { |
| 1002 | .feature_table = features, | 1002 | .feature_table = features, |
| 1003 | .feature_table_size = ARRAY_SIZE(features), | 1003 | .feature_table_size = ARRAY_SIZE(features), |
| 1004 | .driver.name = KBUILD_MODNAME, | 1004 | .driver.name = KBUILD_MODNAME, |
| @@ -1011,12 +1011,12 @@ static struct virtio_driver virtio_net = { | |||
| 1011 | 1011 | ||
| 1012 | static int __init init(void) | 1012 | static int __init init(void) |
| 1013 | { | 1013 | { |
| 1014 | return register_virtio_driver(&virtio_net); | 1014 | return register_virtio_driver(&virtio_net_driver); |
| 1015 | } | 1015 | } |
| 1016 | 1016 | ||
| 1017 | static void __exit fini(void) | 1017 | static void __exit fini(void) |
| 1018 | { | 1018 | { |
| 1019 | unregister_virtio_driver(&virtio_net); | 1019 | unregister_virtio_driver(&virtio_net_driver); |
| 1020 | } | 1020 | } |
| 1021 | module_init(init); | 1021 | module_init(init); |
| 1022 | module_exit(fini); | 1022 | module_exit(fini); |
diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c index a741d37fd96f..240cff1e6979 100644 --- a/drivers/net/wireless/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/ipw2x00/ipw2100.c | |||
| @@ -6325,10 +6325,8 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev, | |||
| 6325 | 6325 | ||
| 6326 | fail: | 6326 | fail: |
| 6327 | if (dev) { | 6327 | if (dev) { |
| 6328 | if (registered) { | 6328 | if (registered) |
| 6329 | unregister_ieee80211(priv->ieee); | ||
| 6330 | unregister_netdev(dev); | 6329 | unregister_netdev(dev); |
| 6331 | } | ||
| 6332 | 6330 | ||
| 6333 | ipw2100_hw_stop_adapter(priv); | 6331 | ipw2100_hw_stop_adapter(priv); |
| 6334 | 6332 | ||
| @@ -6385,7 +6383,6 @@ static void __devexit ipw2100_pci_remove_one(struct pci_dev *pci_dev) | |||
| 6385 | /* Unregister the device first - this results in close() | 6383 | /* Unregister the device first - this results in close() |
| 6386 | * being called if the device is open. If we free storage | 6384 | * being called if the device is open. If we free storage |
| 6387 | * first, then close() will crash. */ | 6385 | * first, then close() will crash. */ |
| 6388 | unregister_ieee80211(priv->ieee); | ||
| 6389 | unregister_netdev(dev); | 6386 | unregister_netdev(dev); |
| 6390 | 6387 | ||
| 6391 | /* ipw2100_down will ensure that there is no more pending work | 6388 | /* ipw2100_down will ensure that there is no more pending work |
diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c index 9b0f2c0646e0..827824d45de9 100644 --- a/drivers/net/wireless/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/ipw2x00/ipw2200.c | |||
| @@ -11822,7 +11822,6 @@ static int __devinit ipw_pci_probe(struct pci_dev *pdev, | |||
| 11822 | if (err) { | 11822 | if (err) { |
| 11823 | IPW_ERROR("Failed to register promiscuous network " | 11823 | IPW_ERROR("Failed to register promiscuous network " |
| 11824 | "device (error %d).\n", err); | 11824 | "device (error %d).\n", err); |
| 11825 | unregister_ieee80211(priv->ieee); | ||
| 11826 | unregister_netdev(priv->net_dev); | 11825 | unregister_netdev(priv->net_dev); |
| 11827 | goto out_remove_sysfs; | 11826 | goto out_remove_sysfs; |
| 11828 | } | 11827 | } |
| @@ -11873,7 +11872,6 @@ static void __devexit ipw_pci_remove(struct pci_dev *pdev) | |||
| 11873 | 11872 | ||
| 11874 | mutex_unlock(&priv->mutex); | 11873 | mutex_unlock(&priv->mutex); |
| 11875 | 11874 | ||
| 11876 | unregister_ieee80211(priv->ieee); | ||
| 11877 | unregister_netdev(priv->net_dev); | 11875 | unregister_netdev(priv->net_dev); |
| 11878 | 11876 | ||
| 11879 | if (priv->rxq) { | 11877 | if (priv->rxq) { |
diff --git a/drivers/net/wireless/ipw2x00/libipw.h b/drivers/net/wireless/ipw2x00/libipw.h index f42ade6c2d3e..bf45391172f3 100644 --- a/drivers/net/wireless/ipw2x00/libipw.h +++ b/drivers/net/wireless/ipw2x00/libipw.h | |||
| @@ -1020,7 +1020,6 @@ static inline int libipw_is_cck_rate(u8 rate) | |||
| 1020 | /* ieee80211.c */ | 1020 | /* ieee80211.c */ |
| 1021 | extern void free_ieee80211(struct net_device *dev, int monitor); | 1021 | extern void free_ieee80211(struct net_device *dev, int monitor); |
| 1022 | extern struct net_device *alloc_ieee80211(int sizeof_priv, int monitor); | 1022 | extern struct net_device *alloc_ieee80211(int sizeof_priv, int monitor); |
| 1023 | extern void unregister_ieee80211(struct libipw_device *ieee); | ||
| 1024 | extern int libipw_change_mtu(struct net_device *dev, int new_mtu); | 1023 | extern int libipw_change_mtu(struct net_device *dev, int new_mtu); |
| 1025 | 1024 | ||
| 1026 | extern void libipw_networks_age(struct libipw_device *ieee, | 1025 | extern void libipw_networks_age(struct libipw_device *ieee, |
diff --git a/drivers/net/wireless/ipw2x00/libipw_module.c b/drivers/net/wireless/ipw2x00/libipw_module.c index be5b809ec97a..a0e9f6aed7da 100644 --- a/drivers/net/wireless/ipw2x00/libipw_module.c +++ b/drivers/net/wireless/ipw2x00/libipw_module.c | |||
| @@ -235,19 +235,16 @@ void free_ieee80211(struct net_device *dev, int monitor) | |||
| 235 | libipw_networks_free(ieee); | 235 | libipw_networks_free(ieee); |
| 236 | 236 | ||
| 237 | /* free cfg80211 resources */ | 237 | /* free cfg80211 resources */ |
| 238 | if (!monitor) | 238 | if (!monitor) { |
| 239 | wiphy_unregister(ieee->wdev.wiphy); | ||
| 240 | kfree(ieee->a_band.channels); | ||
| 241 | kfree(ieee->bg_band.channels); | ||
| 239 | wiphy_free(ieee->wdev.wiphy); | 242 | wiphy_free(ieee->wdev.wiphy); |
| 243 | } | ||
| 240 | 244 | ||
| 241 | free_netdev(dev); | 245 | free_netdev(dev); |
| 242 | } | 246 | } |
| 243 | 247 | ||
| 244 | void unregister_ieee80211(struct libipw_device *ieee) | ||
| 245 | { | ||
| 246 | wiphy_unregister(ieee->wdev.wiphy); | ||
| 247 | kfree(ieee->a_band.channels); | ||
| 248 | kfree(ieee->bg_band.channels); | ||
| 249 | } | ||
| 250 | |||
| 251 | #ifdef CONFIG_LIBIPW_DEBUG | 248 | #ifdef CONFIG_LIBIPW_DEBUG |
| 252 | 249 | ||
| 253 | static int debug = 0; | 250 | static int debug = 0; |
| @@ -333,4 +330,3 @@ module_init(libipw_init); | |||
| 333 | 330 | ||
| 334 | EXPORT_SYMBOL(alloc_ieee80211); | 331 | EXPORT_SYMBOL(alloc_ieee80211); |
| 335 | EXPORT_SYMBOL(free_ieee80211); | 332 | EXPORT_SYMBOL(free_ieee80211); |
| 336 | EXPORT_SYMBOL(unregister_ieee80211); | ||
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c index 71761b343839..73bbec58341e 100644 --- a/drivers/net/wireless/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c | |||
| @@ -815,6 +815,8 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev) | |||
| 815 | 815 | ||
| 816 | mutex_init(&rt2x00dev->csr_mutex); | 816 | mutex_init(&rt2x00dev->csr_mutex); |
| 817 | 817 | ||
| 818 | set_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags); | ||
| 819 | |||
| 818 | /* | 820 | /* |
| 819 | * Make room for rt2x00_intf inside the per-interface | 821 | * Make room for rt2x00_intf inside the per-interface |
| 820 | * structure ieee80211_vif. | 822 | * structure ieee80211_vif. |
| @@ -871,8 +873,6 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev) | |||
| 871 | rt2x00leds_register(rt2x00dev); | 873 | rt2x00leds_register(rt2x00dev); |
| 872 | rt2x00debug_register(rt2x00dev); | 874 | rt2x00debug_register(rt2x00dev); |
| 873 | 875 | ||
| 874 | set_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags); | ||
| 875 | |||
| 876 | return 0; | 876 | return 0; |
| 877 | 877 | ||
| 878 | exit: | 878 | exit: |
diff --git a/drivers/net/wireless/rt2x00/rt2x00link.c b/drivers/net/wireless/rt2x00/rt2x00link.c index c64db0ba7f40..c708d0be9155 100644 --- a/drivers/net/wireless/rt2x00/rt2x00link.c +++ b/drivers/net/wireless/rt2x00/rt2x00link.c | |||
| @@ -362,8 +362,9 @@ void rt2x00link_start_tuner(struct rt2x00_dev *rt2x00dev) | |||
| 362 | 362 | ||
| 363 | rt2x00link_reset_tuner(rt2x00dev, false); | 363 | rt2x00link_reset_tuner(rt2x00dev, false); |
| 364 | 364 | ||
| 365 | ieee80211_queue_delayed_work(rt2x00dev->hw, | 365 | if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags)) |
| 366 | &link->work, LINK_TUNE_INTERVAL); | 366 | ieee80211_queue_delayed_work(rt2x00dev->hw, |
| 367 | &link->work, LINK_TUNE_INTERVAL); | ||
| 367 | } | 368 | } |
| 368 | 369 | ||
| 369 | void rt2x00link_stop_tuner(struct rt2x00_dev *rt2x00dev) | 370 | void rt2x00link_stop_tuner(struct rt2x00_dev *rt2x00dev) |
| @@ -469,8 +470,10 @@ static void rt2x00link_tuner(struct work_struct *work) | |||
| 469 | * Increase tuner counter, and reschedule the next link tuner run. | 470 | * Increase tuner counter, and reschedule the next link tuner run. |
| 470 | */ | 471 | */ |
| 471 | link->count++; | 472 | link->count++; |
| 472 | ieee80211_queue_delayed_work(rt2x00dev->hw, | 473 | |
| 473 | &link->work, LINK_TUNE_INTERVAL); | 474 | if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags)) |
| 475 | ieee80211_queue_delayed_work(rt2x00dev->hw, | ||
| 476 | &link->work, LINK_TUNE_INTERVAL); | ||
| 474 | } | 477 | } |
| 475 | 478 | ||
| 476 | void rt2x00link_register(struct rt2x00_dev *rt2x00dev) | 479 | void rt2x00link_register(struct rt2x00_dev *rt2x00dev) |
diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c index 501544882c2c..f02b48a90593 100644 --- a/drivers/net/wireless/rt2x00/rt2x00usb.c +++ b/drivers/net/wireless/rt2x00/rt2x00usb.c | |||
| @@ -47,6 +47,8 @@ int rt2x00usb_vendor_request(struct rt2x00_dev *rt2x00dev, | |||
| 47 | (requesttype == USB_VENDOR_REQUEST_IN) ? | 47 | (requesttype == USB_VENDOR_REQUEST_IN) ? |
| 48 | usb_rcvctrlpipe(usb_dev, 0) : usb_sndctrlpipe(usb_dev, 0); | 48 | usb_rcvctrlpipe(usb_dev, 0) : usb_sndctrlpipe(usb_dev, 0); |
| 49 | 49 | ||
| 50 | if (!test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags)) | ||
| 51 | return -ENODEV; | ||
| 50 | 52 | ||
| 51 | for (i = 0; i < REGISTER_BUSY_COUNT; i++) { | 53 | for (i = 0; i < REGISTER_BUSY_COUNT; i++) { |
| 52 | status = usb_control_msg(usb_dev, pipe, request, requesttype, | 54 | status = usb_control_msg(usb_dev, pipe, request, requesttype, |
| @@ -60,8 +62,10 @@ int rt2x00usb_vendor_request(struct rt2x00_dev *rt2x00dev, | |||
| 60 | * -ENODEV: Device has disappeared, no point continuing. | 62 | * -ENODEV: Device has disappeared, no point continuing. |
| 61 | * All other errors: Try again. | 63 | * All other errors: Try again. |
| 62 | */ | 64 | */ |
| 63 | else if (status == -ENODEV) | 65 | else if (status == -ENODEV) { |
| 66 | clear_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags); | ||
| 64 | break; | 67 | break; |
| 68 | } | ||
| 65 | } | 69 | } |
| 66 | 70 | ||
| 67 | ERROR(rt2x00dev, | 71 | ERROR(rt2x00dev, |
| @@ -161,6 +165,9 @@ int rt2x00usb_regbusy_read(struct rt2x00_dev *rt2x00dev, | |||
| 161 | { | 165 | { |
| 162 | unsigned int i; | 166 | unsigned int i; |
| 163 | 167 | ||
| 168 | if (!test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags)) | ||
| 169 | return -ENODEV; | ||
| 170 | |||
| 164 | for (i = 0; i < REGISTER_BUSY_COUNT; i++) { | 171 | for (i = 0; i < REGISTER_BUSY_COUNT; i++) { |
| 165 | rt2x00usb_register_read_lock(rt2x00dev, offset, reg); | 172 | rt2x00usb_register_read_lock(rt2x00dev, offset, reg); |
| 166 | if (!rt2x00_get_field32(*reg, field)) | 173 | if (!rt2x00_get_field32(*reg, field)) |
diff --git a/drivers/net/wireless/rtl818x/rtl8187_leds.c b/drivers/net/wireless/rtl818x/rtl8187_leds.c index a1c670fc1552..cf8a4a40fdf6 100644 --- a/drivers/net/wireless/rtl818x/rtl8187_leds.c +++ b/drivers/net/wireless/rtl818x/rtl8187_leds.c | |||
| @@ -210,10 +210,10 @@ void rtl8187_leds_exit(struct ieee80211_hw *dev) | |||
| 210 | 210 | ||
| 211 | /* turn the LED off before exiting */ | 211 | /* turn the LED off before exiting */ |
| 212 | ieee80211_queue_delayed_work(dev, &priv->led_off, 0); | 212 | ieee80211_queue_delayed_work(dev, &priv->led_off, 0); |
| 213 | cancel_delayed_work_sync(&priv->led_off); | ||
| 214 | cancel_delayed_work_sync(&priv->led_on); | ||
| 215 | rtl8187_unregister_led(&priv->led_rx); | 213 | rtl8187_unregister_led(&priv->led_rx); |
| 216 | rtl8187_unregister_led(&priv->led_tx); | 214 | rtl8187_unregister_led(&priv->led_tx); |
| 215 | cancel_delayed_work_sync(&priv->led_off); | ||
| 216 | cancel_delayed_work_sync(&priv->led_on); | ||
| 217 | } | 217 | } |
| 218 | #endif /* def CONFIG_RTL8187_LED */ | 218 | #endif /* def CONFIG_RTL8187_LED */ |
| 219 | 219 | ||
diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h index cbdd6284996d..5cf7270e3ffc 100644 --- a/include/net/netfilter/nf_conntrack.h +++ b/include/net/netfilter/nf_conntrack.h | |||
| @@ -255,11 +255,9 @@ static inline bool nf_ct_kill(struct nf_conn *ct) | |||
| 255 | } | 255 | } |
| 256 | 256 | ||
| 257 | /* These are for NAT. Icky. */ | 257 | /* These are for NAT. Icky. */ |
| 258 | /* Update TCP window tracking data when NAT mangles the packet */ | 258 | extern s16 (*nf_ct_nat_offset)(const struct nf_conn *ct, |
| 259 | extern void nf_conntrack_tcp_update(const struct sk_buff *skb, | 259 | enum ip_conntrack_dir dir, |
| 260 | unsigned int dataoff, | 260 | u32 seq); |
| 261 | struct nf_conn *ct, int dir, | ||
| 262 | s16 offset); | ||
| 263 | 261 | ||
| 264 | /* Fake conntrack entry for untracked connections */ | 262 | /* Fake conntrack entry for untracked connections */ |
| 265 | extern struct nf_conn nf_conntrack_untracked; | 263 | extern struct nf_conn nf_conntrack_untracked; |
diff --git a/include/net/netfilter/nf_nat_helper.h b/include/net/netfilter/nf_nat_helper.h index 237a961f40e1..4222220920a5 100644 --- a/include/net/netfilter/nf_nat_helper.h +++ b/include/net/netfilter/nf_nat_helper.h | |||
| @@ -32,4 +32,8 @@ extern int (*nf_nat_seq_adjust_hook)(struct sk_buff *skb, | |||
| 32 | * to port ct->master->saved_proto. */ | 32 | * to port ct->master->saved_proto. */ |
| 33 | extern void nf_nat_follow_master(struct nf_conn *ct, | 33 | extern void nf_nat_follow_master(struct nf_conn *ct, |
| 34 | struct nf_conntrack_expect *this); | 34 | struct nf_conntrack_expect *this); |
| 35 | |||
| 36 | extern s16 nf_nat_get_offset(const struct nf_conn *ct, | ||
| 37 | enum ip_conntrack_dir dir, | ||
| 38 | u32 seq); | ||
| 35 | #endif | 39 | #endif |
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index b1b3b0fbf41c..4a9f52732655 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c | |||
| @@ -377,12 +377,16 @@ int br_add_if(struct net_bridge *br, struct net_device *dev) | |||
| 377 | struct net_bridge_port *p; | 377 | struct net_bridge_port *p; |
| 378 | int err = 0; | 378 | int err = 0; |
| 379 | 379 | ||
| 380 | if (dev->flags & IFF_LOOPBACK || dev->type != ARPHRD_ETHER) | 380 | /* Don't allow bridging non-ethernet like devices */ |
| 381 | if ((dev->flags & IFF_LOOPBACK) || | ||
| 382 | dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN) | ||
| 381 | return -EINVAL; | 383 | return -EINVAL; |
| 382 | 384 | ||
| 385 | /* No bridging of bridges */ | ||
| 383 | if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit) | 386 | if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit) |
| 384 | return -ELOOP; | 387 | return -ELOOP; |
| 385 | 388 | ||
| 389 | /* Device is already being bridged */ | ||
| 386 | if (dev->br_port != NULL) | 390 | if (dev->br_port != NULL) |
| 387 | return -EBUSY; | 391 | return -EBUSY; |
| 388 | 392 | ||
diff --git a/net/can/bcm.c b/net/can/bcm.c index 597da4f8f888..e8d58f33fe09 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c | |||
| @@ -132,23 +132,27 @@ static inline struct bcm_sock *bcm_sk(const struct sock *sk) | |||
| 132 | /* | 132 | /* |
| 133 | * procfs functions | 133 | * procfs functions |
| 134 | */ | 134 | */ |
| 135 | static char *bcm_proc_getifname(int ifindex) | 135 | static char *bcm_proc_getifname(char *result, int ifindex) |
| 136 | { | 136 | { |
| 137 | struct net_device *dev; | 137 | struct net_device *dev; |
| 138 | 138 | ||
| 139 | if (!ifindex) | 139 | if (!ifindex) |
| 140 | return "any"; | 140 | return "any"; |
| 141 | 141 | ||
| 142 | /* no usage counting */ | 142 | read_lock(&dev_base_lock); |
| 143 | dev = __dev_get_by_index(&init_net, ifindex); | 143 | dev = __dev_get_by_index(&init_net, ifindex); |
| 144 | if (dev) | 144 | if (dev) |
| 145 | return dev->name; | 145 | strcpy(result, dev->name); |
| 146 | else | ||
| 147 | strcpy(result, "???"); | ||
| 148 | read_unlock(&dev_base_lock); | ||
| 146 | 149 | ||
| 147 | return "???"; | 150 | return result; |
| 148 | } | 151 | } |
| 149 | 152 | ||
| 150 | static int bcm_proc_show(struct seq_file *m, void *v) | 153 | static int bcm_proc_show(struct seq_file *m, void *v) |
| 151 | { | 154 | { |
| 155 | char ifname[IFNAMSIZ]; | ||
| 152 | struct sock *sk = (struct sock *)m->private; | 156 | struct sock *sk = (struct sock *)m->private; |
| 153 | struct bcm_sock *bo = bcm_sk(sk); | 157 | struct bcm_sock *bo = bcm_sk(sk); |
| 154 | struct bcm_op *op; | 158 | struct bcm_op *op; |
| @@ -157,7 +161,7 @@ static int bcm_proc_show(struct seq_file *m, void *v) | |||
| 157 | seq_printf(m, " / sk %p", sk); | 161 | seq_printf(m, " / sk %p", sk); |
| 158 | seq_printf(m, " / bo %p", bo); | 162 | seq_printf(m, " / bo %p", bo); |
| 159 | seq_printf(m, " / dropped %lu", bo->dropped_usr_msgs); | 163 | seq_printf(m, " / dropped %lu", bo->dropped_usr_msgs); |
| 160 | seq_printf(m, " / bound %s", bcm_proc_getifname(bo->ifindex)); | 164 | seq_printf(m, " / bound %s", bcm_proc_getifname(ifname, bo->ifindex)); |
| 161 | seq_printf(m, " <<<\n"); | 165 | seq_printf(m, " <<<\n"); |
| 162 | 166 | ||
| 163 | list_for_each_entry(op, &bo->rx_ops, list) { | 167 | list_for_each_entry(op, &bo->rx_ops, list) { |
| @@ -169,7 +173,7 @@ static int bcm_proc_show(struct seq_file *m, void *v) | |||
| 169 | continue; | 173 | continue; |
| 170 | 174 | ||
| 171 | seq_printf(m, "rx_op: %03X %-5s ", | 175 | seq_printf(m, "rx_op: %03X %-5s ", |
| 172 | op->can_id, bcm_proc_getifname(op->ifindex)); | 176 | op->can_id, bcm_proc_getifname(ifname, op->ifindex)); |
| 173 | seq_printf(m, "[%d]%c ", op->nframes, | 177 | seq_printf(m, "[%d]%c ", op->nframes, |
| 174 | (op->flags & RX_CHECK_DLC)?'d':' '); | 178 | (op->flags & RX_CHECK_DLC)?'d':' '); |
| 175 | if (op->kt_ival1.tv64) | 179 | if (op->kt_ival1.tv64) |
| @@ -194,7 +198,8 @@ static int bcm_proc_show(struct seq_file *m, void *v) | |||
| 194 | list_for_each_entry(op, &bo->tx_ops, list) { | 198 | list_for_each_entry(op, &bo->tx_ops, list) { |
| 195 | 199 | ||
| 196 | seq_printf(m, "tx_op: %03X %s [%d] ", | 200 | seq_printf(m, "tx_op: %03X %s [%d] ", |
| 197 | op->can_id, bcm_proc_getifname(op->ifindex), | 201 | op->can_id, |
| 202 | bcm_proc_getifname(ifname, op->ifindex), | ||
| 198 | op->nframes); | 203 | op->nframes); |
| 199 | 204 | ||
| 200 | if (op->kt_ival1.tv64) | 205 | if (op->kt_ival1.tv64) |
diff --git a/net/decnet/sysctl_net_decnet.c b/net/decnet/sysctl_net_decnet.c index 26b0ab1e9f56..2036568beea9 100644 --- a/net/decnet/sysctl_net_decnet.c +++ b/net/decnet/sysctl_net_decnet.c | |||
| @@ -263,11 +263,10 @@ static int dn_def_dev_strategy(ctl_table *table, | |||
| 263 | return -ENODEV; | 263 | return -ENODEV; |
| 264 | 264 | ||
| 265 | rv = -ENODEV; | 265 | rv = -ENODEV; |
| 266 | if (dev->dn_ptr != NULL) { | 266 | if (dev->dn_ptr != NULL) |
| 267 | rv = dn_dev_set_default(dev, 1); | 267 | rv = dn_dev_set_default(dev, 1); |
| 268 | if (rv) | 268 | if (rv) |
| 269 | dev_put(dev); | 269 | dev_put(dev); |
| 270 | } | ||
| 271 | } | 270 | } |
| 272 | 271 | ||
| 273 | return rv; | 272 | return rv; |
diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 08ccd344de7a..ae40ed1ba560 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c | |||
| @@ -438,25 +438,27 @@ static netdev_tx_t ipip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev) | |||
| 438 | goto tx_error; | 438 | goto tx_error; |
| 439 | } | 439 | } |
| 440 | 440 | ||
| 441 | if (tiph->frag_off) | 441 | df |= old_iph->frag_off & htons(IP_DF); |
| 442 | |||
| 443 | if (df) { | ||
| 442 | mtu = dst_mtu(&rt->u.dst) - sizeof(struct iphdr); | 444 | mtu = dst_mtu(&rt->u.dst) - sizeof(struct iphdr); |
| 443 | else | ||
| 444 | mtu = skb_dst(skb) ? dst_mtu(skb_dst(skb)) : dev->mtu; | ||
| 445 | 445 | ||
| 446 | if (mtu < 68) { | 446 | if (mtu < 68) { |
| 447 | stats->collisions++; | 447 | stats->collisions++; |
| 448 | ip_rt_put(rt); | 448 | ip_rt_put(rt); |
| 449 | goto tx_error; | 449 | goto tx_error; |
| 450 | } | 450 | } |
| 451 | if (skb_dst(skb)) | ||
| 452 | skb_dst(skb)->ops->update_pmtu(skb_dst(skb), mtu); | ||
| 453 | 451 | ||
| 454 | df |= (old_iph->frag_off&htons(IP_DF)); | 452 | if (skb_dst(skb)) |
| 453 | skb_dst(skb)->ops->update_pmtu(skb_dst(skb), mtu); | ||
| 455 | 454 | ||
| 456 | if ((old_iph->frag_off&htons(IP_DF)) && mtu < ntohs(old_iph->tot_len)) { | 455 | if ((old_iph->frag_off & htons(IP_DF)) && |
| 457 | icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, htonl(mtu)); | 456 | mtu < ntohs(old_iph->tot_len)) { |
| 458 | ip_rt_put(rt); | 457 | icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, |
| 459 | goto tx_error; | 458 | htonl(mtu)); |
| 459 | ip_rt_put(rt); | ||
| 460 | goto tx_error; | ||
| 461 | } | ||
| 460 | } | 462 | } |
| 461 | 463 | ||
| 462 | if (tunnel->err_count > 0) { | 464 | if (tunnel->err_count > 0) { |
diff --git a/net/ipv4/netfilter/nf_nat_core.c b/net/ipv4/netfilter/nf_nat_core.c index 68afc6ecd343..fe1a64479dd0 100644 --- a/net/ipv4/netfilter/nf_nat_core.c +++ b/net/ipv4/netfilter/nf_nat_core.c | |||
| @@ -750,6 +750,8 @@ static int __init nf_nat_init(void) | |||
| 750 | BUG_ON(nfnetlink_parse_nat_setup_hook != NULL); | 750 | BUG_ON(nfnetlink_parse_nat_setup_hook != NULL); |
| 751 | rcu_assign_pointer(nfnetlink_parse_nat_setup_hook, | 751 | rcu_assign_pointer(nfnetlink_parse_nat_setup_hook, |
| 752 | nfnetlink_parse_nat_setup); | 752 | nfnetlink_parse_nat_setup); |
| 753 | BUG_ON(nf_ct_nat_offset != NULL); | ||
| 754 | rcu_assign_pointer(nf_ct_nat_offset, nf_nat_get_offset); | ||
| 753 | return 0; | 755 | return 0; |
| 754 | 756 | ||
| 755 | cleanup_extend: | 757 | cleanup_extend: |
| @@ -764,6 +766,7 @@ static void __exit nf_nat_cleanup(void) | |||
| 764 | nf_ct_extend_unregister(&nat_extend); | 766 | nf_ct_extend_unregister(&nat_extend); |
| 765 | rcu_assign_pointer(nf_nat_seq_adjust_hook, NULL); | 767 | rcu_assign_pointer(nf_nat_seq_adjust_hook, NULL); |
| 766 | rcu_assign_pointer(nfnetlink_parse_nat_setup_hook, NULL); | 768 | rcu_assign_pointer(nfnetlink_parse_nat_setup_hook, NULL); |
| 769 | rcu_assign_pointer(nf_ct_nat_offset, NULL); | ||
| 767 | synchronize_net(); | 770 | synchronize_net(); |
| 768 | } | 771 | } |
| 769 | 772 | ||
diff --git a/net/ipv4/netfilter/nf_nat_helper.c b/net/ipv4/netfilter/nf_nat_helper.c index 09172a65d9b6..f9520fa3aba9 100644 --- a/net/ipv4/netfilter/nf_nat_helper.c +++ b/net/ipv4/netfilter/nf_nat_helper.c | |||
| @@ -73,6 +73,28 @@ adjust_tcp_sequence(u32 seq, | |||
| 73 | DUMP_OFFSET(this_way); | 73 | DUMP_OFFSET(this_way); |
| 74 | } | 74 | } |
| 75 | 75 | ||
| 76 | /* Get the offset value, for conntrack */ | ||
| 77 | s16 nf_nat_get_offset(const struct nf_conn *ct, | ||
| 78 | enum ip_conntrack_dir dir, | ||
| 79 | u32 seq) | ||
| 80 | { | ||
| 81 | struct nf_conn_nat *nat = nfct_nat(ct); | ||
| 82 | struct nf_nat_seq *this_way; | ||
| 83 | s16 offset; | ||
| 84 | |||
| 85 | if (!nat) | ||
| 86 | return 0; | ||
| 87 | |||
| 88 | this_way = &nat->seq[dir]; | ||
| 89 | spin_lock_bh(&nf_nat_seqofs_lock); | ||
| 90 | offset = after(seq, this_way->correction_pos) | ||
| 91 | ? this_way->offset_after : this_way->offset_before; | ||
| 92 | spin_unlock_bh(&nf_nat_seqofs_lock); | ||
| 93 | |||
| 94 | return offset; | ||
| 95 | } | ||
| 96 | EXPORT_SYMBOL_GPL(nf_nat_get_offset); | ||
| 97 | |||
| 76 | /* Frobs data inside this packet, which is linear. */ | 98 | /* Frobs data inside this packet, which is linear. */ |
| 77 | static void mangle_contents(struct sk_buff *skb, | 99 | static void mangle_contents(struct sk_buff *skb, |
| 78 | unsigned int dataoff, | 100 | unsigned int dataoff, |
| @@ -189,11 +211,6 @@ nf_nat_mangle_tcp_packet(struct sk_buff *skb, | |||
| 189 | adjust_tcp_sequence(ntohl(tcph->seq), | 211 | adjust_tcp_sequence(ntohl(tcph->seq), |
| 190 | (int)rep_len - (int)match_len, | 212 | (int)rep_len - (int)match_len, |
| 191 | ct, ctinfo); | 213 | ct, ctinfo); |
| 192 | /* Tell TCP window tracking about seq change */ | ||
| 193 | nf_conntrack_tcp_update(skb, ip_hdrlen(skb), | ||
| 194 | ct, CTINFO2DIR(ctinfo), | ||
| 195 | (int)rep_len - (int)match_len); | ||
| 196 | |||
| 197 | nf_conntrack_event_cache(IPCT_NATSEQADJ, ct); | 214 | nf_conntrack_event_cache(IPCT_NATSEQADJ, ct); |
| 198 | } | 215 | } |
| 199 | return 1; | 216 | return 1; |
| @@ -415,12 +432,7 @@ nf_nat_seq_adjust(struct sk_buff *skb, | |||
| 415 | tcph->seq = newseq; | 432 | tcph->seq = newseq; |
| 416 | tcph->ack_seq = newack; | 433 | tcph->ack_seq = newack; |
| 417 | 434 | ||
| 418 | if (!nf_nat_sack_adjust(skb, tcph, ct, ctinfo)) | 435 | return nf_nat_sack_adjust(skb, tcph, ct, ctinfo); |
| 419 | return 0; | ||
| 420 | |||
| 421 | nf_conntrack_tcp_update(skb, ip_hdrlen(skb), ct, dir, seqoff); | ||
| 422 | |||
| 423 | return 1; | ||
| 424 | } | 436 | } |
| 425 | 437 | ||
| 426 | /* Setup NAT on this expected conntrack so it follows master. */ | 438 | /* Setup NAT on this expected conntrack so it follows master. */ |
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index ca6e68dcd8a8..b9168c1864ca 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c | |||
| @@ -1351,6 +1351,11 @@ err_stat: | |||
| 1351 | return ret; | 1351 | return ret; |
| 1352 | } | 1352 | } |
| 1353 | 1353 | ||
| 1354 | s16 (*nf_ct_nat_offset)(const struct nf_conn *ct, | ||
| 1355 | enum ip_conntrack_dir dir, | ||
| 1356 | u32 seq); | ||
| 1357 | EXPORT_SYMBOL_GPL(nf_ct_nat_offset); | ||
| 1358 | |||
| 1354 | int nf_conntrack_init(struct net *net) | 1359 | int nf_conntrack_init(struct net *net) |
| 1355 | { | 1360 | { |
| 1356 | int ret; | 1361 | int ret; |
| @@ -1368,6 +1373,9 @@ int nf_conntrack_init(struct net *net) | |||
| 1368 | /* For use by REJECT target */ | 1373 | /* For use by REJECT target */ |
| 1369 | rcu_assign_pointer(ip_ct_attach, nf_conntrack_attach); | 1374 | rcu_assign_pointer(ip_ct_attach, nf_conntrack_attach); |
| 1370 | rcu_assign_pointer(nf_ct_destroy, destroy_conntrack); | 1375 | rcu_assign_pointer(nf_ct_destroy, destroy_conntrack); |
| 1376 | |||
| 1377 | /* Howto get NAT offsets */ | ||
| 1378 | rcu_assign_pointer(nf_ct_nat_offset, NULL); | ||
| 1371 | } | 1379 | } |
| 1372 | return 0; | 1380 | return 0; |
| 1373 | 1381 | ||
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c b/net/netfilter/nf_conntrack_proto_tcp.c index 97a82ba75376..ba2b76937283 100644 --- a/net/netfilter/nf_conntrack_proto_tcp.c +++ b/net/netfilter/nf_conntrack_proto_tcp.c | |||
| @@ -492,6 +492,21 @@ static void tcp_sack(const struct sk_buff *skb, unsigned int dataoff, | |||
| 492 | } | 492 | } |
| 493 | } | 493 | } |
| 494 | 494 | ||
| 495 | #ifdef CONFIG_NF_NAT_NEEDED | ||
| 496 | static inline s16 nat_offset(const struct nf_conn *ct, | ||
| 497 | enum ip_conntrack_dir dir, | ||
| 498 | u32 seq) | ||
| 499 | { | ||
| 500 | typeof(nf_ct_nat_offset) get_offset = rcu_dereference(nf_ct_nat_offset); | ||
| 501 | |||
| 502 | return get_offset != NULL ? get_offset(ct, dir, seq) : 0; | ||
| 503 | } | ||
| 504 | #define NAT_OFFSET(pf, ct, dir, seq) \ | ||
| 505 | (pf == NFPROTO_IPV4 ? nat_offset(ct, dir, seq) : 0) | ||
| 506 | #else | ||
| 507 | #define NAT_OFFSET(pf, ct, dir, seq) 0 | ||
| 508 | #endif | ||
| 509 | |||
| 495 | static bool tcp_in_window(const struct nf_conn *ct, | 510 | static bool tcp_in_window(const struct nf_conn *ct, |
| 496 | struct ip_ct_tcp *state, | 511 | struct ip_ct_tcp *state, |
| 497 | enum ip_conntrack_dir dir, | 512 | enum ip_conntrack_dir dir, |
| @@ -506,6 +521,7 @@ static bool tcp_in_window(const struct nf_conn *ct, | |||
| 506 | struct ip_ct_tcp_state *receiver = &state->seen[!dir]; | 521 | struct ip_ct_tcp_state *receiver = &state->seen[!dir]; |
| 507 | const struct nf_conntrack_tuple *tuple = &ct->tuplehash[dir].tuple; | 522 | const struct nf_conntrack_tuple *tuple = &ct->tuplehash[dir].tuple; |
| 508 | __u32 seq, ack, sack, end, win, swin; | 523 | __u32 seq, ack, sack, end, win, swin; |
| 524 | s16 receiver_offset; | ||
| 509 | bool res; | 525 | bool res; |
| 510 | 526 | ||
| 511 | /* | 527 | /* |
| @@ -519,11 +535,16 @@ static bool tcp_in_window(const struct nf_conn *ct, | |||
| 519 | if (receiver->flags & IP_CT_TCP_FLAG_SACK_PERM) | 535 | if (receiver->flags & IP_CT_TCP_FLAG_SACK_PERM) |
| 520 | tcp_sack(skb, dataoff, tcph, &sack); | 536 | tcp_sack(skb, dataoff, tcph, &sack); |
| 521 | 537 | ||
| 538 | /* Take into account NAT sequence number mangling */ | ||
| 539 | receiver_offset = NAT_OFFSET(pf, ct, !dir, ack - 1); | ||
| 540 | ack -= receiver_offset; | ||
| 541 | sack -= receiver_offset; | ||
| 542 | |||
| 522 | pr_debug("tcp_in_window: START\n"); | 543 | pr_debug("tcp_in_window: START\n"); |
| 523 | pr_debug("tcp_in_window: "); | 544 | pr_debug("tcp_in_window: "); |
| 524 | nf_ct_dump_tuple(tuple); | 545 | nf_ct_dump_tuple(tuple); |
| 525 | pr_debug("seq=%u ack=%u sack=%u win=%u end=%u\n", | 546 | pr_debug("seq=%u ack=%u+(%d) sack=%u+(%d) win=%u end=%u\n", |
| 526 | seq, ack, sack, win, end); | 547 | seq, ack, receiver_offset, sack, receiver_offset, win, end); |
| 527 | pr_debug("tcp_in_window: sender end=%u maxend=%u maxwin=%u scale=%i " | 548 | pr_debug("tcp_in_window: sender end=%u maxend=%u maxwin=%u scale=%i " |
| 528 | "receiver end=%u maxend=%u maxwin=%u scale=%i\n", | 549 | "receiver end=%u maxend=%u maxwin=%u scale=%i\n", |
| 529 | sender->td_end, sender->td_maxend, sender->td_maxwin, | 550 | sender->td_end, sender->td_maxend, sender->td_maxwin, |
| @@ -613,8 +634,8 @@ static bool tcp_in_window(const struct nf_conn *ct, | |||
| 613 | 634 | ||
| 614 | pr_debug("tcp_in_window: "); | 635 | pr_debug("tcp_in_window: "); |
| 615 | nf_ct_dump_tuple(tuple); | 636 | nf_ct_dump_tuple(tuple); |
| 616 | pr_debug("seq=%u ack=%u sack =%u win=%u end=%u\n", | 637 | pr_debug("seq=%u ack=%u+(%d) sack=%u+(%d) win=%u end=%u\n", |
| 617 | seq, ack, sack, win, end); | 638 | seq, ack, receiver_offset, sack, receiver_offset, win, end); |
| 618 | pr_debug("tcp_in_window: sender end=%u maxend=%u maxwin=%u scale=%i " | 639 | pr_debug("tcp_in_window: sender end=%u maxend=%u maxwin=%u scale=%i " |
| 619 | "receiver end=%u maxend=%u maxwin=%u scale=%i\n", | 640 | "receiver end=%u maxend=%u maxwin=%u scale=%i\n", |
| 620 | sender->td_end, sender->td_maxend, sender->td_maxwin, | 641 | sender->td_end, sender->td_maxend, sender->td_maxwin, |
| @@ -700,7 +721,7 @@ static bool tcp_in_window(const struct nf_conn *ct, | |||
| 700 | before(seq, sender->td_maxend + 1) ? | 721 | before(seq, sender->td_maxend + 1) ? |
| 701 | after(end, sender->td_end - receiver->td_maxwin - 1) ? | 722 | after(end, sender->td_end - receiver->td_maxwin - 1) ? |
| 702 | before(sack, receiver->td_end + 1) ? | 723 | before(sack, receiver->td_end + 1) ? |
| 703 | after(ack, receiver->td_end - MAXACKWINDOW(sender)) ? "BUG" | 724 | after(sack, receiver->td_end - MAXACKWINDOW(sender) - 1) ? "BUG" |
| 704 | : "ACK is under the lower bound (possible overly delayed ACK)" | 725 | : "ACK is under the lower bound (possible overly delayed ACK)" |
| 705 | : "ACK is over the upper bound (ACKed data not seen yet)" | 726 | : "ACK is over the upper bound (ACKed data not seen yet)" |
| 706 | : "SEQ is under the lower bound (already ACKed data retransmitted)" | 727 | : "SEQ is under the lower bound (already ACKed data retransmitted)" |
| @@ -715,39 +736,6 @@ static bool tcp_in_window(const struct nf_conn *ct, | |||
| 715 | return res; | 736 | return res; |
| 716 | } | 737 | } |
| 717 | 738 | ||
| 718 | #ifdef CONFIG_NF_NAT_NEEDED | ||
| 719 | /* Update sender->td_end after NAT successfully mangled the packet */ | ||
| 720 | /* Caller must linearize skb at tcp header. */ | ||
| 721 | void nf_conntrack_tcp_update(const struct sk_buff *skb, | ||
| 722 | unsigned int dataoff, | ||
| 723 | struct nf_conn *ct, int dir, | ||
| 724 | s16 offset) | ||
| 725 | { | ||
| 726 | const struct tcphdr *tcph = (const void *)skb->data + dataoff; | ||
| 727 | const struct ip_ct_tcp_state *sender = &ct->proto.tcp.seen[dir]; | ||
| 728 | const struct ip_ct_tcp_state *receiver = &ct->proto.tcp.seen[!dir]; | ||
| 729 | __u32 end; | ||
| 730 | |||
| 731 | end = segment_seq_plus_len(ntohl(tcph->seq), skb->len, dataoff, tcph); | ||
| 732 | |||
| 733 | spin_lock_bh(&ct->lock); | ||
| 734 | /* | ||
| 735 | * We have to worry for the ack in the reply packet only... | ||
| 736 | */ | ||
| 737 | if (ct->proto.tcp.seen[dir].td_end + offset == end) | ||
| 738 | ct->proto.tcp.seen[dir].td_end = end; | ||
| 739 | ct->proto.tcp.last_end = end; | ||
| 740 | spin_unlock_bh(&ct->lock); | ||
| 741 | pr_debug("tcp_update: sender end=%u maxend=%u maxwin=%u scale=%i " | ||
| 742 | "receiver end=%u maxend=%u maxwin=%u scale=%i\n", | ||
| 743 | sender->td_end, sender->td_maxend, sender->td_maxwin, | ||
| 744 | sender->td_scale, | ||
| 745 | receiver->td_end, receiver->td_maxend, receiver->td_maxwin, | ||
| 746 | receiver->td_scale); | ||
| 747 | } | ||
| 748 | EXPORT_SYMBOL_GPL(nf_conntrack_tcp_update); | ||
| 749 | #endif | ||
| 750 | |||
| 751 | #define TH_FIN 0x01 | 739 | #define TH_FIN 0x01 |
| 752 | #define TH_SYN 0x02 | 740 | #define TH_SYN 0x02 |
| 753 | #define TH_RST 0x04 | 741 | #define TH_RST 0x04 |
diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c index 680980954395..38f03f75a636 100644 --- a/net/netfilter/xt_connlimit.c +++ b/net/netfilter/xt_connlimit.c | |||
| @@ -103,7 +103,7 @@ static int count_them(struct xt_connlimit_data *data, | |||
| 103 | const struct nf_conntrack_tuple *tuple, | 103 | const struct nf_conntrack_tuple *tuple, |
| 104 | const union nf_inet_addr *addr, | 104 | const union nf_inet_addr *addr, |
| 105 | const union nf_inet_addr *mask, | 105 | const union nf_inet_addr *mask, |
| 106 | const struct xt_match *match) | 106 | u_int8_t family) |
| 107 | { | 107 | { |
| 108 | const struct nf_conntrack_tuple_hash *found; | 108 | const struct nf_conntrack_tuple_hash *found; |
| 109 | struct xt_connlimit_conn *conn; | 109 | struct xt_connlimit_conn *conn; |
| @@ -113,8 +113,7 @@ static int count_them(struct xt_connlimit_data *data, | |||
| 113 | bool addit = true; | 113 | bool addit = true; |
| 114 | int matches = 0; | 114 | int matches = 0; |
| 115 | 115 | ||
| 116 | 116 | if (family == NFPROTO_IPV6) | |
| 117 | if (match->family == NFPROTO_IPV6) | ||
| 118 | hash = &data->iphash[connlimit_iphash6(addr, mask)]; | 117 | hash = &data->iphash[connlimit_iphash6(addr, mask)]; |
| 119 | else | 118 | else |
| 120 | hash = &data->iphash[connlimit_iphash(addr->ip & mask->ip)]; | 119 | hash = &data->iphash[connlimit_iphash(addr->ip & mask->ip)]; |
| @@ -157,8 +156,7 @@ static int count_them(struct xt_connlimit_data *data, | |||
| 157 | continue; | 156 | continue; |
| 158 | } | 157 | } |
| 159 | 158 | ||
| 160 | if (same_source_net(addr, mask, &conn->tuple.src.u3, | 159 | if (same_source_net(addr, mask, &conn->tuple.src.u3, family)) |
| 161 | match->family)) | ||
| 162 | /* same source network -> be counted! */ | 160 | /* same source network -> be counted! */ |
| 163 | ++matches; | 161 | ++matches; |
| 164 | nf_ct_put(found_ct); | 162 | nf_ct_put(found_ct); |
| @@ -207,7 +205,7 @@ connlimit_mt(const struct sk_buff *skb, const struct xt_match_param *par) | |||
| 207 | 205 | ||
| 208 | spin_lock_bh(&info->data->lock); | 206 | spin_lock_bh(&info->data->lock); |
| 209 | connections = count_them(info->data, tuple_ptr, &addr, | 207 | connections = count_them(info->data, tuple_ptr, &addr, |
| 210 | &info->mask, par->match); | 208 | &info->mask, par->family); |
| 211 | spin_unlock_bh(&info->data->lock); | 209 | spin_unlock_bh(&info->data->lock); |
| 212 | 210 | ||
| 213 | if (connections < 0) { | 211 | if (connections < 0) { |
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c index 9478d9b3d977..f3e21989b88c 100644 --- a/net/rose/rose_route.c +++ b/net/rose/rose_route.c | |||
| @@ -578,18 +578,18 @@ static int rose_clear_routes(void) | |||
| 578 | 578 | ||
| 579 | /* | 579 | /* |
| 580 | * Check that the device given is a valid AX.25 interface that is "up". | 580 | * Check that the device given is a valid AX.25 interface that is "up". |
| 581 | * called whith RTNL | ||
| 581 | */ | 582 | */ |
| 582 | static struct net_device *rose_ax25_dev_get(char *devname) | 583 | static struct net_device *rose_ax25_dev_find(char *devname) |
| 583 | { | 584 | { |
| 584 | struct net_device *dev; | 585 | struct net_device *dev; |
| 585 | 586 | ||
| 586 | if ((dev = dev_get_by_name(&init_net, devname)) == NULL) | 587 | if ((dev = __dev_get_by_name(&init_net, devname)) == NULL) |
| 587 | return NULL; | 588 | return NULL; |
| 588 | 589 | ||
| 589 | if ((dev->flags & IFF_UP) && dev->type == ARPHRD_AX25) | 590 | if ((dev->flags & IFF_UP) && dev->type == ARPHRD_AX25) |
| 590 | return dev; | 591 | return dev; |
| 591 | 592 | ||
| 592 | dev_put(dev); | ||
| 593 | return NULL; | 593 | return NULL; |
| 594 | } | 594 | } |
| 595 | 595 | ||
| @@ -720,27 +720,23 @@ int rose_rt_ioctl(unsigned int cmd, void __user *arg) | |||
| 720 | case SIOCADDRT: | 720 | case SIOCADDRT: |
| 721 | if (copy_from_user(&rose_route, arg, sizeof(struct rose_route_struct))) | 721 | if (copy_from_user(&rose_route, arg, sizeof(struct rose_route_struct))) |
| 722 | return -EFAULT; | 722 | return -EFAULT; |
| 723 | if ((dev = rose_ax25_dev_get(rose_route.device)) == NULL) | 723 | if ((dev = rose_ax25_dev_find(rose_route.device)) == NULL) |
| 724 | return -EINVAL; | 724 | return -EINVAL; |
| 725 | if (rose_dev_exists(&rose_route.address)) { /* Can't add routes to ourself */ | 725 | if (rose_dev_exists(&rose_route.address)) /* Can't add routes to ourself */ |
| 726 | dev_put(dev); | ||
| 727 | return -EINVAL; | 726 | return -EINVAL; |
| 728 | } | ||
| 729 | if (rose_route.mask > 10) /* Mask can't be more than 10 digits */ | 727 | if (rose_route.mask > 10) /* Mask can't be more than 10 digits */ |
| 730 | return -EINVAL; | 728 | return -EINVAL; |
| 731 | if (rose_route.ndigis > AX25_MAX_DIGIS) | 729 | if (rose_route.ndigis > AX25_MAX_DIGIS) |
| 732 | return -EINVAL; | 730 | return -EINVAL; |
| 733 | err = rose_add_node(&rose_route, dev); | 731 | err = rose_add_node(&rose_route, dev); |
| 734 | dev_put(dev); | ||
| 735 | return err; | 732 | return err; |
| 736 | 733 | ||
| 737 | case SIOCDELRT: | 734 | case SIOCDELRT: |
| 738 | if (copy_from_user(&rose_route, arg, sizeof(struct rose_route_struct))) | 735 | if (copy_from_user(&rose_route, arg, sizeof(struct rose_route_struct))) |
| 739 | return -EFAULT; | 736 | return -EFAULT; |
| 740 | if ((dev = rose_ax25_dev_get(rose_route.device)) == NULL) | 737 | if ((dev = rose_ax25_dev_find(rose_route.device)) == NULL) |
| 741 | return -EINVAL; | 738 | return -EINVAL; |
| 742 | err = rose_del_node(&rose_route, dev); | 739 | err = rose_del_node(&rose_route, dev); |
| 743 | dev_put(dev); | ||
| 744 | return err; | 740 | return err; |
| 745 | 741 | ||
| 746 | case SIOCRSCLRRT: | 742 | case SIOCRSCLRRT: |
