diff options
author | Kurt Garloff <garloff@suse.de> | 2006-04-03 09:20:08 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2006-04-14 14:56:56 -0400 |
commit | 13f7e5acc8b329080672c13f05f252ace5b79825 (patch) | |
tree | 917c208390543eb0f926850778bf0540486e7ba3 | |
parent | 6c7154c97e20c0ea28547240dc86731c0cee1b2f (diff) |
[SCSI] BLIST_ATTACH_PQ3 flags
Some devices report a peripheral qualifier of 3 for LUN 0; with the original
code, we would still try a REPORT_LUNS scan (if SCSI level is >= 3 or if we
have the BLIST_REPORTLUNS2 passed in), but NOT any sequential scan.
Also, the device at LUN 0 (which is not connected according to the PQ) is not
registered with the OS.
Unfortunately, SANs exist that are SCSI-2 and do NOT support REPORT_LUNS, but
report a unknown device with PQ 3 on LUN 0. We still need to scan them, and
most probably we even need BLIST_SPARSELUN (and BLIST_LARGELUN). See the bug
reference for an infamous example.
This is patch 3/3:
3. Implement the blacklist flag BLIST_ATTACH_PQ3 that makes the scsi
scanning code register PQ3 devices and continues scanning; only sg
will attach thanks to scsi_bus_match().
Signed-off-by: Kurt Garloff <garloff@suse.de>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r-- | drivers/scsi/scsi_devinfo.c | 2 | ||||
-rw-r--r-- | drivers/scsi/scsi_scan.c | 2 | ||||
-rw-r--r-- | include/scsi/scsi_devinfo.h | 1 |
3 files changed, 4 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index 84c3937ae8fb..6f46b338c991 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/drivers/scsi/scsi_devinfo.c | |||
@@ -155,6 +155,8 @@ static struct { | |||
155 | {"HITACHI", "DF400", "*", BLIST_SPARSELUN}, | 155 | {"HITACHI", "DF400", "*", BLIST_SPARSELUN}, |
156 | {"HITACHI", "DF500", "*", BLIST_SPARSELUN}, | 156 | {"HITACHI", "DF500", "*", BLIST_SPARSELUN}, |
157 | {"HITACHI", "DF600", "*", BLIST_SPARSELUN}, | 157 | {"HITACHI", "DF600", "*", BLIST_SPARSELUN}, |
158 | {"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_ATTACH_PQ3 | BLIST_SPARSELUN | BLIST_LARGELUN}, | ||
159 | {"HITACHI", "OPEN-E", "*", BLIST_ATTACH_PQ3 | BLIST_SPARSELUN | BLIST_LARGELUN}, | ||
158 | {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP VA7400 */ | 160 | {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP VA7400 */ |
159 | {"HP", "OPEN-", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP XP Arrays */ | 161 | {"HP", "OPEN-", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP XP Arrays */ |
160 | {"HP", "NetRAID-4M", NULL, BLIST_FORCELUN}, | 162 | {"HP", "NetRAID-4M", NULL, BLIST_FORCELUN}, |
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 5603dc6eca47..7d31a4b0f802 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c | |||
@@ -900,7 +900,7 @@ static int scsi_probe_and_add_lun(struct scsi_target *starget, | |||
900 | /* | 900 | /* |
901 | * result contains valid SCSI INQUIRY data. | 901 | * result contains valid SCSI INQUIRY data. |
902 | */ | 902 | */ |
903 | if ((result[0] >> 5) == 3) { | 903 | if (((result[0] >> 5) == 3) && !(bflags & BLIST_ATTACH_PQ3)) { |
904 | /* | 904 | /* |
905 | * For a Peripheral qualifier 3 (011b), the SCSI | 905 | * For a Peripheral qualifier 3 (011b), the SCSI |
906 | * spec says: The device server is not capable of | 906 | * spec says: The device server is not capable of |
diff --git a/include/scsi/scsi_devinfo.h b/include/scsi/scsi_devinfo.h index 174101b2069b..599966898208 100644 --- a/include/scsi/scsi_devinfo.h +++ b/include/scsi/scsi_devinfo.h | |||
@@ -28,4 +28,5 @@ | |||
28 | #define BLIST_NO_ULD_ATTACH 0x100000 /* device is actually for RAID config */ | 28 | #define BLIST_NO_ULD_ATTACH 0x100000 /* device is actually for RAID config */ |
29 | #define BLIST_SELECT_NO_ATN 0x200000 /* select without ATN */ | 29 | #define BLIST_SELECT_NO_ATN 0x200000 /* select without ATN */ |
30 | #define BLIST_RETRY_HWERROR 0x400000 /* retry HARDWARE_ERROR */ | 30 | #define BLIST_RETRY_HWERROR 0x400000 /* retry HARDWARE_ERROR */ |
31 | #define BLIST_ATTACH_PQ3 0x800000 /* Scan: Attach to PQ3 devices */ | ||
31 | #endif | 32 | #endif |