diff options
author | Hauke Mehrtens <hauke@hauke-m.de> | 2012-10-03 07:34:17 -0400 |
---|---|---|
committer | John Crispin <blogic@openwrt.org> | 2012-11-09 05:37:17 -0500 |
commit | c47cc20ca53e792938556aa29103fa889ce0d858 (patch) | |
tree | 55182513e1ffc244339cc41ba5513519bc095d1c | |
parent | d3dce3d676373b1519546721ee5f3a8c613f40f5 (diff) |
MIPS: BCM47XX: improve memory size detection
The memory size is detected by finding a place where it repeats in
memory. Currently we are just checking when the function prom_init is
seen again, but it is better to check for a bigger part of the memory
to decrease the chance of wrong results.
This should fix a problem we saw in OpenWrt, where the detected
available memory decreed on some devices when doing a soft reboot.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Patchwork: http://patchwork.linux-mips.org/patch/4362
Signed-off-by: John Crispin <blogic@openwrt.org>
-rw-r--r-- | arch/mips/bcm47xx/prom.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/arch/mips/bcm47xx/prom.c b/arch/mips/bcm47xx/prom.c index 22258a4c652b..8c155afb1299 100644 --- a/arch/mips/bcm47xx/prom.c +++ b/arch/mips/bcm47xx/prom.c | |||
@@ -1,6 +1,7 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) 2004 Florian Schirmer <jolt@tuxbox.org> | 2 | * Copyright (C) 2004 Florian Schirmer <jolt@tuxbox.org> |
3 | * Copyright (C) 2007 Aurelien Jarno <aurelien@aurel32.net> | 3 | * Copyright (C) 2007 Aurelien Jarno <aurelien@aurel32.net> |
4 | * Copyright (C) 2010-2012 Hauke Mehrtens <hauke@hauke-m.de> | ||
4 | * | 5 | * |
5 | * This program is free software; you can redistribute it and/or modify it | 6 | * This program is free software; you can redistribute it and/or modify it |
6 | * under the terms of the GNU General Public License as published by the | 7 | * under the terms of the GNU General Public License as published by the |
@@ -128,6 +129,7 @@ static __init void prom_init_mem(void) | |||
128 | { | 129 | { |
129 | unsigned long mem; | 130 | unsigned long mem; |
130 | unsigned long max; | 131 | unsigned long max; |
132 | unsigned long off; | ||
131 | struct cpuinfo_mips *c = ¤t_cpu_data; | 133 | struct cpuinfo_mips *c = ¤t_cpu_data; |
132 | 134 | ||
133 | /* Figure out memory size by finding aliases. | 135 | /* Figure out memory size by finding aliases. |
@@ -145,15 +147,15 @@ static __init void prom_init_mem(void) | |||
145 | * max contains the biggest possible address supported by the platform. | 147 | * max contains the biggest possible address supported by the platform. |
146 | * If the method wants to try something above we assume 128MB ram. | 148 | * If the method wants to try something above we assume 128MB ram. |
147 | */ | 149 | */ |
148 | max = ((unsigned long)(prom_init) | ((128 << 20) - 1)); | 150 | off = (unsigned long)prom_init; |
151 | max = off | ((128 << 20) - 1); | ||
149 | for (mem = (1 << 20); mem < (128 << 20); mem += (1 << 20)) { | 152 | for (mem = (1 << 20); mem < (128 << 20); mem += (1 << 20)) { |
150 | if (((unsigned long)(prom_init) + mem) > max) { | 153 | if ((off + mem) > max) { |
151 | mem = (128 << 20); | 154 | mem = (128 << 20); |
152 | printk(KERN_DEBUG "assume 128MB RAM\n"); | 155 | printk(KERN_DEBUG "assume 128MB RAM\n"); |
153 | break; | 156 | break; |
154 | } | 157 | } |
155 | if (*(unsigned long *)((unsigned long)(prom_init) + mem) == | 158 | if (!memcmp(prom_init, prom_init + mem, 32)) |
156 | *(unsigned long *)(prom_init)) | ||
157 | break; | 159 | break; |
158 | } | 160 | } |
159 | 161 | ||