aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjorn Helgaas <bjorn.helgaas@hp.com>2009-09-21 15:35:24 -0400
committerLen Brown <len.brown@intel.com>2009-09-25 15:09:47 -0400
commitb2972f87508a21db7584d11fdb5c97cb7101a788 (patch)
tree7a8b80e20c910461bdf50590c9493ec1ba095f1e
parent7f47fa6c2ff15f5e59cdbb350f86faef6829294a (diff)
ACPI: remove acpi_device.flags.compatible_ids
We now keep a single list of IDs that includes both the _HID and any _CIDs. We no longer need to keep track of whether the device has a _CID. Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r--drivers/acpi/scan.c15
-rw-r--r--include/acpi/acpi_bus.h3
2 files changed, 5 insertions, 13 deletions
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 2e8889f62666..395ae129aae0 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -47,7 +47,7 @@ static int create_modalias(struct acpi_device *acpi_dev, char *modalias,
47 int count; 47 int count;
48 struct acpi_hardware_id *id; 48 struct acpi_hardware_id *id;
49 49
50 if (!acpi_dev->flags.hardware_id && !acpi_dev->flags.compatible_ids) 50 if (!acpi_dev->flags.hardware_id)
51 return -ENODEV; 51 return -ENODEV;
52 52
53 len = snprintf(modalias, size, "acpi:"); 53 len = snprintf(modalias, size, "acpi:");
@@ -209,7 +209,7 @@ static int acpi_device_setup_files(struct acpi_device *dev)
209 goto end; 209 goto end;
210 } 210 }
211 211
212 if (dev->flags.hardware_id || dev->flags.compatible_ids) { 212 if (dev->flags.hardware_id) {
213 result = device_create_file(&dev->dev, &dev_attr_modalias); 213 result = device_create_file(&dev->dev, &dev_attr_modalias);
214 if (result) 214 if (result)
215 goto end; 215 goto end;
@@ -239,7 +239,7 @@ static void acpi_device_remove_files(struct acpi_device *dev)
239 if (ACPI_SUCCESS(status)) 239 if (ACPI_SUCCESS(status))
240 device_remove_file(&dev->dev, &dev_attr_eject); 240 device_remove_file(&dev->dev, &dev_attr_eject);
241 241
242 if (dev->flags.hardware_id || dev->flags.compatible_ids) 242 if (dev->flags.hardware_id)
243 device_remove_file(&dev->dev, &dev_attr_modalias); 243 device_remove_file(&dev->dev, &dev_attr_modalias);
244 244
245 if (dev->flags.hardware_id) 245 if (dev->flags.hardware_id)
@@ -876,11 +876,6 @@ static int acpi_bus_get_flags(struct acpi_device *device)
876 if (ACPI_SUCCESS(status)) 876 if (ACPI_SUCCESS(status))
877 device->flags.dynamic_status = 1; 877 device->flags.dynamic_status = 1;
878 878
879 /* Presence of _CID indicates 'compatible_ids' */
880 status = acpi_get_handle(device->handle, "_CID", &temp);
881 if (ACPI_SUCCESS(status))
882 device->flags.compatible_ids = 1;
883
884 /* Presence of _RMV indicates 'removable' */ 879 /* Presence of _RMV indicates 'removable' */
885 status = acpi_get_handle(device->handle, "_RMV", &temp); 880 status = acpi_get_handle(device->handle, "_RMV", &temp);
886 if (ACPI_SUCCESS(status)) 881 if (ACPI_SUCCESS(status))
@@ -1125,10 +1120,8 @@ static void acpi_device_set_id(struct acpi_device *device)
1125 if (cid_list) 1120 if (cid_list)
1126 for (i = 0; i < cid_list->count; i++) 1121 for (i = 0; i < cid_list->count; i++)
1127 acpi_add_id(device, cid_list->ids[i].string); 1122 acpi_add_id(device, cid_list->ids[i].string);
1128 if (cid_add) { 1123 if (cid_add)
1129 acpi_add_id(device, cid_add); 1124 acpi_add_id(device, cid_add);
1130 device->flags.compatible_ids = 1;
1131 }
1132 1125
1133 kfree(info); 1126 kfree(info);
1134} 1127}
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index c2c434626edc..0a970e4ade6f 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -142,7 +142,6 @@ struct acpi_device_status {
142struct acpi_device_flags { 142struct acpi_device_flags {
143 u32 dynamic_status:1; 143 u32 dynamic_status:1;
144 u32 hardware_id:1; 144 u32 hardware_id:1;
145 u32 compatible_ids:1;
146 u32 bus_address:1; 145 u32 bus_address:1;
147 u32 unique_id:1; 146 u32 unique_id:1;
148 u32 removable:1; 147 u32 removable:1;
@@ -153,7 +152,7 @@ struct acpi_device_flags {
153 u32 performance_manageable:1; 152 u32 performance_manageable:1;
154 u32 wake_capable:1; /* Wakeup(_PRW) supported? */ 153 u32 wake_capable:1; /* Wakeup(_PRW) supported? */
155 u32 force_power_state:1; 154 u32 force_power_state:1;
156 u32 reserved:19; 155 u32 reserved:20;
157}; 156};
158 157
159/* File System */ 158/* File System */