diff options
author | Jean Delvare <khali@linux-fr.org> | 2008-01-27 12:14:51 -0500 |
---|---|---|
committer | Jean Delvare <khali@hyperion.delvare> | 2008-01-27 12:14:51 -0500 |
commit | 9b7389c0edb94a2623f21a6ac90afae63f201e73 (patch) | |
tree | e53a92d108cc6a9e05d280d93c72f4b1a17cf57a | |
parent | 0f07a24b4baf14859fde39b29bcc6fe279d18109 (diff) |
i2c-piix4: Drop redundant PCI function number check
Checking the PCI function number doesn't add any value, and it makes
adding dynamic IDs to the driver more difficult. Drop this check.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
-rw-r--r-- | drivers/i2c/busses/i2c-piix4.c | 41 |
1 files changed, 15 insertions, 26 deletions
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c index 167e4137ee21..9bbe96cef719 100644 --- a/drivers/i2c/busses/i2c-piix4.c +++ b/drivers/i2c/busses/i2c-piix4.c | |||
@@ -121,10 +121,6 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev, | |||
121 | { | 121 | { |
122 | unsigned char temp; | 122 | unsigned char temp; |
123 | 123 | ||
124 | /* match up the function */ | ||
125 | if (PCI_FUNC(PIIX4_dev->devfn) != id->driver_data) | ||
126 | return -ENODEV; | ||
127 | |||
128 | dev_info(&PIIX4_dev->dev, "Found %s device\n", pci_name(PIIX4_dev)); | 124 | dev_info(&PIIX4_dev->dev, "Found %s device\n", pci_name(PIIX4_dev)); |
129 | 125 | ||
130 | /* Don't access SMBus on IBM systems which get corrupted eeproms */ | 126 | /* Don't access SMBus on IBM systems which get corrupted eeproms */ |
@@ -389,28 +385,21 @@ static struct i2c_adapter piix4_adapter = { | |||
389 | }; | 385 | }; |
390 | 386 | ||
391 | static struct pci_device_id piix4_ids[] = { | 387 | static struct pci_device_id piix4_ids[] = { |
392 | { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371AB_3), | 388 | { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371AB_3) }, |
393 | .driver_data = 3 }, | 389 | { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443MX_3) }, |
394 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP200_SMBUS), | 390 | { PCI_DEVICE(PCI_VENDOR_ID_EFAR, PCI_DEVICE_ID_EFAR_SLC90E66_3) }, |
395 | .driver_data = 0 }, | 391 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP200_SMBUS) }, |
396 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_SMBUS), | 392 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_SMBUS) }, |
397 | .driver_data = 0 }, | 393 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_SMBUS) }, |
398 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_SMBUS), | 394 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS) }, |
399 | .driver_data = 0 }, | 395 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, |
400 | { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS), | 396 | PCI_DEVICE_ID_SERVERWORKS_OSB4) }, |
401 | .driver_data = 0 }, | 397 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, |
402 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_OSB4), | 398 | PCI_DEVICE_ID_SERVERWORKS_CSB5) }, |
403 | .driver_data = 0 }, | 399 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, |
404 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5), | 400 | PCI_DEVICE_ID_SERVERWORKS_CSB6) }, |
405 | .driver_data = 0 }, | 401 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, |
406 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB6), | 402 | PCI_DEVICE_ID_SERVERWORKS_HT1000SB) }, |
407 | .driver_data = 0 }, | ||
408 | { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_HT1000SB), | ||
409 | .driver_data = 0 }, | ||
410 | { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443MX_3), | ||
411 | .driver_data = 3 }, | ||
412 | { PCI_DEVICE(PCI_VENDOR_ID_EFAR, PCI_DEVICE_ID_EFAR_SLC90E66_3), | ||
413 | .driver_data = 0 }, | ||
414 | { 0, } | 403 | { 0, } |
415 | }; | 404 | }; |
416 | 405 | ||