diff options
author | Ralf Baechle <ralf@linux-mips.org> | 2006-07-03 22:29:15 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2006-07-03 22:29:15 -0400 |
commit | 8dc22d2b642f8a6f14ef8878777a05311e5d1d7e (patch) | |
tree | fb6ec490d0318cf7c267668f6d06391b2033b2fb | |
parent | 518d1c9679f644811adaa22d853f43a83fbdae84 (diff) |
[ROSE]: Fix dereference of skb pointer after free.
If rose_route_frame return success we'll dereference a stale pointer.
Likely this is only going to result in bad statistics for the ROSE
interface.
This fixes coverity 946.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/rose/rose_dev.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/rose/rose_dev.c b/net/rose/rose_dev.c index 9d0bf2a1ea3f..7c279e2659ec 100644 --- a/net/rose/rose_dev.c +++ b/net/rose/rose_dev.c | |||
@@ -59,6 +59,7 @@ static int rose_rebuild_header(struct sk_buff *skb) | |||
59 | struct net_device_stats *stats = netdev_priv(dev); | 59 | struct net_device_stats *stats = netdev_priv(dev); |
60 | unsigned char *bp = (unsigned char *)skb->data; | 60 | unsigned char *bp = (unsigned char *)skb->data; |
61 | struct sk_buff *skbn; | 61 | struct sk_buff *skbn; |
62 | unsigned int len; | ||
62 | 63 | ||
63 | #ifdef CONFIG_INET | 64 | #ifdef CONFIG_INET |
64 | if (arp_find(bp + 7, skb)) { | 65 | if (arp_find(bp + 7, skb)) { |
@@ -75,6 +76,8 @@ static int rose_rebuild_header(struct sk_buff *skb) | |||
75 | 76 | ||
76 | kfree_skb(skb); | 77 | kfree_skb(skb); |
77 | 78 | ||
79 | len = skbn->len; | ||
80 | |||
78 | if (!rose_route_frame(skbn, NULL)) { | 81 | if (!rose_route_frame(skbn, NULL)) { |
79 | kfree_skb(skbn); | 82 | kfree_skb(skbn); |
80 | stats->tx_errors++; | 83 | stats->tx_errors++; |
@@ -82,7 +85,7 @@ static int rose_rebuild_header(struct sk_buff *skb) | |||
82 | } | 85 | } |
83 | 86 | ||
84 | stats->tx_packets++; | 87 | stats->tx_packets++; |
85 | stats->tx_bytes += skbn->len; | 88 | stats->tx_bytes += len; |
86 | #endif | 89 | #endif |
87 | return 1; | 90 | return 1; |
88 | } | 91 | } |