diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2014-07-21 14:31:17 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-07-21 14:31:17 -0400 |
commit | 6890ad4b3889e13c919108d16b6fdd8d4a118de5 (patch) | |
tree | 0fc20ec6a1fcaccbb5764acda276d1e4f633940d | |
parent | d6e6c48e5dafd77a3caf42844b59ee459fae1285 (diff) | |
parent | 3b3a1814d1703027f9867d0f5cbbfaf6c7482474 (diff) |
Merge branch 'for-linus' of git://git.kernel.dk/linux-block
Pull block fixes from Jens Axboe:
"Final block fixes for 3.16
Four small fixes that should go into 3.16, have been queued up for a
bit and delayed due to vacation and other euro duties. But here they
are. The pull request contains:
- Fix for a reported crash with shared tagging on SCSI from Christoph
- A regression fix for drbd. From Lars Ellenberg.
- Hooking up the compat ioctl for BLKZEROOUT, which requires no
translation. From Mikulas.
- A fix for a regression where we woud crash on queue exit if the
root_blkg is gone/not there. From Tejun"
* 'for-linus' of git://git.kernel.dk/linux-block:
block: provide compat ioctl for BLKZEROOUT
blkcg: don't call into policy draining if root_blkg is already gone
drbd: fix regression 'out of mem, failed to invoke fence-peer helper'
block: don't assume last put of shared tags is for the host
-rw-r--r-- | block/blk-cgroup.c | 7 | ||||
-rw-r--r-- | block/blk-tag.c | 33 | ||||
-rw-r--r-- | block/compat_ioctl.c | 1 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_nl.c | 6 |
4 files changed, 21 insertions, 26 deletions
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index b9f4cc494ece..28d227c5ca77 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c | |||
@@ -872,6 +872,13 @@ void blkcg_drain_queue(struct request_queue *q) | |||
872 | { | 872 | { |
873 | lockdep_assert_held(q->queue_lock); | 873 | lockdep_assert_held(q->queue_lock); |
874 | 874 | ||
875 | /* | ||
876 | * @q could be exiting and already have destroyed all blkgs as | ||
877 | * indicated by NULL root_blkg. If so, don't confuse policies. | ||
878 | */ | ||
879 | if (!q->root_blkg) | ||
880 | return; | ||
881 | |||
875 | blk_throtl_drain(q); | 882 | blk_throtl_drain(q); |
876 | } | 883 | } |
877 | 884 | ||
diff --git a/block/blk-tag.c b/block/blk-tag.c index 3f33d8672268..a185b86741e5 100644 --- a/block/blk-tag.c +++ b/block/blk-tag.c | |||
@@ -27,18 +27,15 @@ struct request *blk_queue_find_tag(struct request_queue *q, int tag) | |||
27 | EXPORT_SYMBOL(blk_queue_find_tag); | 27 | EXPORT_SYMBOL(blk_queue_find_tag); |
28 | 28 | ||
29 | /** | 29 | /** |
30 | * __blk_free_tags - release a given set of tag maintenance info | 30 | * blk_free_tags - release a given set of tag maintenance info |
31 | * @bqt: the tag map to free | 31 | * @bqt: the tag map to free |
32 | * | 32 | * |
33 | * Tries to free the specified @bqt. Returns true if it was | 33 | * Drop the reference count on @bqt and frees it when the last reference |
34 | * actually freed and false if there are still references using it | 34 | * is dropped. |
35 | */ | 35 | */ |
36 | static int __blk_free_tags(struct blk_queue_tag *bqt) | 36 | void blk_free_tags(struct blk_queue_tag *bqt) |
37 | { | 37 | { |
38 | int retval; | 38 | if (atomic_dec_and_test(&bqt->refcnt)) { |
39 | |||
40 | retval = atomic_dec_and_test(&bqt->refcnt); | ||
41 | if (retval) { | ||
42 | BUG_ON(find_first_bit(bqt->tag_map, bqt->max_depth) < | 39 | BUG_ON(find_first_bit(bqt->tag_map, bqt->max_depth) < |
43 | bqt->max_depth); | 40 | bqt->max_depth); |
44 | 41 | ||
@@ -50,9 +47,8 @@ static int __blk_free_tags(struct blk_queue_tag *bqt) | |||
50 | 47 | ||
51 | kfree(bqt); | 48 | kfree(bqt); |
52 | } | 49 | } |
53 | |||
54 | return retval; | ||
55 | } | 50 | } |
51 | EXPORT_SYMBOL(blk_free_tags); | ||
56 | 52 | ||
57 | /** | 53 | /** |
58 | * __blk_queue_free_tags - release tag maintenance info | 54 | * __blk_queue_free_tags - release tag maintenance info |
@@ -69,28 +65,13 @@ void __blk_queue_free_tags(struct request_queue *q) | |||
69 | if (!bqt) | 65 | if (!bqt) |
70 | return; | 66 | return; |
71 | 67 | ||
72 | __blk_free_tags(bqt); | 68 | blk_free_tags(bqt); |
73 | 69 | ||
74 | q->queue_tags = NULL; | 70 | q->queue_tags = NULL; |
75 | queue_flag_clear_unlocked(QUEUE_FLAG_QUEUED, q); | 71 | queue_flag_clear_unlocked(QUEUE_FLAG_QUEUED, q); |
76 | } | 72 | } |
77 | 73 | ||
78 | /** | 74 | /** |
79 | * blk_free_tags - release a given set of tag maintenance info | ||
80 | * @bqt: the tag map to free | ||
81 | * | ||
82 | * For externally managed @bqt frees the map. Callers of this | ||
83 | * function must guarantee to have released all the queues that | ||
84 | * might have been using this tag map. | ||
85 | */ | ||
86 | void blk_free_tags(struct blk_queue_tag *bqt) | ||
87 | { | ||
88 | if (unlikely(!__blk_free_tags(bqt))) | ||
89 | BUG(); | ||
90 | } | ||
91 | EXPORT_SYMBOL(blk_free_tags); | ||
92 | |||
93 | /** | ||
94 | * blk_queue_free_tags - release tag maintenance info | 75 | * blk_queue_free_tags - release tag maintenance info |
95 | * @q: the request queue for the device | 76 | * @q: the request queue for the device |
96 | * | 77 | * |
diff --git a/block/compat_ioctl.c b/block/compat_ioctl.c index fbd5a67cb773..a0926a6094b2 100644 --- a/block/compat_ioctl.c +++ b/block/compat_ioctl.c | |||
@@ -690,6 +690,7 @@ long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg) | |||
690 | case BLKROSET: | 690 | case BLKROSET: |
691 | case BLKDISCARD: | 691 | case BLKDISCARD: |
692 | case BLKSECDISCARD: | 692 | case BLKSECDISCARD: |
693 | case BLKZEROOUT: | ||
693 | /* | 694 | /* |
694 | * the ones below are implemented in blkdev_locked_ioctl, | 695 | * the ones below are implemented in blkdev_locked_ioctl, |
695 | * but we call blkdev_ioctl, which gets the lock for us | 696 | * but we call blkdev_ioctl, which gets the lock for us |
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 1b35c45c92b7..3f2e16738080 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c | |||
@@ -544,6 +544,12 @@ void conn_try_outdate_peer_async(struct drbd_connection *connection) | |||
544 | struct task_struct *opa; | 544 | struct task_struct *opa; |
545 | 545 | ||
546 | kref_get(&connection->kref); | 546 | kref_get(&connection->kref); |
547 | /* We may just have force_sig()'ed this thread | ||
548 | * to get it out of some blocking network function. | ||
549 | * Clear signals; otherwise kthread_run(), which internally uses | ||
550 | * wait_on_completion_killable(), will mistake our pending signal | ||
551 | * for a new fatal signal and fail. */ | ||
552 | flush_signals(current); | ||
547 | opa = kthread_run(_try_outdate_peer_async, connection, "drbd_async_h"); | 553 | opa = kthread_run(_try_outdate_peer_async, connection, "drbd_async_h"); |
548 | if (IS_ERR(opa)) { | 554 | if (IS_ERR(opa)) { |
549 | drbd_err(connection, "out of mem, failed to invoke fence-peer helper\n"); | 555 | drbd_err(connection, "out of mem, failed to invoke fence-peer helper\n"); |