diff options
author | Anton Blanchard <anton@samba.org> | 2010-05-10 12:27:38 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-05-21 03:31:10 -0400 |
commit | 5d7a87217de48b234b3c8ff8a73059947d822e07 (patch) | |
tree | b78bacd1b933f762333c79cf0cad5e53bc50b3cb | |
parent | 0644079410065567e3bb31fcb8e6441f2b7685a9 (diff) |
powerpc/kdump: Use chip->shutdown to disable IRQs
I saw this in a kdump kernel:
IOMMU table initialized, virtual merging enabled
Interrupt 155954 (real) is invalid, disabling it.
Interrupt 155953 (real) is invalid, disabling it.
ie we took some spurious interrupts. default_machine_crash_shutdown tries
to disable all interrupt sources but uses chip->disable which maps to
the default action of:
static void default_disable(unsigned int irq)
{
}
If we use chip->shutdown, then we actually mask the IRQ:
static void default_shutdown(unsigned int irq)
{
struct irq_desc *desc = irq_to_desc(irq);
desc->chip->mask(irq);
desc->status |= IRQ_MASKED;
}
Not sure why we don't implement a ->disable action for xics.c, or why
default_disable doesn't mask the interrupt.
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r-- | arch/powerpc/kernel/crash.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index 7ced58dacb12..cca7c8fafc1c 100644 --- a/arch/powerpc/kernel/crash.c +++ b/arch/powerpc/kernel/crash.c | |||
@@ -384,7 +384,7 @@ void default_machine_crash_shutdown(struct pt_regs *regs) | |||
384 | desc->chip->eoi(i); | 384 | desc->chip->eoi(i); |
385 | 385 | ||
386 | if (!(desc->status & IRQ_DISABLED)) | 386 | if (!(desc->status & IRQ_DISABLED)) |
387 | desc->chip->disable(i); | 387 | desc->chip->shutdown(i); |
388 | } | 388 | } |
389 | 389 | ||
390 | /* | 390 | /* |