aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Lamparter <chunkeey@googlemail.com>2012-08-11 07:09:20 -0400
committerJohn W. Linville <linville@tuxdriver.com>2012-08-13 15:28:35 -0400
commit22c5649eef0fc37532e20c14d2656b28ca708a69 (patch)
tree6e9a5d247dcffff5e9286065de27c0169cb672b8
parentdf32381896f5f0c78a371df2e49ab7c776b1a5ba (diff)
p54: fix powerpc gcc warnings
My commit "p54: parse output power table" introduced the following compiler warnings for powerpc-allmodconfig eeprom.c: In function 'p54_get_maxpower': eeprom.c:291 warning: comparison of distinct pointer types lacks a cast eeporm.c:292 warning: comparison of distinct pointer types lacks a cast eeprom.c:293 warning: comparison of distinct pointer types lacks a cast eeprom.c:294 warning: comparison of distinct pointer types lacks a cast This patch fixes those by using max_t(u16 which forces a type cast. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Tested-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/p54/eeprom.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/net/wireless/p54/eeprom.c b/drivers/net/wireless/p54/eeprom.c
index d4d86107e05a..1ef1bfe6a9d7 100644
--- a/drivers/net/wireless/p54/eeprom.c
+++ b/drivers/net/wireless/p54/eeprom.c
@@ -288,10 +288,14 @@ static int p54_get_maxpower(struct p54_common *priv, void *data)
288 for (j = 0; j < ARRAY_SIZE(pda->point); j++) { 288 for (j = 0; j < ARRAY_SIZE(pda->point); j++) {
289 struct pda_channel_output_limit_point_longbow *point = 289 struct pda_channel_output_limit_point_longbow *point =
290 &pda->point[j]; 290 &pda->point[j];
291 rawpower = max(rawpower, le16_to_cpu(point->val_qpsk)); 291 rawpower = max_t(u16,
292 rawpower = max(rawpower, le16_to_cpu(point->val_bpsk)); 292 rawpower, le16_to_cpu(point->val_qpsk));
293 rawpower = max(rawpower, le16_to_cpu(point->val_16qam)); 293 rawpower = max_t(u16,
294 rawpower = max(rawpower, le16_to_cpu(point->val_64qam)); 294 rawpower, le16_to_cpu(point->val_bpsk));
295 rawpower = max_t(u16,
296 rawpower, le16_to_cpu(point->val_16qam));
297 rawpower = max_t(u16,
298 rawpower, le16_to_cpu(point->val_64qam));
295 } 299 }
296 /* longbow seems to use 1/16 dBm units */ 300 /* longbow seems to use 1/16 dBm units */
297 return rawpower / 16; 301 return rawpower / 16;