diff options
author | Alan Stern <stern@rowland.harvard.edu> | 2005-12-20 09:58:08 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-03-20 17:49:57 -0500 |
commit | dbf4fcad62467ce1bd6966292b6850fc7a210e0b (patch) | |
tree | 4b8da787d4f54fbd442a18a93658e3e5dd7ce176 | |
parent | 8d402e1ae03656c1ad215514f8885ef4793f0948 (diff) |
[PATCH] UHCI: Don't log short transfers
Even when the URB_SHORT_NOT_OK flag is set, a short transfer shouldn't
generate a debugging log message. Especially not one with the confusing
claim that the transfer "failed with status 0". This patch (as627)
fixes that behavior in uhci-hcd.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/usb/host/uhci-q.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/uhci-q.c b/drivers/usb/host/uhci-q.c index 5d6c4f75d0d8..0c1b12091c48 100644 --- a/drivers/usb/host/uhci-q.c +++ b/drivers/usb/host/uhci-q.c | |||
@@ -922,7 +922,6 @@ static int uhci_result_common(struct uhci_hcd *uhci, struct urb *urb) | |||
922 | td_error: | 922 | td_error: |
923 | ret = uhci_map_status(status, uhci_packetout(td_token(td))); | 923 | ret = uhci_map_status(status, uhci_packetout(td_token(td))); |
924 | 924 | ||
925 | err: | ||
926 | if ((debug == 1 && ret != -EPIPE) || debug > 1) { | 925 | if ((debug == 1 && ret != -EPIPE) || debug > 1) { |
927 | /* Some debugging code */ | 926 | /* Some debugging code */ |
928 | dev_dbg(uhci_dev(uhci), "%s: failed with status %x\n", | 927 | dev_dbg(uhci_dev(uhci), "%s: failed with status %x\n", |
@@ -934,6 +933,7 @@ err: | |||
934 | lprintk(errbuf); | 933 | lprintk(errbuf); |
935 | } | 934 | } |
936 | } | 935 | } |
936 | err: | ||
937 | 937 | ||
938 | /* Note that the queue has stopped and save the next toggle value */ | 938 | /* Note that the queue has stopped and save the next toggle value */ |
939 | urbp->qh->element = UHCI_PTR_TERM; | 939 | urbp->qh->element = UHCI_PTR_TERM; |