diff options
author | Borislav Petkov <petkovbb@googlemail.com> | 2008-04-27 09:38:34 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-27 09:38:34 -0400 |
commit | 9798630a75c2c13849aeefcc1ba0559a701b5d95 (patch) | |
tree | 6e2635f787d67160871febd16ea0df463169770c | |
parent | fd0949e6e84e4e1649d8ea7367e78e72f59bb19f (diff) |
ide-tape: make __idetape_discard_read_pipeline() of type void
It always returns 0 which has no effect on tape positioning calculation so
simplify it by converting its type to void, bringing no functional change to the
driver.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r-- | drivers/ide/ide-tape.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 4e93a82f57ed..3c61770020ef 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c | |||
@@ -1641,12 +1641,12 @@ static int idetape_create_prevent_cmd(ide_drive_t *drive, | |||
1641 | return 1; | 1641 | return 1; |
1642 | } | 1642 | } |
1643 | 1643 | ||
1644 | static int __idetape_discard_read_pipeline(ide_drive_t *drive) | 1644 | static void __idetape_discard_read_pipeline(ide_drive_t *drive) |
1645 | { | 1645 | { |
1646 | idetape_tape_t *tape = drive->driver_data; | 1646 | idetape_tape_t *tape = drive->driver_data; |
1647 | 1647 | ||
1648 | if (tape->chrdev_dir != IDETAPE_DIR_READ) | 1648 | if (tape->chrdev_dir != IDETAPE_DIR_READ) |
1649 | return 0; | 1649 | return; |
1650 | 1650 | ||
1651 | clear_bit(IDETAPE_FLAG_FILEMARK, &tape->flags); | 1651 | clear_bit(IDETAPE_FLAG_FILEMARK, &tape->flags); |
1652 | tape->merge_stage_size = 0; | 1652 | tape->merge_stage_size = 0; |
@@ -1656,8 +1656,6 @@ static int __idetape_discard_read_pipeline(ide_drive_t *drive) | |||
1656 | } | 1656 | } |
1657 | 1657 | ||
1658 | tape->chrdev_dir = IDETAPE_DIR_NONE; | 1658 | tape->chrdev_dir = IDETAPE_DIR_NONE; |
1659 | |||
1660 | return 0; | ||
1661 | } | 1659 | } |
1662 | 1660 | ||
1663 | /* | 1661 | /* |
@@ -1689,13 +1687,12 @@ static void idetape_discard_read_pipeline(ide_drive_t *drive, | |||
1689 | int restore_position) | 1687 | int restore_position) |
1690 | { | 1688 | { |
1691 | idetape_tape_t *tape = drive->driver_data; | 1689 | idetape_tape_t *tape = drive->driver_data; |
1692 | int cnt; | ||
1693 | int seek, position; | 1690 | int seek, position; |
1694 | 1691 | ||
1695 | cnt = __idetape_discard_read_pipeline(drive); | 1692 | __idetape_discard_read_pipeline(drive); |
1696 | if (restore_position) { | 1693 | if (restore_position) { |
1697 | position = idetape_read_position(drive); | 1694 | position = idetape_read_position(drive); |
1698 | seek = position > cnt ? position - cnt : 0; | 1695 | seek = position > 0 ? position : 0; |
1699 | if (idetape_position_tape(drive, seek, 0, 0)) { | 1696 | if (idetape_position_tape(drive, seek, 0, 0)) { |
1700 | printk(KERN_INFO "ide-tape: %s: position_tape failed in" | 1697 | printk(KERN_INFO "ide-tape: %s: position_tape failed in" |
1701 | " discard_pipeline()\n", tape->name); | 1698 | " discard_pipeline()\n", tape->name); |