diff options
author | Wu Fengguang <fengguang.wu@intel.com> | 2008-11-27 05:42:22 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2009-01-06 05:28:05 -0500 |
commit | 8e6bdb7f8b478323525444ecee7a1477ff5b6639 (patch) | |
tree | 02ff4e100e37a3fb8cf12b9cb321abe4ded58f36 | |
parent | 2b6a2f535dda8c60721b78699618d13d6799a29e (diff) |
trivial: radix-tree: document wrap-around issue of radix_tree_next_hole()
And some 80-line cleanups.
Signed-off-by: Wu Fengguang <wfg@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r-- | lib/radix-tree.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/lib/radix-tree.c b/lib/radix-tree.c index be86b32bc874..a7f5217dd67b 100644 --- a/lib/radix-tree.c +++ b/lib/radix-tree.c | |||
@@ -640,13 +640,14 @@ EXPORT_SYMBOL(radix_tree_tag_get); | |||
640 | * | 640 | * |
641 | * Returns: the index of the hole if found, otherwise returns an index | 641 | * Returns: the index of the hole if found, otherwise returns an index |
642 | * outside of the set specified (in which case 'return - index >= max_scan' | 642 | * outside of the set specified (in which case 'return - index >= max_scan' |
643 | * will be true). | 643 | * will be true). In rare cases of index wrap-around, 0 will be returned. |
644 | * | 644 | * |
645 | * radix_tree_next_hole may be called under rcu_read_lock. However, like | 645 | * radix_tree_next_hole may be called under rcu_read_lock. However, like |
646 | * radix_tree_gang_lookup, this will not atomically search a snapshot of the | 646 | * radix_tree_gang_lookup, this will not atomically search a snapshot of |
647 | * tree at a single point in time. For example, if a hole is created at index | 647 | * the tree at a single point in time. For example, if a hole is created |
648 | * 5, then subsequently a hole is created at index 10, radix_tree_next_hole | 648 | * at index 5, then subsequently a hole is created at index 10, |
649 | * covering both indexes may return 10 if called under rcu_read_lock. | 649 | * radix_tree_next_hole covering both indexes may return 10 if called |
650 | * under rcu_read_lock. | ||
650 | */ | 651 | */ |
651 | unsigned long radix_tree_next_hole(struct radix_tree_root *root, | 652 | unsigned long radix_tree_next_hole(struct radix_tree_root *root, |
652 | unsigned long index, unsigned long max_scan) | 653 | unsigned long index, unsigned long max_scan) |