aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNaohiro Aota <naota@elisp.net>2010-09-30 15:23:17 -0400
committerMichal Marek <mmarek@suse.cz>2010-09-30 15:59:32 -0400
commit8bea7548ee0223175bea5fddcc54af93bd252d9b (patch)
tree59bcfb7aeb795041bb9c8d34b80c767fd656230c
parent0455029bea7da2a2a92003238c9617a36d5d48fd (diff)
kconfig: Don't go out from read config loop when you read new symbol
commit 8baefd30b5b0101aa07aa75da44a9eee881eed28 of linux-next replaced a `switch()' statement with some `if()' statements, but left `break's in the `switch()' statement untouched. This cause read config loop to exit and so "make oldconfig" is not much usable (see below). > $ make oldconfig ><snip> > scripts/kconfig/conf --oldconfig Kconfig > # > # using defaults found in /boot/config-2.6.34-ccs-r1 > # > * > * Restart config... > * > * > * General setup > * > Prompt for development and/or incomplete code/drivers (EXPERIMENTAL) [N/y/?] (NEW) (I've already have "CONFIG_EXPERIMENTAL=y" in the old config file. But that's not read here.) This patch should fix this problem. Signed-off-by: Naohiro Aota <naota@elisp.net> Signed-off-by: Michal Marek <mmarek@suse.cz>
-rw-r--r--scripts/kconfig/confdata.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index f7d89d7065b7..35c08ecaad17 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -234,7 +234,7 @@ load:
234 sym = sym_find(line + 2 + strlen(CONFIG_)); 234 sym = sym_find(line + 2 + strlen(CONFIG_));
235 if (!sym) { 235 if (!sym) {
236 sym_add_change_count(1); 236 sym_add_change_count(1);
237 break; 237 goto setsym;
238 } 238 }
239 } else { 239 } else {
240 sym = sym_lookup(line + 2 + strlen(CONFIG_), 0); 240 sym = sym_lookup(line + 2 + strlen(CONFIG_), 0);
@@ -268,7 +268,7 @@ load:
268 sym = sym_find(line + strlen(CONFIG_)); 268 sym = sym_find(line + strlen(CONFIG_));
269 if (!sym) { 269 if (!sym) {
270 sym_add_change_count(1); 270 sym_add_change_count(1);
271 break; 271 goto setsym;
272 } 272 }
273 } else { 273 } else {
274 sym = sym_lookup(line + strlen(CONFIG_), 0); 274 sym = sym_lookup(line + strlen(CONFIG_), 0);
@@ -285,6 +285,7 @@ load:
285 conf_warning("unexpected data"); 285 conf_warning("unexpected data");
286 continue; 286 continue;
287 } 287 }
288setsym:
288 if (sym && sym_is_choice_value(sym)) { 289 if (sym && sym_is_choice_value(sym)) {
289 struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym)); 290 struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym));
290 switch (sym->def[def].tri) { 291 switch (sym->def[def].tri) {