aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrom: Greg Kroah-Hartman <gregkh@suse.de>2008-10-11 18:25:51 -0400
committerJiri Kosina <jkosina@suse.cz>2008-10-14 17:51:03 -0400
commit7d89fe12bd21f1383a6a240114221bf31fd71904 (patch)
tree261850f7d0c754d9182d77a7fa56d663282f5eb8
parentddbe32491951c092abbd3647fd104e79deb19528 (diff)
HID: remove warn() macro from usb hid drivers
USB should not be having it's own printk macros, so remove warn() and use the system-wide standard of dev_warn() wherever possible. In the few places that will not work out, use a basic printk(). Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/usbhid/hid-core.c17
-rw-r--r--drivers/hid/usbhid/usbkbd.c3
2 files changed, 12 insertions, 8 deletions
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 34649d251d85..1d3b8a394d46 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -213,7 +213,8 @@ static void hid_irq_in(struct urb *urb)
213 hid_io_error(hid); 213 hid_io_error(hid);
214 return; 214 return;
215 default: /* error */ 215 default: /* error */
216 warn("input irq status %d received", urb->status); 216 dev_warn(&urb->dev->dev, "input irq status %d "
217 "received\n", urb->status);
217 } 218 }
218 219
219 status = usb_submit_urb(urb, GFP_ATOMIC); 220 status = usb_submit_urb(urb, GFP_ATOMIC);
@@ -327,7 +328,8 @@ static void hid_irq_out(struct urb *urb)
327 case -ENOENT: 328 case -ENOENT:
328 break; 329 break;
329 default: /* error */ 330 default: /* error */
330 warn("output irq status %d received", urb->status); 331 dev_warn(&urb->dev->dev, "output irq status %d "
332 "received\n", urb->status);
331 } 333 }
332 334
333 spin_lock_irqsave(&usbhid->outlock, flags); 335 spin_lock_irqsave(&usbhid->outlock, flags);
@@ -380,7 +382,8 @@ static void hid_ctrl(struct urb *urb)
380 case -EPIPE: /* report not available */ 382 case -EPIPE: /* report not available */
381 break; 383 break;
382 default: /* error */ 384 default: /* error */
383 warn("ctrl urb status %d received", urb->status); 385 dev_warn(&urb->dev->dev, "ctrl urb status %d "
386 "received\n", urb->status);
384 } 387 }
385 388
386 if (unplug) 389 if (unplug)
@@ -418,7 +421,7 @@ void usbhid_submit_report(struct hid_device *hid, struct hid_report *report, uns
418 421
419 if ((head = (usbhid->outhead + 1) & (HID_OUTPUT_FIFO_SIZE - 1)) == usbhid->outtail) { 422 if ((head = (usbhid->outhead + 1) & (HID_OUTPUT_FIFO_SIZE - 1)) == usbhid->outtail) {
420 spin_unlock_irqrestore(&usbhid->outlock, flags); 423 spin_unlock_irqrestore(&usbhid->outlock, flags);
421 warn("output queue full"); 424 dev_warn(&hid->dev, "output queue full\n");
422 return; 425 return;
423 } 426 }
424 427
@@ -444,7 +447,7 @@ void usbhid_submit_report(struct hid_device *hid, struct hid_report *report, uns
444 447
445 if ((head = (usbhid->ctrlhead + 1) & (HID_CONTROL_FIFO_SIZE - 1)) == usbhid->ctrltail) { 448 if ((head = (usbhid->ctrlhead + 1) & (HID_CONTROL_FIFO_SIZE - 1)) == usbhid->ctrltail) {
446 spin_unlock_irqrestore(&usbhid->ctrllock, flags); 449 spin_unlock_irqrestore(&usbhid->ctrllock, flags);
447 warn("control queue full"); 450 dev_warn(&hid->dev, "control queue full\n");
448 return; 451 return;
449 } 452 }
450 453
@@ -482,7 +485,7 @@ static int usb_hidinput_input_event(struct input_dev *dev, unsigned int type, un
482 return -1; 485 return -1;
483 486
484 if ((offset = hidinput_find_field(hid, type, code, &field)) == -1) { 487 if ((offset = hidinput_find_field(hid, type, code, &field)) == -1) {
485 warn("event field not found"); 488 dev_warn(&dev->dev, "event field not found\n");
486 return -1; 489 return -1;
487 } 490 }
488 491
@@ -585,7 +588,7 @@ void usbhid_init_reports(struct hid_device *hid)
585 } 588 }
586 589
587 if (err) 590 if (err)
588 warn("timeout initializing reports"); 591 dev_warn(&hid->dev, "timeout initializing reports\n");
589} 592}
590 593
591/* 594/*
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index d400afdaf2b3..b342926dd7fc 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -161,7 +161,8 @@ static void usb_kbd_led(struct urb *urb)
161 struct usb_kbd *kbd = urb->context; 161 struct usb_kbd *kbd = urb->context;
162 162
163 if (urb->status) 163 if (urb->status)
164 warn("led urb status %d received", urb->status); 164 dev_warn(&urb->dev->dev, "led urb status %d received\n",
165 urb->status);
165 166
166 if (*(kbd->leds) == kbd->newleds) 167 if (*(kbd->leds) == kbd->newleds)
167 return; 168 return;